Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread m...@mikesolomon.org
On 29 nov. 2012, at 03:23, k-ohara5...@oco.net wrote: http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc File lily/box-quarantine.cc (right): http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69 lily/box-quarantine.cc:69: int mid =

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread k-ohara5a5a
On 2012/11/29 08:28:31, mike7 wrote: On 29 nov. 2012, at 03:23, mailto:k-ohara5...@oco.net wrote: http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69 lily/box-quarantine.cc:69: int mid = ii0.mid_; assert ((double)(ii0.index - mid) = 0.0) it is possible,

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread k-ohara5a5a
It was Box_quarantine that seemed a confusing name. (Why 'quarantine'? Is there something special about 40 boxes?) I take back my suggestion. http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc File lily/box-quarantine.cc (right):

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread m...@mikesolomon.org
On 29 nov. 2012, at 10:24, k-ohara5...@oco.net wrote: It was Box_quarantine that seemed a confusing name. (Why 'quarantine'? Is there something special about 40 boxes?) I take back my suggestion. http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc File

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread m...@mikesolomon.org
On 29 nov. 2012, at 10:13, k-ohara5...@oco.net wrote: On 2012/11/29 08:28:31, mike7 wrote: On 29 nov. 2012, at 03:23, mailto:k-ohara5...@oco.net wrote: http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69 lily/box-quarantine.cc:69: int mid = ii0.mid_;

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-29 Thread benko . pal
On 2012/11/29 00:41:14, thomasmorley65 wrote: On 2012/11/27 20:03:06, benko.pal wrote: Did you had a look on the compiled output of the new reg-tests? I did now, it's OK with me. https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly File

still absent

2012-11-29 Thread Janek Warchoł
Dear friends, i hope that you're doing well. i have to remain off-list at least until Christmas :( all the best, Janek PS the conductor of my choir is in critical state after heart surgery complications. please, pray for him if you can. ___

How to do proper indentation?

2012-11-29 Thread Thomas Morley
Hi, reviewing https://codereview.appspot.com/6850073/ Pál admonished to do better indentation on lists at different levels. Trying to minimize my lack of knowledge on this topic I searched the CG about It. CG 10.5.3 Indentation mentions possibilities for emacs and vim, but I'm not familiar with

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-11-29 Thread thomasmorley65
On 2012/11/29 20:42:21, benko.pal wrote: On 2012/11/29 00:41:14, thomasmorley65 wrote: On 2012/11/27 20:03:06, benko.pal wrote: Did you had a look on the compiled output of the new reg-tests? I did now, Thanks for doing this. it's OK with me.

PATCH: Countdown to 20121203

2012-11-29 Thread Colin Campbell
For 22:00 MST Monday December 3rd Crash: Issue 2972 http://code.google.com/p/lilypond/issues/detail?id=2972: Adding StringNumber 0 in TabStaff crashes - R 6858077 https://codereview.appspot.com/6858077/ Defect: Issue 732 http://code.google.com/p/lilypond/issues/detail?id=732:

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-11-29 Thread k-ohara5a5a
'finger-chords.ly' is still in disagreement with its texidoc (therefore failing). You could adjust that regtest in light of the new defaults, of course. Better might be to make Fingering.add-stem-support = #only-if-beamed the new default. That is in better agreement with common practice.