Re: Doc: NR Moved Appendix C to CG (issue 6948070)

2012-12-26 Thread pkx166h
https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi File Documentation/contributor.texi (right): https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi#newcode70 Documentation/contributor.texi:70: On 2012/12/25 08:05:45, Trevor Daniels wrote:

Re: Doc: NR Moved Appendix C to CG (issue 6948070)

2012-12-26 Thread tdanielsmusic
LGTM, apart from a couple of nitpicks which I missed earlier. No need to post a new patch-set. https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (left):

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread tdanielsmusic
I'm happy with this with the change below. The formatting of this section (and the CG in general) has never been systematically reviewed, so there's no point in being strict about it here. The text is understandable even though it doesn't fit into the surrounding material in the best possible

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread dak
https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode155 Documentation/contributor/doc-work.itexi:155: The

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread James
hello, On 26 December 2012 11:00, d...@gnu.org wrote: https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right):

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread pkx166h
https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi#newcode149 Documentation/contributor/doc-work.itexi:149:

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread David Kastrup
James pkx1...@gmail.com writes: On 26 December 2012 11:00, d...@gnu.org wrote: Documentation/contributor/doc-work.itexi:155: The correct way to add [changes like this] to the documentation is to Why the [] ? This is a standard way to to clarify the antecedent. Another frequent use is

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread PhilEHolmes
https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi#newcode158 Documentation/contributor/doc-work.itexi:158:

Re: Doc: NR Moved Appendix C to CG (issue 6948070)

2012-12-26 Thread pkx166h
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (left): https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#oldcode1545

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread James
Hello, On 26 December 2012 12:52, philehol...@googlemail.com wrote: https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right):

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread thomasmorley65
On 2012/12/26 13:15:05, J_lowe wrote: Is there any case where a snippet would not have the docs tag? James Some statistic from the last LSR-update: The 2.12.3-LSR contained 645 snippets. 291 were tagged docs. There are many LSR-snippets showing nice code/features, but not all of them are

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread Phil Holmes
- Original Message - From: James pkx1...@gmail.com To: pkx1...@gmail.com; tdanielsmu...@googlemail.com; philehol...@googlemail.com; d...@gnu.org; lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Wednesday, December 26, 2012 1:15 PM Subject: Re: Doc: CG Clarifying about

Question re looking up settings in current \midi block.

2012-12-26 Thread Ian Hulin
First of all, a very Merry Christmas to you all. Unfortunately I've had to spend the holidays in hospital, but I'm now a much happier bunny now I have my notebook and have sorted out a mobile broadband link. I'm trying to prototype something so we can specify names and/or suffixes for midi files

Re: New Catalan PO file for 'lilypond' (version 2.15.95)

2012-12-26 Thread Jean-Charles Malahieude
Le 25/12/2012 23:30, Francisco Vila disait : El 25/12/2012 19:31, Federico Bruni escribió: Il 25/12/2012 19:23, David Kastrup ha scritto: What actually worries me is: All other PO files for your package are available in: http://translationproject.org/latest/lilypond/ And this shows:

New Catalan PO file for 'lilypond' (version 2.15.95)

2012-12-26 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Catalan team of translators. The file is available at: http://translationproject.org/latest/lilypond/ca.po (We can arrange things so

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread PhilEHolmes
LGTM https://codereview.appspot.com/7013043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Rewrite of Midi.c in Python (issue 7016046)

2012-12-26 Thread pkx166h
Reviewers: benrg, Message: Actually, I didn't rewrite it - as the comment above suggests - this was from Ben Rudiak-Gould. I am helping him at least get some discussion review of his code submission. This patch has not been patchy-tested and I have just included everything (i.e. also the .mid

Report unterminated ties hanging at end of input (issue 7019044)

2012-12-26 Thread pkx166h
Reviewers: zefram_fysh.org, Message: Issue 3062 - patch created by 'Zefram', but submitted by James Description: Report unterminated ties hanging at end of input Issue 3062 LP doesn't report unterminated ties that are left hanging at the end of input. Compare { a2~ r2 } (which warns) with {

canonicalise notional octave of tonic (issue 7019045)

2012-12-26 Thread pkx166h
Reviewers: zefram_fysh.org, Message: Patch submitted on behalf of zef...@fysh.org Description: canonicalise notional octave of tonic Nothing deliberately looks at the octave part of the pitch object storing the tonic of a key-change event; it's not really a meaningful concept. But comparison

Issue 3063 (issue 7017045)

2012-12-26 Thread pkx166h
Reviewers: zefram_fysh.org, Message: Submitted for zef...@fysh.org by James Description: Issue 3063 articulate grace notes with time stealing This change makes \articulate handle grace notes itself, rendering them to ordinary notes. There are a couple of tweakable parameters controlling the

Issue 3049: Parser outputs Lyric events for illegal note names (issue 7017044)

2012-12-26 Thread lemzwerg
LGTM. https://codereview.appspot.com/7017044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Dual license the files under mf/ using OFL. (issue 6970046)

2012-12-26 Thread pkx166h
Hanwen - this has now 'push' status - in case you are not following the tracker http://code.google.com/p/lilypond/issues/detail?id=3044 https://codereview.appspot.com/6970046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

New Catalan PO file for 'lilypond' (version 2.15.95)

2012-12-26 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Catalan team of translators. The file is available at: http://translationproject.org/latest/lilypond/ca.po (We can arrange things so