Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

2013-01-10 Thread dak
Reviewers: Keith, Message: On 2013/01/10 06:40:08, Keith wrote: Anything with a line break still causes a crash. I can't say exactly why, because I'm a bit confused which VerticalAxisGroup gets removed, the outer or the inner. The outer group commits suicide once it hears of an inner

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

2013-01-10 Thread m...@mikesolomon.org
On 10 janv. 2013, at 07:40, k-ohara5...@oco.net wrote: Anything with a line break still causes a crash. I can't say exactly why, because I'm a bit confused which VerticalAxisGroup gets removed, the outer or the inner. \new StaffGroup \with { \RemoveEmptyStaves } { b1 b1 b1} {

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

2013-01-10 Thread dak
On 2013/01/10 09:05:21, mike7 wrote: It's actually not as bad as you'd think. The Hara_kiri_engraver is just a thin wrapper around the Axi_group_engraver. Everything can be switched on and off via an extra context property haraKiri. I was able to drum up a sketch in 10 minutes.

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

2013-01-10 Thread m...@mikesolomon.org
On 10 janv. 2013, at 10:19, d...@gnu.org wrote: On 2013/01/10 09:05:21, mike7 wrote: It's actually not as bad as you'd think. The Hara_kiri_engraver is just a thin wrapper around the Axi_group_engraver. Everything can be switched on and off via an extra context property haraKiri. I

Re: Issue 2990: \RemoveEmptyStaves in StaffGroup context crashes (issue 7069044)

2013-01-10 Thread dak
On 2013/01/10 09:21:33, mike7 wrote: On 10 janv. 2013, at 10:19, mailto:d...@gnu.org wrote: On 2013/01/10 09:05:21, mike7 wrote: It's actually not as bad as you'd think. The Hara_kiri_engraver is just a thin wrapper around the Axi_group_engraver. Everything can be switched on and

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread tdanielsmusic
LGTM https://codereview.appspot.com/7058068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Eliminates the Hara_kiri_engraver. (issue 7061062)

2013-01-10 Thread mtsolo
Reviewers: , Message: This doesn't crash in the test case Keith proposed: \new StaffGroup \with { \RemoveEmptyStaves } { b1 b1 b1} { b1 b1 \break b1 } Description: Eliminates the Hara_kiri_engraver. Uses a haraKiri context property in the Axis_group_engraver to acheive the same

Re: Issue 3061 (issue 7033045)

2013-01-10 Thread pkx166h
author Zefram zef...@fysh.org Sun, 23 Dec 2012 09:52:48 + (09:52 +) committer James Lowe pkx1...@gmail.com Thu, 10 Jan 2013 21:41:33 + (21:41 +) commit51146a320837b3d2f673c8ce0493e33038babc18 https://codereview.appspot.com/7033045/

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread benko . pal
good for a start but I have some problems with the duration parameter: 1. { \tuplet 3/2 { c8 c c c c c } \tuplet 3/2 4 { c8 c c c c c } \tuplet 3/2 { c8 c c c c c } } I found it ugly that the first and last input line are engraved differently (i.e. duration has an effect outside of its

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread dak
On 2013/01/10 22:21:23, benko.pal wrote: good for a start but I have some problems with the duration parameter: 1. { \tuplet 3/2 { c8 c c c c c } \tuplet 3/2 4 { c8 c c c c c } \tuplet 3/2 { c8 c c c c c } } I found it ugly that the first and last input line are engraved

Enhancement: Factor out some duration processing (issue 7068062)

2013-01-10 Thread pkx166h
Reviewers: zefram_fysh.org, Message: adding zefram to the rietveld Description: Enhancement: Factor out some duration processing Issue 3081 New functions duration-log-factor, duration-dot-factor, duration-length, duration-visual, and duration-visual-length. All concerned with low-level

Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

2013-01-10 Thread tdanielsmusic
On 2013/01/10 22:40:03, dak wrote: No good idea how to work this one reasonably since tupletSpannerDuration is being set permanently. Maybe one should scrap tupletSpannerDuration altogether and just encode the duration straight into the event? That's where it ends up anyway. Huh, or

PATCH: Countdown to 20130113

2013-01-10 Thread Colin Campbell
For 20:00 MST Sunday January 13 Enhancement: Issue 3093 http://code.google.com/p/lilypond/issues/detail?id=3093: Patch: Declare absolute-volume-alist and instrument-equalizer-alist as session-local - R 7061055 https://codereview.appspot.com/7061055/ Cheers, Colin -- I've learned that you