Reviewers: lemzwerg, dak, mike7,
Message:
On 2013/03/11 10:18:59, dak wrote:
On 2013/03/10 00:32:43, mike7 wrote:
Why is this override needed for the regtest? The other
overrides
are
obvious user-accessible overrides for triggering the tested
functionality.
But should
On 2013/03/13 21:38:59, thomasmorley65 wrote:
Hi Mike,
sorry to be such an inch pincher.
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1061
Kieren MacMillan kieren_macmil...@sympatico.ca writes:
Hi David,
Why would you need absolute note entry?
Usually \relative has done its deed before you excise tags.
That's great to know — I much prefer relative note entry.
Well, \relative is a music function that leaves behind absolute
On 2013/03/17 07:10:23, MikeSol wrote:
On 2013/03/11 10:18:59, dak wrote:
There is no point in hiding the symptoms of a problem away. That
only
makes things even harder in future.
I don't think this is a problem blocking the current patch.
It is a problem making the current patch
On 17 mars 2013, at 10:19, d...@gnu.org wrote:
You don't fix your own work after it has been committed,
This is patently false. Please do not write e-mails like this to a public list
that can be read by future employers of mine that want to evaluate my integrity.
so why would
you fix
Hi,
On Sat, Mar 16, 2013 at 12:20 PM, David Kastrup d...@gnu.org wrote:
Do we
really need a particular associated voice instead of being able to do
this with general music column alignment?
I'll write a full answer later today, but for now i can say that i
don't know a way to do this.
Let's
FWIW, this was down to me removing the very out-of-date Czech news file from
the build. The simple cure for problems like this is to make doc clean and try
again. Failing that, delete the build directory and run make, make doc again.
--
Phil Holmes
- Original Message -
From:
I've not tested the snippets, but otherwise the patch LGTM. I'm
assuming the only files you actually created were the ones in
snippets/new/ - the rest came from makelsr and make doc?
https://codereview.appspot.com/7678047/
___
lilypond-devel mailing
On 17 mars 2013, at 11:05, Janek Warchoł janek.lilyp...@gmail.com wrote:
Hi,
On Sat, Mar 16, 2013 at 12:20 PM, David Kastrup d...@gnu.org wrote:
Do we
really need a particular associated voice instead of being able to do
this with general music column alignment?
I'll write a full answer
On 2013/03/17 10:35:40, PhilEHolmes wrote:
I've not tested the snippets, but otherwise the patch LGTM. I'm
assuming the
only files you actually created were the ones in snippets/new/ - the
rest came
from makelsr and make doc?
Yes, exactly.
https://codereview.appspot.com/7678047/
On Mar 17, 2013 11:10 AM, m...@mikesolomon.org m...@mikesolomon.org
wrote:
In the stop_translation_timestep method of the lyric engraver, lyrics are
given note heads as parents. Could you send a minimal where the lyrics are
unassociated from note-heads?
\lyrics { do re mi }
If there's no
On 17 mars 2013, at 12:29, Neil Puttock n.putt...@gmail.com wrote:
On Mar 17, 2013 11:10 AM, m...@mikesolomon.org m...@mikesolomon.org wrote:
In the stop_translation_timestep method of the lyric engraver, lyrics are
given note heads as parents. Could you send a minimal where the lyrics
m...@mikesolomon.org m...@mikesolomon.org writes:
On 17 mars 2013, at 12:29, Neil Puttock n.putt...@gmail.com wrote:
On Mar 17, 2013 11:10 AM, m...@mikesolomon.org
m...@mikesolomon.org wrote:
In the stop_translation_timestep method of the lyric engraver,
lyrics are
On 2013/03/17 07:27:37, MikeSol wrote:
On 2013/03/13 21:38:59, thomasmorley65 wrote:
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1061
On 17 mars 2013, at 13:36, thomasmorle...@googlemail.com wrote:
On 2013/03/17 07:27:37, MikeSol wrote:
On 2013/03/13 21:38:59, thomasmorley65 wrote:
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):
Hello,
*Countdown – March 20th 2013 – 19:00 GMT* *
* *
* *
* *
*
3238http://code.google.com/p/lilypond/issues/detail?id=3238q=label%3APatch-countdownsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Summary%20Modified
Build Julien Rioux Push Patch: Fixup default prefix
m...@mikesolomon.org wrote Sunday, March 17, 2013 11:32 AM
On 17 mars 2013, at 12:29, Neil Puttock n.putt...@gmail.com wrote:
On Mar 17, 2013 11:10 AM, m...@mikesolomon.org m...@mikesolomon.org
wrote:
In the stop_translation_timestep method of the lyric engraver, lyrics are
given note
Trevor Daniels t.dani...@treda.co.uk writes:
m...@mikesolomon.org wrote Sunday, March 17, 2013 11:32 AM
On 17 mars 2013, at 12:29, Neil Puttock n.putt...@gmail.com wrote:
On Mar 17, 2013 11:10 AM, m...@mikesolomon.org
m...@mikesolomon.org wrote:
In the stop_translation_timestep method
LGTM
https://codereview.appspot.com/7518047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi,
maybe for other developers there is no problem, but for me it would be
clearer if the commit message said
configure: check for mfplain.mp (issue 3233).
thanks,
Janek
https://codereview.appspot.com/7789047/
___
lilypond-devel mailing list
LGTM
https://codereview.appspot.com/7498045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
commit message says:
Prohibit non-postevents from music functions to be used
as post-event
Do i understand correctly that this sentence is equivalent to Prohibit
non-postevents returned by music functions to be used as post-events?
If so, i'd prefer that second wording; the original looks less
On 17 mars 2013, at 17:22, m...@hohlart.de wrote:
Just one nitpick.
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm#newcode251
scm/stencil.scm:251: Makes a list of angle/radius
This patch needs a review from someone more knowledgeable in
docs/snippets than me.
https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly
File
On 2013/03/17 14:37:52, thomasmorley65 wrote:
This is doable, but I'd wait to see from someone who knows how these
things
work
if this is actually how they are printed.
I want to say that they are always printed with the line going up
irrespective
of the side of the staff, but I could be
Just one nitpick.
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm#newcode251
scm/stencil.scm:251: Makes a list of angle/radius paris at intervals of
PI/2 for
s/paris/pairs/
LGTM
https://codereview.appspot.com/7497046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Am 13.03.2013 17:05, schrieb Janek Warchoł:
Hi Marcall,
On Wed, Mar 13, 2013 at 10:09 AM, Marc Hohl m...@hohlart.de wrote:
make
sure you sit comfortable and have a nice cup of coffee, tea or whatever
around...
these words actually reminded me that i had a tea waiting, and thanks
to you it
LGTM
https://codereview.appspot.com/7578046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I like the description. It's very clear.
LGTM
thanks!
Janek
https://codereview.appspot.com/7568048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/7742044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 03/17/2013 05:28 PM, m...@mikesolomon.org wrote:
My suggestion was flairpin, which is infinitely cheesier and thus way cooler.
I know, but ... at the end of the day, less clear in meaning than either
ferneyhough-hairpin or flared-hairpin. Sad but IMO true. :-P
On a related issue: one thing that's probably clear looking at
Ferneyhough scores is the way in which the vertical placement of hairpin
endpoints is strongly coupled with the vertical placement of dynamic
marks.
I don't think it's really appropriate to bundle all of this together
into one
LGTM
https://codereview.appspot.com/7678047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 17 mars 2013, at 17:25, joseph.wakel...@gmail.com wrote:
Final remark: while it's nice to see Ferneyhough getting namechecked
might it be worth naming this alteration as flared-hairpin rather than
ferneyhough-hairpin?
My suggestion was flairpin, which is infinitely cheesier and thus
Am 17.03.2013 17:27, schrieb m...@mikesolomon.org:
On 17 mars 2013, at 17:22, m...@hohlart.de wrote:
Just one nitpick.
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm#newcode251
On 2013/03/17 16:24:16, janek wrote:
This patch needs a review from someone more knowledgeable in
docs/snippets than
me.
+1
All I did was:
I copied the files from /Documentation/snippets into
/Documentation/snippets/new.
Removed the '-signs, deleted the comments above the old
On 17 mars 2013, at 17:46, joseph.wakel...@gmail.com wrote:
On a related issue: one thing that's probably clear looking at
Ferneyhough scores is the way in which the vertical placement of hairpin
endpoints is strongly coupled with the vertical placement of dynamic
marks.
I don't think
On 2013/03/17 12:42:02, mike7 wrote:
You'd have to have a wrapper function with a call to ly:scale-stencil
with a -1
to the Y axis based on the direction of the grob.
Sure.
Or in
(define (my-c-p-s ...
as it is done for `decresc?´
This is doable, but I'd wait to see from someone who knows
On 2013/03/17 16:25:55, Joseph Rushton Wakeling wrote:
On 2013/03/17 14:37:52, thomasmorley65 wrote:
I want to say that they are always printed with the line going up
irrespective
of the side of the staff, but I could be wrong.
There are Ferneyhough scores with dynamics above the staff
Hi hackers,
(replies are not in chronological order)
On Sun, Mar 17, 2013 at 11:21 AM, m...@mikesolomon.org
m...@mikesolomon.org wrote:
I saw in one of your patch sets that you use the word parent
to name a function that takes grobs me and him. If there is
no longer a parental relationship
ok, now i see that i've unnecessarily mixed two different things:
rewriting self-alignment-interface (this patch) and changing behaviour
of unassociated LyricTexts
(http://lists.gnu.org/archive/html/lilypond-devel/2013-03/msg00231.html).
These changes are orthogonal, and i'll keep them separated
LGTM
https://codereview.appspot.com/7583044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
May I ask for a reply? It's rather unusual on this list that
something stays uncommented :-)
Werner
---BeginMessage---
[git 1b5411df from today]
This snippet
\relative c'' {
c1
\override Score.RehearsalMark.break-visibility = #end-of-line-visible
\override
On 15 March 2013 09:12, Werner LEMBERG w...@gnu.org wrote:
[git 1b5411df from today]
This snippet
\relative c'' {
c1
\override Score.RehearsalMark.break-visibility = #end-of-line-visible
\override Score.RehearsalMark.extra-offset = #'(0 . -.25)
\mark \markup {
2013/3/17 Werner LEMBERG w...@gnu.org:
May I ask for a reply? It's rather unusual on this list that
something stays uncommented :-)
Werner
Hi Werner,
I'm not sure what changed.
Though, testing the snippet below with 2.16.2 and 2.17.12 (it will
work for both) you'll notice a collision
Reviewers: dak,
Message:
Please review.
You'll find a sample test file in tracker issue:
http://code.google.com/p/lilypond/issues/detail?id=3254
Description:
don't abort aligning when grob's parent is a PaperColumn
This results in all lyrics being aligned according to self-alignment-X,
ok, here's a standalone patch that improves handling of unassociated lyrics:
https://codereview.appspot.com/7564044/
In the attachment you'll find a test file with output produced by proposed code.
foo.ly
Description: Binary data
foo.pdf
Description: Adobe PDF document
On 2013/03/16 09:09:29, dak wrote:
So many pitches are wrong in this patch that I think we should revert
it and
have it redone carefully.
I do not have push access, so I cannot do much at this point. Can you
revert it then?
Possibly using some automatism (like Frescobaldi's
On 2013/03/18 00:00:13, aleksandr.andreev wrote:
Sorry, I should have checked the output more carefully. (Then again,
Pál said
above that the changes didn't matter).
Ancient music usually tries very hard to avoid ledger lines which is one
of the reasons for its multitude of clefs. So being
I'm not sure what changed. [...]
-7.2
-0.25))
Exactly this is the bug, I believe. For some unknown reasons,
\with-dimensions #'(0 . 0) #'(0 . 0)
no longer produces a markup which has no extension. I'll submit a bug
report.
Werner
Is this snippet part of the documentation?
I can't remember; I think I got it from the LSR.
If you want to achieve the positioning of two opposite fermata signs
over a bar line (or more generally print two simultaneous
RehearsalMark possibly with different settings), I'd suggest to use
52 matches
Mail list logo
