Hello,
*Countdown – April 5th 2013 – 19:00 GMT* *
* *
* *
* *
*
3269http://code.google.com/p/lilypond/issues/detail?id=3269q=label%3APatch-reviewsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified
Ugly
Mike Solomon Push Fingering not aligning
Hi,
In scm/define-grobs.scm we can see that the following grobs:
MultiMeasureRestNumber
MultiMeasureRestText
PercentRepeatCounter
DoublePercentRepeatCounter
have their X-offsets initialized to a sum of return values from two
functions: x-aligned-on-self and x-centered-on-y-parent. Now, the
I'm not sure what the previous ambiguities were, but since there's a big
comment above the code i guess that this should be reasonably easy to
understand for people knowledgeable in parser stuff. So, LGTM.
https://codereview.appspot.com/8103043/
___
As usual with parser patches, i'm not the right person to review them...
i think this one is ok.
Thanks,
Janek
https://codereview.appspot.com/8102043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Is this patch still valid? I don't see any ' signs being removed, only
some semi-random side-effects here and there.
best,
Janek
https://codereview.appspot.com/7834043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: janek,
Message:
On 2013/04/02 21:23:16, janek wrote:
I'm not sure what the previous ambiguities were
A music expression could start with BACKUP (an artificially inserted
token never present in the source code itself) due to these rules. I
needed BACKUP in a different context and
Thanks fot the explanation! Could you paste it into commit message?
Janek
On Tue, Apr 2, 2013 at 11:40 PM, d...@gnu.org wrote:
Reviewers: janek,
Message:
On 2013/04/02 21:23:16, janek wrote:
I'm not sure what the previous ambiguities were
A music expression could start with BACKUP (an
On 2013/03/30 07:30:36, Keith wrote:
Maybe should reverse this change, as well,
\on-the-fly #book-last-page \fromproperty #'header:tagline
so that the tag-line is printed only once at the end of a book.
1) for the sake of multi-bookpart entries on http://mutopiaproject.org
with its long
On 2013/04/02 21:51:20, janek wrote:
Thanks fot the explanation! Could you paste it into commit message?
Have you taken a look at the actual diff? It is just factoring out one
subexpressions of revert into revert_arg_backup, making for about three
trivial changes. Commit messages are cheap,
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix a
broken design than to patch it with red tape. However, if we only
accepted code changes that were implementing the Ultimate Solution, i'm
afraid that the development process would grind to
hmm. I think it's ok.
https://codereview.appspot.com/8258043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/04/02 21:43:55, janek wrote:
simplify things a bit.
Oops, sorry, wrong description.
This patch is just an intermediate state; it should work (my computer
tells there are no unwanted regtest changes), but there will be more
changes, for example centered_on_foo will get deleted. Before
On 2013/04/02 22:22:38, dak wrote:
On 2013/04/02 21:51:20, janek wrote:
Thanks fot the explanation!
Could you paste it into commit message?
Have you taken a look at the actual diff?
Of course. I've also read the big comment above, but i didn't read the
remaining parser code and i'm
On 2013/04/02 22:34:53, janek wrote:
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix
a broken
design than to patch it with red tape.
It isn't patched. minimum-length is used in multiple
contexts/interfaces, and Mike's patch muddies
Hi,
On Tue, Apr 2, 2013 at 10:07 PM, James pkx1...@gmail.com wrote:
Hello
3134http://code.google.com/p/lilypond/issues/detail?id=3134q=label%3APatch-reviewsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified
Enhancement Mike Solomon Countdown Patch:
The archives show a few half-hearted attempts to get this working,
but no actual patches other than Mike's lily dances patch from
Dec 2010 which wasn't merged.
I've got a patch which adds point-and-click,
https://codereview.appspot.com/8273045
but it's sub-optimal at the moment because you need
On 2013/04/02 21:35:23, janek wrote:
Is this patch still valid? I don't see any ' signs being removed,
Meanwhile I removed the '-signs from the relevant snippets in LSR as
well. I wasn't aware that a new release would contain them.
So it is indeed invalid.
git grep #'# only returns some
On 3 avr. 2013, at 01:57, d...@gnu.org wrote:
On 2013/04/02 22:34:53, janek wrote:
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix
a broken
design than to patch it with red tape.
It isn't patched. minimum-length is used in
18 matches
Mail list logo
