Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread k-ohara5a5a
On 2015/05/10 22:50:36, dak wrote: The \revert version generated too many clashing notecolumns warnings, which is now need a \shiftXxx, and I thought it a bit safer to keep a warning. What's safer here? For old code where people did not bother heeding the warning anyway (possibly

Re: Part_combine_iterator: simplify context substitution (issue 238070043 by nine.fierce.ball...@gmail.com)

2015-05-10 Thread k-ohara5a5a
This and the MMrest patch look sensible, but it is a good idea to test them on some orchestral music from mutopiaproject. I tried them on a piece I have and saw no output differences. https://codereview.appspot.com/238070043/diff/1/lily/part-combine-iterator.cc File

Re: Decrease space between vertical beams by length-fraction. (issue 214250043 by hanw...@gmail.com)

2015-05-10 Thread hanwenn
On 2015/05/10 22:58:54, hanwenn wrote: also handle length-fraction 1 PTAL * I had a further look at the short stems, and should have fixed more cases by disabling forbidden beam quanting in case of grace notes. * magnifyMusic: can you show examples of what music at 50% scale should look

Issue 4385: Part_combine_iterator: remove residue related to marks (issue 231560043 by nine.fierce.ball...@gmail.com)

2015-05-10 Thread nine . fierce . ballads
Reviewers: , Description: This could have been removed when the generation of mark events was moved from C++ to Scheme in aae8f9ee8f62e8a57f4f60a60e639a040571f37b, but it went unnoticed at that time. Please review this at https://codereview.appspot.com/231560043/ Affected files (+0, -23

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread dak
On 2015/05/10 21:00:26, Keith wrote: On Sun, 10 May 2015 11:02:21 -0700, mailto:d...@gnu.org wrote: It's not clear why you are now mixing in variants of conversion rules for issue 4372. I noticed that my rule made the same \b mistake as yours, and they are right next to each other,

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 11:02:21 -0700, d...@gnu.org wrote: It's not clear why you are now mixing in variants of conversion rules for issue 4372. I noticed that my rule made the same \b mistake as yours, and they are right next to each other, and I thought it was an easy fix, so I tried fixing

Issue 4386: Part_combine_iterator: move mmrest handling outside the part-routing state machine (issue 236130043 by nine.fierce.ball...@gmail.com)

2015-05-10 Thread nine . fierce . ballads
Reviewers: , https://codereview.appspot.com/236130043/diff/1/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (left): https://codereview.appspot.com/236130043/diff/1/lily/part-combine-iterator.cc#oldcode236 lily/part-combine-iterator.cc:236: kill_mmrest (CONTEXT_SHARED); Here

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 00:25:18 -0700, d...@gnu.org wrote: On 2015/05/09 23:58:22, Keith wrote: It is a bit of an inconvenience that \relative skips over \transpose, and I suspect \relative has this feature so that we do not get rising octaves in \relative c \transpose c c' {c c c c} We

Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread dak
https://codereview.appspot.com/190500043/diff/1/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/190500043/diff/1/python/convertrules.py#newcode3731 python/convertrules.py:3731: str = re.sub (r'\\shiftOff\b', r'\\undo\\shiftOn', str) I'm currently

Re: PATCHES: Countdown for May 12th 2015

2015-05-10 Thread James Lowe
On 10/05/15 08:33, David Kastrup wrote: James Lowe: Doc: NR section 3.5.x MIDI file creation tidy up http://code.google.com/p/lilypond/issues/detail?id=2877 There are still 5 patches at Patch-push right now, 4 of them being documentation patches. In order not to require the others to rebase,

Re: PATCHES: Countdown for May 12th 2015

2015-05-10 Thread David Kastrup
James Lowe p...@gnu.org writes: Hello, Here is the current patch countdown list. The next countdown will be on May 12th. You can always view the most current countdown list here:

Re: Improving the Contributors Guide and LilyDev

2015-05-10 Thread Federico Bruni
2015-05-05 3:10 GMT+02:00 Paul Morris p...@paulwmorris.com: Automatic formatting/indenting of C++ files currently doesn't work out of the box” and there’s no easy way to manually get it to work. Artistic Style 2.02 is required for LilyPond’s fixcc.py but LilyDev3 has 2.01, which is the

Re: PATCHES: Countdown for May 12th 2015

2015-05-10 Thread James Lowe
On 10/05/15 08:33, David Kastrup wrote: There are still 5 patches at Patch-push right now, 4 of them being documentation patches. In order not to require the others to rebase, I'll keep off today from applying the patch for issue 3229 (or rather, running the script generating an up-to-date

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

2015-05-10 Thread dak
On 2015/05/09 23:58:22, Keith wrote: I had seen this selective application as a feature specific to \relative. Most music functions apply to all the music in their argument, but \relative skips over any \relative or \transpose. It is a bit of an inconvenience that \relative skips over

Re: Improving the Contributors Guide and LilyDev

2015-05-10 Thread Federico Bruni
2015-05-04 20:41 GMT+02:00 Carl Sorensen c_soren...@byu.edu: On 5/4/15 11:19 AM, Federico Bruni fedel...@gmail.com wrote: So I'd rather put a script to download the repository when the user logs in for the first time. What do you think? Isn't that the way it works right now? If not, it

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread dak
It's not clear why you are now mixing in variants of conversion rules for issue 4372. There already is a more thorough conversion rule for issue 4372 in review and I don't see any comment of yours on it. While there may have been some overlap in effort, it does not make sense to mix that issue

New Contributor

2015-05-10 Thread Simon Nagl
Hello lilypond team, as a student of Information Technology I want to help making lilypond even better. I have some experience with C++ and Make, the other languages of the project are a new experience for me. But I have no fear to learn some new. Furthermore using git and unix tools like

Re: New Contributor

2015-05-10 Thread David Kastrup
Simon Nagl simonn...@aim.com writes: Hello lilypond team, as a student of Information Technology I want to help making lilypond even better. I have some experience with C++ and Make, the other languages of the project are a new experience for me. But I have no fear to learn some new.

Re: PATCHES: Countdown for May 12th 2015

2015-05-10 Thread David Kastrup
James Lowe p...@gnu.org writes: On 10/05/15 08:33, David Kastrup wrote: There are still 5 patches at Patch-push right now, 4 of them being documentation patches. In order not to require the others to rebase, I'll keep off today from applying the patch for issue 3229 (or rather, running the

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread dak
On 2015/05/10 15:44:17, Keith wrote: On Sun, 10 May 2015 05:06:24 -0700, mailto:d...@gnu.org wrote: In addition, the following commit commit a1d73a332fc4d1cb99bace19a5ec2c35262429e7 Author: Keith OHara mailto:k-ohara5...@oco.net Date: Tue Dec 30 23:30:27 2014 -0800 Update by hand

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 05:06:24 -0700, d...@gnu.org wrote: In addition, the following commit commit a1d73a332fc4d1cb99bace19a5ec2c35262429e7 Author: Keith OHara k-ohara5...@oco.net Date: Tue Dec 30 23:30:27 2014 -0800 Update by hand instead of convert-ly The documentation already

Issue 4372: convert-ly misses some bflat - b-flat (issue 233300043 by d...@gnu.org)

2015-05-10 Thread lemzwerg
LGTM. https://codereview.appspot.com/233300043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel