Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2018-11-10 Thread paulwmorris
Hi Charles, Today I built and ran 'make check' with your patch applied to current master. I was able to get it to pass 'make check' by making the following two changes. 1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`. 2. In that same file, line 100, remove the parens to

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-10 Thread dak
I wonder whether it might be reasonable to just have all markup commands with a last argument of markup? produce their last (recursively treated) argument as default, and possibly all markup list commands with a last argument of markup-list? similarly produce their last argument? That leaves

Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-10 Thread thomasmorley65
Reviewers: , Message: Please review. There are some TODOs in the code where I'd appreciate some feedback. Thanks- Description: Improve markup->string 'all-relevant-markup-commands' is now a toplevel-defined procedure. So it is not longer a part of the rekursive 'markup->string'. It needs to be

bindings in lily-module

2018-11-10 Thread Thomas Morley
Hi, while working on a patch to improve markup->string from markup.scm I noticed, that (pretty-print (list? (ly:module->alist (resolve-module '(lily) inserted at toplevel in markup.scm returns several times: programming error: unbound variable in module continuing, cross fingers While