Re: Naming question for get_property, set_property

On Tue, Feb 11, 2020 at 10:17 PM David Kastrup wrote: > > the reason being that it is better if the source code looks like plain > C++, > > even though they might actually be macros that do advanced magic. Having > > normal looking source code helps editors and tooling (astyle, > clang-format) >

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676 lily/parser.yy:3676: | pitch exclamations questions octave_check duration stray_quotes optional_rest post_events

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

Reviewers: lemzwerg, Carl, Message: On 2020/02/11 22:37:39, Carl wrote: > On 2020/02/11 21:46:52, lemzwerg wrote: > > Good idea! From inspection only, LGTM. > > Sounds like a great idea! > > Carl Well, I sort of got a feature request.

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

On 2020/02/11 21:46:52, lemzwerg wrote: > Good idea! From inspection only, LGTM. Sounds like a great idea! Carl https://codereview.appspot.com/557410043/

Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

Good idea! From inspection only, LGTM. https://codereview.appspot.com/557410043/

Re: Naming question for get_property, set_property

Han-Wen Nienhuys writes: > On Mon, Feb 10, 2020 at 11:48 PM David Kastrup wrote: > >> >> So for longterm efficiency reasons I am planning to reimplement the >> get_property/set_property macros and underlying data structures that map >> to get_property_internal/set_property_internal. They are

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

fixed nits. https://codereview.appspot.com/557380044/

Re: Naming question for get_property, set_property

On Mon, Feb 10, 2020 at 11:48 PM David Kastrup wrote: > > So for longterm efficiency reasons I am planning to reimplement the > get_property/set_property macros and underlying data structures that map > to get_property_internal/set_property_internal. They are currently used > across a number of

Re: Fix and align musicxml and input language "deutsch" (issue 547610043 by d...@gnu.org)

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#newcode324 python/musicexp.py:324: return str On 2020/02/11 20:39:14, Be-3 wrote: > Proposal: > keep 1st

Re: Fix and align musicxml and input language "deutsch" (issue 547610043 by d...@gnu.org)

Proposed solution for English (I know that this issue is about German only, but as English has been touched, too, by removing a pointless replace statement). https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py File python/musicexp.py (right):

Re: Fix and align musicxml and input language "deutsch" (issue 547610043 by d...@gnu.org)

We still have issues with English THREE-Q-* pitches (never worked, though). Please see my comment in musicexp.py Torsten https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py File python/musicexp.py (right):

Re: [RFC] switch to GitLab / gitlab.com

Am Dienstag, den 11.02.2020, 14:37 +0100 schrieb Jonas Hahnfeld: > Am Dienstag, den 11.02.2020, 14:27 +0100 schrieb David Kastrup: > > Jonas Hahnfeld < > > hah...@hahnjo.de > > > > > writes: > > > Am Dienstag, den 11.02.2020, 13:48 +0100 schrieb Federico Bruni: > > > > Il giorno mar 11 feb 2020

Re: What kind of forum are we lacking?

Karlin High writes: > On 2/11/2020 10:03 AM, David Kastrup wrote: >> There >> is nothing wrong per se with the user list, but it's not indexed in a >> manner where many of the high quality answers would be accumulated into >> wisdom, and it is comparatively rare that something gets condensed

Re: What kind of forum are we lacking?

On 2/11/2020 10:03 AM, David Kastrup wrote: There is nothing wrong per se with the user list, but it's not indexed in a manner where many of the high quality answers would be accumulated into wisdom, and it is comparatively rare that something gets condensed into the somewhat hard to find LSR,

What kind of forum are we lacking?

I just reencountered the following StackExchange exchange when looking for something else: It has almost sort of a tutorial answer by some one-time poster (not all that rare

Re: [RFC] switch to GitLab / gitlab.com

Jonas Hahnfeld writes: > Am Dienstag, den 11.02.2020, 14:27 +0100 schrieb David Kastrup: >> 7.6 ‘tsort’: Topological sort >> = >> >> [...] >> >> Now of course the non-linear manner of being able to update issues and >> the desire to have cross-reference means that

Re: [RFC] switch to GitLab / gitlab.com

Jonas Hahnfeld writes: > Am Dienstag, den 11.02.2020, 14:16 +0100 schrieb David Kastrup: >> I am not sure of when and how and whether at all it might make sense >> suggesting to GitLab that we would be a good showcase project, being >> ancient and with significant history of different trackers

Re: Naming question for get_property, set_property

Dan Eble writes: > On Feb 10, 2020, at 20:48, David Kastrup wrote: >> >> Templating on a string constant is, unfortunately, not a thing at least >> in C++11 (don't know whether they managed since then). Or one could go >> that route rather than GCC-specific in-expression use of a static >>

Re: [RFC] switch to GitLab / gitlab.com

Am Dienstag, den 11.02.2020, 14:27 +0100 schrieb David Kastrup: > Jonas Hahnfeld < > hah...@hahnjo.de > > writes: > > > Am Dienstag, den 11.02.2020, 13:48 +0100 schrieb Federico Bruni: > > > Il giorno mar 11 feb 2020 alle 13:18, Jonas Hahnfeld < > > > hah...@hahnjo.de > > > > > > > > > ha

Re: [RFC] switch to GitLab / gitlab.com

Am Dienstag, den 11.02.2020, 14:16 +0100 schrieb David Kastrup: > Jonas Hahnfeld < > hah...@hahnjo.de > > writes: > > > Am Montag, den 10.02.2020, 09:20 +0100 schrieb Jonas Hahnfeld: > > > Am Sonntag, den 09.02.2020, 23:34 +0100 schrieb Federico Bruni: > > > > Il giorno dom 9 feb 2020 alle 22:50,

Re: Naming question for get_property, set_property

On Feb 10, 2020, at 20:48, David Kastrup wrote: > > Templating on a string constant is, unfortunately, not a thing at least > in C++11 (don't know whether they managed since then). Or one could go > that route rather than GCC-specific in-expression use of a static > initializer. Well,

Re: [RFC] switch to GitLab / gitlab.com

Jonas Hahnfeld writes: > Am Dienstag, den 11.02.2020, 13:48 +0100 schrieb Federico Bruni: >> Il giorno mar 11 feb 2020 alle 13:18, Jonas Hahnfeld < >> hah...@hahnjo.de >> > >> ha scritto: >> > > > Another shortcoming is that links to other issues are broken >> > > > (transformed in links to

Re: [RFC] switch to GitLab / gitlab.com

Am Dienstag, den 11.02.2020, 13:48 +0100 schrieb Federico Bruni: > Il giorno mar 11 feb 2020 alle 13:18, Jonas Hahnfeld < > hah...@hahnjo.de > > > ha scritto: > > > > Another shortcoming is that links to other issues are broken > > > > (transformed in links to non-existing anchors in current

Re: [RFC] switch to GitLab / gitlab.com

Jonas Hahnfeld writes: > Am Montag, den 10.02.2020, 09:20 +0100 schrieb Jonas Hahnfeld: >> Am Sonntag, den 09.02.2020, 23:34 +0100 schrieb Federico Bruni: >> > Il giorno dom 9 feb 2020 alle 22:50, Jonas Hahnfeld < >> > hah...@hahnjo.de >> > >> > >> > ha scritto: >> > > Thanks for sharing! I

Re: [RFC] switch to GitLab / gitlab.com

Il giorno mar 11 feb 2020 alle 13:18, Jonas Hahnfeld ha scritto: > Another shortcoming is that links to other issues are broken > (transformed in links to non-existing anchors in current issue). I think that is because some issues have not (yet) been migrated. I hope these links start to

Re: [RFC] switch to GitLab / gitlab.com

Am Montag, den 10.02.2020, 09:20 +0100 schrieb Jonas Hahnfeld: > Am Sonntag, den 09.02.2020, 23:34 +0100 schrieb Federico Bruni: > > Il giorno dom 9 feb 2020 alle 22:50, Jonas Hahnfeld < > > hah...@hahnjo.de > > > > > > ha scritto: > > > Thanks for sharing! I put together a simplistic script to

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

On 2020/02/10 21:28:53, hahnjo wrote: > Thanks for providing a test. Not able to run it right now, maybe tomorrow. Looks good to me (modulo the nits), see https://sourceforge.net/p/testlilyissues/issues/5747/ for how the output looks like. https://codereview.appspot.com/557380044/

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

On 2020/02/11 11:22:40, lilypond_ptoye.com wrote: > Monday, February 10, 2020, 10:00:03 PM, you wrote: > > > On 2020/02/09 16:15:53, thomasmorley651 wrote: > >> On 2020/02/09 15:32:14, http://lilypond_ptoye.com wrote: > >> > >> > Surely "standard scale pitch or previously altered pitch". In D >

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

On 2020/02/11 11:04:59, Jean-Charles wrote: > Have a look at Documentation/HOWTO.index > > https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely > File Documentation/notation/input.itely (right): > >

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

Monday, February 10, 2020, 10:00:03 PM, you wrote: > On 2020/02/09 16:15:53, thomasmorley651 wrote: >> On 2020/02/09 15:32:14, http://lilypond_ptoye.com wrote: >> >> > Surely "standard scale pitch or previously altered pitch". In D > major: "cis c >> > cis" the first note is an alteration but

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

Have a look at Documentation/HOWTO.index https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely#newcode880

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

Are you a French forensics? (DNA is adn for us) https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right):

Re: Integration of Guilev2 branches into master

I /think/ it is Unicode in NTFS now, but UCS/UTF-16 and not UTF-8: https://stackoverflow.com/questions/2050973/what-encoding-are-filenames-in-ntfs-stored-as https://en.wikipedia.org/wiki/Universal_Coded_Character_Set#Relationship_with_Unicode Joram

Re: Naming question for get_property, set_property

FWIW, python has getattr and setattr which would perhaps suggest get_prop(grob, "property") and set_prop(grob, "property", VALUE) I am not a fan of "arbitrary abbreviations" and get_property and set_property are only 4 characters longer. So maybe I would choose the latter (modulo your naming

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

Monday, February 10, 2020, 9:40:53 PM, you wrote: > On 2020/02/09 14:16:51, Carl wrote: >> I'm a native US speaker. The following is my opinion. >> >> Alteration is a change in pitch from the base pitch. Base pitch is C, >> alteration is sharp, actual pitch is C#. >> >> Accidental is a

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

note: this goes on top of DAK's recent patch for the .SCM file. https://codereview.appspot.com/557330043/

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

On Mon, Feb 10, 2020 at 11:21 PM David Kastrup wrote: > > Or maybe the file offset got advanced because Guile peeked ahead in > order to check whether there is an UTF-8 signature? I forget what they > are called, basically zero-space characters. Byte order mark? I am not > saying that it is