https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly
File Documentation/snippets/utf-8.ly (right):
https://codereview.appspot.com/571640044/diff/571650043/Documentation/snippets/utf-8.ly#newcode1
Documentation/snippets/utf-8.ly:1: % DO NOT EDIT this file
LGTM – you definitely know how to speak that language :-)
https://codereview.appspot.com/571640044/
LGTM
https://codereview.appspot.com/571640043/
FWIW, I remember when "français" was introduced. I could not find it in
the archives. But I think the consensus was that a correct spelling is
better than sticking to ascii and that is why español was added because
it was obvious.
So without finding the reference, I think you logically complete
Pls see my comment about a patch introducing full quarter tone support
for all the languages - including a complete and consistent MusicXML
import language support.
I've asked on dev list about introducing català and português as
"official" consistent proper language names.
It's already included
On 2020/02/15 16:58:45, hanwenn wrote:
>
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
> File python/musicexp.py (right):
>
>
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364
> python/musicexp.py:364: function_dict = {
> I meant
Hello all,
I've prepared a patch introducing full quarter note support for all
currently existing LilyPond languages.
MusicXML import has also been adapted accordingly and was successfully
tested with all of the notes in all in all of the languages.
The Documentation/notation/*/pitches.itely
On 2020/02/13 12:05:51, dak wrote:
> Issue title is wrong. Function is ly_scm_hash, not ly_hash_scm. Also
its
> prototype in lily/include/lily-guile.hh should get removed.
Done.
https://codereview.appspot.com/569340043/
https://codereview.appspot.com/579310043/diff/557420043/lily/source-file.cc
File lily/source-file.cc (right):
https://codereview.appspot.com/579310043/diff/557420043/lily/source-file.cc#newcode55
lily/source-file.cc:55: return contents of FILENAME. *Not 0-terminated!*
On 2020/02/15 13:53:17,
https://codereview.appspot.com/579310043/diff/557420043/lily/engraver.cc
File lily/engraver.cc (right):
https://codereview.appspot.com/579310043/diff/557420043/lily/engraver.cc#newcode121
lily/engraver.cc:121: if (!scm_is_pair (props)) {
On 2020/02/15 13:53:16, Dan Eble wrote:
> misplaced
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364
python/musicexp.py:364: function_dict = {
I meant something like
# this map should be synchronized
LGTM. Changing to std::string is a definite improvement. Thanks.
https://codereview.appspot.com/579310043/diff/557420043/lily/engraver.cc
File lily/engraver.cc (right):
https://codereview.appspot.com/579310043/diff/557420043/lily/engraver.cc#newcode121
lily/engraver.cc:121: if (!scm_is_pair
LGTM
https://codereview.appspot.com/571610043/
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:29:01, dak wrote:
> On
Reviewers: hanwenn,
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:19:54,
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
português
16 matches
Mail list logo
