Re: testing out Docker CI scripts?

> The download size for the notation manual comes out at 35MB which is > about double than what we had for 2.16. I actually find that > somewhat irritating. I'd have to check the old conversations about > extractpdfmark and see whether this is indeed where our change of > text fonts would have

Re: run-and-check: close stdin (issue 545620043 by hanw...@gmail.com)

> The proper fix here of course is not to close stdin > but rather to run pdflatex with > > -interaction batchmode > > (where it prints nothing on output during the run, > so you need to consult the log file in case of > problems) or with > > -interaction nonstopmode > > where it never stops

texinfo-rules: generate log files in $(outdir)/ (issue 557480043 by hanw...@gmail.com)

LGTM. Can you give an example of old vs. new location of the log files? https://codereview.appspot.com/557480043/

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sat, Feb 22, 2020 at 11:43 PM David Kastrup wrote: >> >> Assuming that all translations are kept at exactly the same level and >> >> the example code is not at all adapted to the language in question in >> >> lyrics and code comments. >> >> >> >> And assuming that

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

On 2020/02/22 23:56:23, hanwenn wrote: > On Sun, Feb 23, 2020 at 12:29 AM wrote: > > > > On 2020/02/22 23:18:43, hanwenn wrote: > > > On 2020/02/22 23:17:50, hanwenn wrote: > > > > you were already potentially in a state where you have 3 jobs each > > spawning 3 > > > >

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sun, Feb 23, 2020 at 12:16 AM David Kastrup wrote: >> >> Yes. But if every developer tests on the same platform, we will have >> to email back and forth with users to figure out what is going on >> when the stuff does not blow up on our unified platform code. We

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

On Sun, Feb 23, 2020 at 12:29 AM wrote: > > On 2020/02/22 23:18:43, hanwenn wrote: > > On 2020/02/22 23:17:50, hanwenn wrote: > > > you were already potentially in a state where you have 3 jobs each > spawning 3 > > > lp-book invocations, > > > > whoops, I mean: 3 lp-book invocations spawning 3

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 11:43 PM David Kastrup wrote: > >> Assuming that all translations are kept at exactly the same level and > >> the example code is not at all adapted to the language in question in > >> lyrics and code comments. > >> > >> And assuming that our regtests make up 40% of the

Re: testing out Docker CI scripts?

On Sun, Feb 23, 2020 at 12:16 AM David Kastrup wrote: > > Yes, it's an oversimplification that fits in an email so we can > > discuss next steps. My question is: are there fundamental features > > that you think are missing? > > In what we are doing now? Or in what you have proposed? Since the

Re: testing out Docker CI scripts?

On Sun, Feb 23, 2020 at 12:16 AM David Kastrup wrote: > >> Which makes it less likely that we discover portability problems. I > >> am not sure what problem you are trying to address here. > > > > It means that if CI sees an error (because it does testing on multiple > > platforms), it is

Re: [translations] Re: 2.20.0 release coordination with translation. Other showstoppers?

Il giorno sab 22 feb 2020 alle 23:54, David Kastrup ha scritto: My principle plan would be to tell Phil to go ahead (after receiving the last OK from people doing last-minute work) at a point of time where he thinks he may be somewhat responsive in the followup days, just in case something

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

On 2020/02/22 23:18:43, hanwenn wrote: > On 2020/02/22 23:17:50, hanwenn wrote: > > you were already potentially in a state where you have 3 jobs each spawning 3 > > lp-book invocations, > > whoops, I mean: 3 lp-book invocations spawning 3 lilypond subprocesses each, for > 9 in total.

Re: run-and-check: close stdin (issue 545620043 by hanw...@gmail.com)

On 2020/02/22 22:08:33, hanwenn wrote: > On 2020/02/22 22:01:10, lemzwerg wrote: > > Never seen such code before, but if it fixes an issue... :-) > > it's a cut and paste from the internet, > https://blog.apokalyptik.com/2007/10/24/bash-tip-closing-file-descriptors/ > > I'm surprised that make

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

https://codereview.appspot.com/569400043/diff/549600043/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/569400043/diff/549600043/input/regression/lilypond-book/GNUmakefile#newcode42

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

On 2020/02/22 23:17:50, hanwenn wrote: > you were already potentially in a state where you have 3 jobs each spawning 3 > lp-book invocations, whoops, I mean: 3 lp-book invocations spawning 3 lilypond subprocesses each, for 9 in total. https://codereview.appspot.com/569400043/

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

On 2020/02/22 22:27:05, Dan Eble wrote: > How does this interact with CPU_COUNT, which is documented in the Contributor's > Guide thus (emphasis mine)? > > The most time consuming task for building the documentation is > running LilyPond to build images of music, and *** there cannot be >

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sat, Feb 22, 2020 at 10:01 PM David Kastrup wrote: >> >> That's oversimplifying the staging->master push process a bit which goes >> >> to considerable pain to make sure that its own copy of staging is still >> >> part of the upstream staging branch before pushing

Re: testing out Docker CI scripts?

On 2/22/2020 4:43 PM, David Kastrup wrote: The download size for the notation manual comes out at 35MB which is about double than what we had for 2.16. I actually find that somewhat irritating. I'd have to check the old conversations about extractpdfmark and see whether this is indeed where

Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)

https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36

Re: 2.20.0 release coordination with translation. Other showstoppers?

Federico Bruni writes: > Il giorno sab 22 feb 2020 alle 19:25, David Kastrup ha > scritto: >> German Changes file has been added by now. Where are we with regard >> to >> the other translations? Federico? > > I'm still working on it. > My spare time is limited and the changes by Werner

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sat, Feb 22, 2020 at 9:54 PM David Kastrup wrote: >> > On Sat, Feb 22, 2020 at 5:23 PM Jonas Hahnfeld wrote: >> >> > I would be interested in your feedback. >> >> >> >> Not having run any of this, my immediate response would that it's not >> >> running 'make doc'

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

How does this interact with CPU_COUNT, which is documented in the Contributor's Guide thus (emphasis mine)? The most time consuming task for building the documentation is running LilyPond to build images of music, and *** there cannot be several simultaneously running lilypond-book

Re: run-and-check: close stdin (issue 545620043 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: On 2020/02/22 22:01:10, lemzwerg wrote: > Never seen such code before, but if it fixes an issue... :-) it's a cut and paste from the internet, https://blog.apokalyptik.com/2007/10/24/bash-tip-closing-file-descriptors/ I'm surprised that make passes on the console

run-and-check: close stdin (issue 545620043 by hanw...@gmail.com)

Never seen such code before, but if it fixes an issue... :-) https://codereview.appspot.com/545620043/

Re: Use $(MAKE) instead of 'make' in lilypond-book regtests (issue 569400043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/569400043/

Re: 2.20.0 release coordination with translation. Other showstoppers? (was: 2.20.0 release coordination with translation, also Germans?)

Il giorno sab 22 feb 2020 alle 19:25, David Kastrup ha scritto: German Changes file has been added by now. Where are we with regard to the other translations? Federico? I'm still working on it. My spare time is limited and the changes by Werner requires a lot of meticulous edits. If you

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 10:01 PM David Kastrup wrote: > >> That's oversimplifying the staging->master push process a bit which goes > >> to considerable pain to make sure that its own copy of staging is still > >> part of the upstream staging branch before pushing the tested result. > >> That

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 10:11 PM Han-Wen Nienhuys wrote: > > On Sat, Feb 22, 2020 at 9:54 PM David Kastrup wrote: > > > On Sat, Feb 22, 2020 at 5:23 PM Jonas Hahnfeld wrote: > > >> > I would be interested in your feedback. > > >> > > >> Not having run any of this, my immediate response would

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 9:54 PM David Kastrup wrote: > > On Sat, Feb 22, 2020 at 5:23 PM Jonas Hahnfeld wrote: > >> > I would be interested in your feedback. > >> > >> Not having run any of this, my immediate response would that it's not > >> running 'make doc' AFAICS. > > > > For changes to the

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sat, Feb 22, 2020 at 3:06 PM David Kastrup wrote: >> > I would be interested in your feedback. >> > >> > For example, I think it could be used for validating the staging -> >> > master push in the following way: >> > >> > ( cd lilypond ; git fetch origin ) && \

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > On Sat, Feb 22, 2020 at 5:23 PM Jonas Hahnfeld wrote: >> > I would be interested in your feedback. >> >> Not having run any of this, my immediate response would that it's not >> running 'make doc' AFAICS. > > For changes to the code, it should be irrelevant to run

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 3:06 PM David Kastrup wrote: > > I would be interested in your feedback. > > > > For example, I think it could be used for validating the staging -> > > master push in the following way: > > > > ( cd lilypond ; git fetch origin ) && \ > > sh test-git.sh --ubuntu

Re: testing out Docker CI scripts?

On Sat, Feb 22, 2020 at 5:23 PM Jonas Hahnfeld wrote: > > I would be interested in your feedback. > > Not having run any of this, my immediate response would that it's not > running 'make doc' AFAICS. For changes to the code, it should be irrelevant to run make doc: the regression test should

2.20.0 release coordination with translation. Other showstoppers? (was: 2.20.0 release coordination with translation, also Germans?)

David Kastrup writes: > Federico Bruni writes: > >> Il giorno lun 17 feb 2020 alle 22:49, Federico Bruni >> ha scritto: > >>> I'm working on the italian update and I hope to be ready before >>> Thursday night. >>> >> >> Can we have one day delay? So deadline to push to translation branch >>

Re: testing out Docker CI scripts?

Am Samstag, den 22.02.2020, 14:29 +0100 schrieb Han-Wen Nienhuys: > Hi there, > > I've been working on a set of scripts that provides a reproducible > test environment for running LilyPond regtests. In addition to being > reproducible, it has some performance tweaks to speed up > recompilations.

Re: testing out Docker CI scripts?

Han-Wen Nienhuys writes: > Hi there, > > I've been working on a set of scripts that provides a reproducible > test environment for running LilyPond regtests. In addition to being > reproducible, it has some performance tweaks to speed up > recompilations. Performance tends to be part of what we

testing out Docker CI scripts?

Hi there, I've been working on a set of scripts that provides a reproducible test environment for running LilyPond regtests. In addition to being reproducible, it has some performance tweaks to speed up recompilations. See https://github.com/hanwen/lilypond-ci I would be interested in your

PATCHES - Countdown for February 22nd

Hello, Here is the current patch countdown list. The next countdown will be on February 24th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5772 Confirm grob-status in