On 2015/04/26 02:35:34, Carl wrote:
baseMoment does have another use. It is used to define the major
beaming groups
for automatic beaming.
...
And this use of baseMoment is important for subdivision; subdivision
is only
possible at units of baseMoment.
Thanks,
Carl
OK, so I
On 2015/04/25 22:58:56, Carl wrote:
On 2015/04/25 11:54:01, benko.pal wrote:
2015-04-25 10:20 GMT+02:00 mailto:lilyli...@googlemail.com:
Thank you for picking this up. It is certainly an improvement
already.
However: In an example where 8 32th notes are subdivided by 16th
notes
ony
I have now checked the code for my interface idea, and it seems to work.
In short, I did the following:
- assign the subdivideBeams context property to base_moment
- set subdivide_beams_ to true or false, depending on the value of
base_moment_
- change to predicate of subdivideBeams to ly:moment?
Thank you for picking this up. It is certainly an improvement already.
However: In an example where 8 32th notes are subdivided by 16th notes
ony the first and third subdivision should have two beams, the second
one only one beam.
Put differently: when there is following a total of an eighth
On 2015/04/25 08:20:52, uliska wrote:
Thank you for picking this up. It is certainly an improvement already.
However: In an example where 8 32th notes are subdivided by 16th notes
ony the
first and third subdivision should have two beams, the second one only
one beam.
Put differently:
Reviewers: ,
Message:
It would be a pity to miss out on the opportunity to mention the famous
commissioniers of this project.
Description:
web: productions: Update Aurélien's Rosenkavalier
Please review this at https://codereview.appspot.com/212330044/
Affected files (+11, -7 lines):
M
Reviewers: ,
Message:
See discussion here:
http://lists.gnu.org/archive/html/lilypond-user/2015-03/msg00180.html
Description:
Remove redundant (and) in ly/init.ly
This (and) construct is redundant because the first expression is
explicitly #t.
Please review this at
Reviewers: ,
Description:
Issue 4254: Fix typo in NR example (vocal music)
Please review this at https://codereview.appspot.com/189520044/
Affected files (+1, -1 lines):
M Documentation/notation/vocal.itely
Index: Documentation/notation/vocal.itely
diff --git
LGTM too.
Of course this doesn't look right out-of-the-box (maybe it would be good
to let the Tie being printed as a Slur instead). But as one can use
\shape it's at least possible to use that as a working and semantically
correct solution.
It even works with cross-staff ties (although I suspect
The patch works as expected.
However, it has to be noted that by default (that is, running without
the option) *keeps* the tags. When I define a command and encapsulate it
in a tag this command is executed unless explicitly switched off with
-dtags-to-remove.
https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacing.itely#newcode1857
Documentation/notation/spacing.itely:1857: @end lilypond
On
Reviewers: ,
Description:
Add original-breaks.ly commands
The commands defined in this patch allow the user to insert breaks
(line and page) from the original manuscript that are conditionally
respected or discarded. This is very useful for entering and
proof-reading music from larger scores.
Reviewers: ,
Message:
This is the current state of Abraham's approach to make music fonts
switchable. The patch is incomplete in a few senses, but Abraham wants
an official review for that current state:
- there's no documentation
- We'll take care of that once the user interface
has
Thanks, LTGM now
https://codereview.appspot.com/118350043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Apart from my comment LGTM
https://codereview.appspot.com/118350043/diff/1/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (right):
https://codereview.appspot.com/118350043/diff/1/Documentation/web/introduction.itexi#newcode1221
Reviewers: ,
Message:
I will push that as soon as it passes the tests
Description:
CG: Fix typo
Reported by Pierre Perol-Schneider
http://lists.gnu.org/archive/html/bug-lilypond/2014-06/msg00044.html
Please review this at https://codereview.appspot.com/109140043/
Affected files (+1, -1
Reviewers: ,
Message:
As discussed last time I uploaded this ponding patch for review.
But as it doesn't need any review I'll push to staging as soon as the
patch passes the tests
Description:
Remove ponding about Berne conference
Please review this at https://codereview.appspot.com/102150044/
On 2014/05/27 09:38:11, PhilEHolmes wrote:
Please review
According to the comparison images in
https://code.google.com/p/lilypond/issues/detail?id=3902#c5 this is
definitely an improvement. (I had looked for that issue myself, but I
have to admit that I have to stop when entering the C++ area
On 2014/05/27 10:00:53, lemzwerg wrote:
LGTM.
What about making this configurable? I can imagine that for some
special
situations a higher default position of rests is desirable (e.g.,
fugues and the
like).
+1. Maybe with my suggested \oneVoice behaviour as the default?
Reviewers: ,
Description:
Add dodecaphonic-first accidental style
This accidental style assigns accidentals to _all_ pitches
(just as dodecaphonic does) but remembers them throughout
a whole measure.
This style is useful for different styles of contemporary notation
that want to make use of the
Reviewers: ,
Message:
This is an addition that David Nalesnik provided upon my request. I
consider this a commonly used accidental style in contemporary music.
Description:
Add documentation for dodecaphonic-no-repeat
Add dodecaphonic-no-repeat accidentalStyle
This adds an accidental style
On 2014/02/10 12:50:27, J_lowe wrote:
Thanks Urs.
Some minor points.
https://codereview.appspot.com/61510043/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
Reviewers: ,
Description:
CG: Add hints about using/adding images
This is somewhat sketchy, but I can't afford to make this more thorouh
ATM.
Please review this at https://codereview.appspot.com/61540043/
Affected files (+25, -0 lines):
M Documentation/contributor/doc-work.itexi
M
Reviewers: ,
Message:
This has been waiting for some time, but is in line with stuff I did
earlier and was also discussed earlier.
A new page/node making the relation between input file, _any_ editor and
_dedicated_ editor more explicit, hopefully being a step to reduce
confusion for potential
On 2014/02/07 14:29:15, PhilEHolmes wrote:
An initial comment:
https://codereview.appspot.com/60530047/diff/1/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (left):
On 2014/02/07 15:33:19, uliska wrote:
Add pictures, fix whitespace errors
As said earlier, I don't know how the colors of menu items are managed.
So without more input I can't do anything about that.
https://codereview.appspot.com/60530047/
___
https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (right):
https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction.itexi#newcode1138
Documentation/web/introduction.itexi:1138: before they come up!
Reviewers: ,
Message:
How about that?
It doesn't include David's latest suggestions (because I was already
ready with it).
This suggestion is merely a kind of in-place rewrite, but
of course I'd also incorporate the more verbose suggestion
(particularly as I will be working on this
Text input
Reviewers: ,
Description:
Web:Introduction: Rename Our Goal box
The content of this box was somewhat confusing and inconsistent. See
http://lists.gnu.org/archive/html/lilypond-devel/2014-01/msg00011.html
This commit tries to incorporate the suggestions made in this thread
as far as I
https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (right):
https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi#newcode14
Documentation/web/introduction.itexi:14: @subheading Our Mission
Reviewers: ,
Description:
Web:Examples: Enclose in box
I think the pages below Introduction (and probably Community too)
should consistently start with a box and a subheading,
because there is no eye-catching page heading.
This is _one_ option to do that for the Examples page.
Others would be:
Reviewers: ,
Description:
Web:Productions: Add title box
As stated in https://codereview.appspot.com/48450044/
I think the Introduction pages should have a title box
giving the user a first idea about the page.
In this case the visitor (currently) would reach the page,
doesn't see a heading
Reviewers: ,
Description:
Web:Background: Reword introductory paragraph
I've always found this page confusing because I didn't understand
why there is this placeholder page.
This commit addresses this by making the manual issue explicit.
Additionally I consider it more useful to _first_ tell
https://codereview.appspot.com/42770043/diff/1/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (right):
https://codereview.appspot.com/42770043/diff/1/Documentation/web/introduction.itexi#newcode119
Documentation/web/introduction.itexi:119: @divClass{color2}
On
Reviewers: ,
Message:
This is much like the page I presented earlier at
(http://openlilylib.org/lilyweb/features.html), with some minor
modifications, and within the existing navigational structure
Description:
This is a rewrite of the Features page in order to make the structure of
this page
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi
File Documentation/web/download.itexi (left):
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi#oldcode35
Documentation/web/download.itexi:35: @warningTextBased
On 2013/12/14
Incorporated most of the comments.
Will upload new patch set in a minute
https://codereview.appspot.com/40510046/diff/20001/Documentation/web/download.itexi
File Documentation/web/download.itexi (right):
Reviewers: ,
Message:
Describing the solution for my problem when using git-cl for the first
time
Description:
CG: Add comment about git-cl editor
git-cl fires either the editor specified by the EDITOR environment
variable or vi if EDITOR isn't defined.
Commit mentions this in the CG
Please
Reviewers: ,
Description:
Web: Download: Add introductory text
This addresses the initial issue discussed on lilypond-user:
too many people don't understand what they download and get
stuck on not being able to open the LilyPond program.
Add a text that explains the compiled approach and makes
On 2013/12/12 11:11:45, uliska wrote:
Describing the solution for my problem when using git-cl for the first
time
Actually I'm not sure if @var is the right one here?
https://codereview.appspot.com/41310043/
___
lilypond-devel mailing list
Reviewers: ,
Message:
As suggested here
http://lists.gnu.org/archive/html/lilypond-devel/2013-12/msg00183.html
a first small patch for the website
Description:
Web: Reword contactUsAbout macro
Providing information on new reviews/productions etc.
should be possible by simply writing an email
41 matches
Mail list logo
