Re: Limit looping in Grob::common_refpoint (issue 4079) (issue 134600043 by e...@ticalc.org)

2014-09-07 Thread m...@mikesolomon.org
On 7 sept. 2014, at 09:20, d...@gnu.org wrote: I don't like it. The maximum range of a variable is an arbitrary value and this loop avoidance will not do us much good on a 64-bit architecture. If this is a real concern, we should be either using a tortoise/hare algorithm here in order to

Re: Bug in Lookup::bezier_sandwich

2014-08-30 Thread m...@mikesolomon.org
Sent from my iPhone On 30 août 2014, at 18:54, Jürgen Reuter reute...@web.de wrote: Hi all, there is a bug in Lookup::bezier_sandwich that severely affects ancient notation. This method was originally added to lookup.cc for flexa/porrectus support. In version 2.14, the

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-24 Thread m...@mikesolomon.org
Sent from my iPhone On 24 août 2013, at 12:47, pkx1...@gmail.com wrote: On 2013/08/24 08:25:14, dak wrote: On 2013/08/24 08:05:13, mike7 wrote: On 24 août 2013, at 10:18, mailto:lemzw...@googlemail.com wrote: LGTM, except of using `surrogate' in the name. Given that the stencil

Cross-staff and skyline work

2013-05-16 Thread m...@mikesolomon.org
Hey all, Just a quick note to say that I'm eye-deep in work but I'm reading the LilyPond list every other day. I don't want anything related to my work to get bogged down by my absence. If you have specific questions about how something works (or doesn't), don't hesitate to send me an e-mail

Re: Avoids direction checking for cross-staff side-support-elements (issue 8557044)

2013-04-23 Thread m...@mikesolomon.org
On 24 avr. 2013, at 01:06, k-ohara5...@oco.net wrote: lgtm Somewhere I'll have to write down the definition cross-staff: true for a grob whose placement or size could depend on the spacing of staves on the page. It's not quite that. In the definition above, a treble clef on the 5th staff

Re: Adds padding around extender of line-spanners. (issue 8819043)

2013-04-20 Thread m...@mikesolomon.org
On 20 avr. 2013, at 08:06, k-ohara5...@oco.net wrote: https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371 lily/line-spanner.cc:371: // actual stencil

Re: [Lilypond-auto] Issue 3325 in lilypond: Stems should not pass between the letters of a word

2013-04-19 Thread m...@mikesolomon.org
Current master off of lilydev Sent from my iPhone On 19 avr. 2013, at 19:55, lilyp...@googlecode.com wrote: Comment #3 on issue 3325 by k-ohara5...@oco.net: Stems should not pass between the letters of a word http://code.google.com/p/lilypond/issues/detail?id=3325 I need to match your

Re: Gives DynamicTextSpanner a default skyline-horizontal-padding (issue 8799045)

2013-04-18 Thread m...@mikesolomon.org
On 18 avr. 2013, at 10:51, k-ohara5...@oco.net wrote: I suggest that you set the defaults consistently for all text grobs, so that I don't have to file bug reports one-at-a-time for every possible case: \paper { indent = 0\mm line-width = 42.2\mm ragged-right = ##f } \score { \new Staff

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

2013-04-16 Thread m...@mikesolomon.org
On 16 avr. 2013, at 12:59, d...@gnu.org wrote: On 2013/04/16 08:34:43, MikeSol wrote: On 2013/04/16 07:51:46, dak wrote: I hate it when I get last-minute realizations. Here is another thing we need to do for the stable release: go through all problems of the too snug kind and work out

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

2013-04-16 Thread m...@mikesolomon.org
On 16 avr. 2013, at 22:12, d...@gnu.org wrote: On 2013/04/16 11:11:03, janek wrote: 2013/4/16 d...@gnu.org: I hate it when I get last-minute realizations. Here is another thing we need to do for the stable release: go through all problems of the too snug kind and work out defaults

Re: Woodwind diagrams (issue 1425041)

2013-04-15 Thread m...@mikesolomon.org
On 15 avr. 2013, at 15:38, d...@gnu.org wrote: https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps File ps/music-drawing-routines.ps (right): https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps#newcode196

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-04-12 Thread m...@mikesolomon.org
On 12 avr. 2013, at 22:29, k-ohara5...@oco.net wrote: https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc#newcode370 lily/skyline.cc:370: if (x1 = last_end) Oops. This controls

Re: Wanting to be involved in lilypond project again

2013-04-10 Thread m...@mikesolomon.org
On 10 avr. 2013, at 16:13, Fan Ziye fanzi...@gmail.com wrote: Dear list, Hi, I introduced myself to you several weeks ago – a fourth-year undergraduate student of EECS wanting to be involved in lilypond’s developing. And then Mike told me to read the CG. (Thank you very much!). But

Re: Allows slurs to break at barlines. (issue 7424049)

2013-04-09 Thread m...@mikesolomon.org
On 9 avr. 2013, at 20:31, k-ohara5...@oco.net wrote: On 2013/03/26 04:10:38, mike7 wrote: On 25 mars 2013, at 07:10, mailto:k-ohara5...@oco.net wrote: Please do just one manual review of the regression suite between versions before adding another test of this length. I wanted to

Re: Stable release state

2013-04-06 Thread m...@mikesolomon.org
On 6 avr. 2013, at 12:07, David Kastrup d...@gnu.org wrote: With the recent batch of material with missing documentation, extensive code changes and new functionality without previous exposure and moving interfaces (like commit 88d306d9c5666b5ade4a136df29cca19c5ff5ed7 Author: Mike Solomon

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-04-02 Thread m...@mikesolomon.org
On 3 avr. 2013, at 01:57, d...@gnu.org wrote: On 2013/04/02 22:34:53, janek wrote: I'll risk joining the discussion. I see valid points from both of you. I agree that it's better to fix a broken design than to patch it with red tape. It isn't patched. minimum-length is used in

Re: rewrite Self_alignment_interface (issue 7768043)

2013-04-01 Thread m...@mikesolomon.org
On 1 avr. 2013, at 14:13, Janek Warchoł janek.lilyp...@gmail.com wrote: Hi all, On Mon, Apr 1, 2013 at 7:52 AM, mts...@gmail.com wrote: I'd recommend adding a sort of padding property to the self-alignment-interface to get it completely there. That is, imagine that we right align to a

Re: rewrite Self_alignment_interface (issue 7768043)

2013-04-01 Thread m...@mikesolomon.org
On 2 avr. 2013, at 00:51, janek.lilyp...@gmail.com wrote: On Mon, Apr 1, 2013 at 1:20 PM, m...@mikesolomon.org m...@mikesolomon.org wrote: X-extent is used in many things other than self alignment positioning, so u don't want to change extents. Every positioning in LilyPond has some notion

Re: More regtest differences

2013-03-30 Thread m...@mikesolomon.org
On 30 mars 2013, at 07:08, m...@mikesolomon.org wrote: On 30 mars 2013, at 06:42, Keith OHara k-ohara5...@oco.net wrote: Phil Holmes email at philholmes.net writes: The second is the substantial change in the Les Nereides system spacing. Deliberate? The second change is from

Re: [Lilypond-auto] Issue 3256 in lilypond: Patch: Eliminates side poisition calculations for system-start-text grobs.

2013-03-30 Thread m...@mikesolomon.org
On 30 mars 2013, at 08:27, lilyp...@googlecode.com wrote: Updates: Labels: -Patch-push Comment #8 on issue 3256 by d...@gnu.org: Patch: Eliminates side poisition calculations for system-start-text grobs. http://code.google.com/p/lilypond/issues/detail?id=3256 This patch has

Re: Allows outside staff positioning for vertical axis groups with no staff (issue 8188044)

2013-03-30 Thread m...@mikesolomon.org
On 30 mars 2013, at 08:33, k-ohara5...@oco.net wrote: Why not use the flat-line for empty VerticalAxisGroups specifically in side-position-interface.cc when placing something against the staff (in the clause if (include_staff) {} ) ? include_staff is false for VerticalAxisGroups without

Re: Allows outside staff positioning for vertical axis groups with no staff (issue 8188044)

2013-03-30 Thread m...@mikesolomon.org
On 30 mars 2013, at 10:29, k-ohara5...@oco.net wrote: Simpler to just reverse the special X-alignment commit. The old code, that followed the comment about a 'kldge' whatever that means, was rather elegant. If we are placing something alongside an empty set, place it against the reference

instrument name patch reverted

2013-03-30 Thread m...@mikesolomon.org
Hey all, I reverted the instrument name patch in staging. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: More regtest differences

2013-03-29 Thread m...@mikesolomon.org
On 29 mars 2013, at 18:48, Phil Holmes em...@philholmes.net wrote: I've been comparing the result of my push of my pixel-based regtest comparator (b4fe233aec83383bd2e6b6170fca67a31a8c492d) with current master (6e4e69f2735a764eab2e6f70f83546461da0203b). There are 2 changes that concern me.

Re: More regtest differences

2013-03-29 Thread m...@mikesolomon.org
On 29 mars 2013, at 20:36, Janek Warchoł janek.lilyp...@gmail.com wrote: On Fri, Mar 29, 2013 at 7:04 PM, Phil Holmes em...@philholmes.net wrote: - Original Message - From: Janek Warchoł janek.lilyp...@gmail.com On Fri, Mar 29, 2013 at 5:48 PM, Phil Holmes em...@philholmes.net

Re: Removes outside-staff-priority from dynamic-related objects in Dynamic context (issue 7655045)

2013-03-29 Thread m...@mikesolomon.org
On 2013/03/27 21:50:02, janek wrote: What was wrong with the skylines that caused this bug? Maybe this is just one instance of a more general problem. The skylines themselves were fine, but objects above a Staff are not checked for collisions with objects below a Staff. In the

Re: More regtest differences

2013-03-29 Thread m...@mikesolomon.org
On 30 mars 2013, at 06:42, Keith OHara k-ohara5...@oco.net wrote: Phil Holmes email at philholmes.net writes: The second is the substantial change in the Les Nereides system spacing. Deliberate? The second change is from the commit immediately before yours, Uses special X alignment for

Re: PATCHES: Countdown - for March 26th 19:00GMT

2013-03-28 Thread m...@mikesolomon.org
On 23 mars 2013, at 13:59, James pkx1...@gmail.com wrote: Hello, Countdown – March 26th 2013 – 19:00 GMT 3134 Enhancement Mike SolomonPushPatch: Removes the translate_axis call from axis-group-interface outside-staff positioning. James

Re: Suggestions for participating institutions?

2013-03-26 Thread m...@mikesolomon.org
On 26 mars 2013, at 10:52, David Kastrup d...@gnu.org wrote: Hi, I met a former colleague in the bus to Chemnitz, and he is at least knowledgeable about EU research programmes. Do people here have ideas about possible institutions who could be made to participate? I think the

critical issues

2013-03-26 Thread m...@mikesolomon.org
There are two critical issues that we're going to have to start seriously thinking about now if 2.18 is going to happen anytime soon: https://code.google.com/p/lilypond/issues/detail?id=2733 I'm not comfortable marking this critical: not because it is not critical for Laura, nor because it may

Re: critical issues

2013-03-26 Thread m...@mikesolomon.org
On 27 mars 2013, at 07:54, Werner LEMBERG w...@gnu.org wrote: https://code.google.com/p/lilypond/issues/detail?id=2656 This is really bad. I agree that it is critical. I unfortunately have no way to test this, but do people have an ETA for fixing this? If not, it will hold 2.18 up for

Re: Snaps horizontally-offset fingerings to vertical column. (issue 7988043)

2013-03-25 Thread m...@mikesolomon.org
On 25 mars 2013, at 06:42, k-ohara5...@oco.net wrote: Code looks good, but we could get the same result with \override Accidental #'horizontal-skylines = #'() Conceptually, I'm a fan of the snapping idea, but you're right that it takes more time. Would this \override fix all problems of

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-25 Thread m...@mikesolomon.org
On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote: Thanks for taking the time to do this. No-one else knows enough of the various stages of processing to bring all the pieces together. It looks like you try to use a common UP/DOWN direction for the portions of a broken slur, and the

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-25 Thread m...@mikesolomon.org
On 26 mars 2013, at 05:58, Keith OHara k-ohara5...@oco.net wrote: On Mon, 25 Mar 2013 00:29:35 -0700, m...@mikesolomon.org m...@mikesolomon.org wrote: On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote: It looks like you try to use a common UP/DOWN direction for the portions

Re: Eliminates side poisition calculations for system-start-text grobs. (issue 7574048)

2013-03-24 Thread m...@mikesolomon.org
On 24 mars 2013, at 14:59, d...@gnu.org wrote: https://codereview.appspot.com/7574048/diff/5001/input/regression/instrument-name-x-align.ly File input/regression/instrument-name-x-align.ly (right):

git-cl TransientError

2013-03-22 Thread m...@mikesolomon.org
Hey all, I'm getting: Unhandled exception. [TransientError] from git-cl. Any ideas as to what that's all about? Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fingering not aligned in 2.17, ok in 2.16

2013-03-22 Thread m...@mikesolomon.org
On 22 mars 2013, at 18:32, SoundsFromSound soundsfromso...@gmail.com wrote: Hmm..I kind of like the new behavior too, it's easier on my eyes. I like how it staggers to flow with the score, but I can see why some would want strict lined-up fingerings as well. Just my 2 cents. Ben

(almost-)freezing current master

2013-03-21 Thread m...@mikesolomon.org
Hey all, To prepare for 2.18, I think we can get it out fastish, but we need to more or less freeze current master aside from bug fixes and documentation. I have a lot of stuff on the countdown or on patch push that I'm not gonna push for a few months until we get 2.18 out (Ferneyhough

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 07:25, Werner LEMBERG w...@gnu.org wrote: I can even imagine to use to commands, \start and \end to get, say, `\start(' or `\end\'. Who knows, maybe this destinction is advantageous sometime in the future. Maybe even better \startOf and \endOf. Werner The

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 07:50, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 20 mars 2013, at 06:07, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: Trying to put myself in the shoes of the average user, \fake

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 14:52, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 20 mars 2013, at 14:26, d...@gnu.org wrote: Yet another possibility would be \inner but that implies a hierarchy. More accurate would be \continued. https

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 14:26, d...@gnu.org wrote: Yet another possibility would be \inner but that implies a hierarchy. More accurate would be \continued. https://codereview.appspot.com/7424049/ I like \interrupted Cheers, MS ___ lilypond-devel

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
Sent from my iPhone On 20 mars 2013, at 16:38, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: I think any further proposals should _definitely_ explain how to write the given example g f e d( \repeat { c d) e f ( } \alternatives { { g) a b( a \fake) } {

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 18:25, m...@mikesolomon.org m...@mikesolomon.org wrote: Sent from my iPhone On 20 mars 2013, at 16:38, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: I think any further proposals should _definitely_ explain how to write the given example g

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-20 Thread m...@mikesolomon.org
On 20 mars 2013, at 09:26, Trevor Daniels t.dani...@treda.co.uk wrote: m...@mikesolomon.org I completely agree. It's just that fake in English means false or counterfeit. It needs another word, just don't know what yet. unchained? free? At the risk of prolonging the bike-shedding

Re: Creates more possibilities for vertical and horizontal skyline functions. (issue 7516048)

2013-03-19 Thread m...@mikesolomon.org
On 19 mars 2013, at 12:49, janek.lilyp...@gmail.com wrote: Mike, i've read the patch 3 times and i don't understand how it solves the problem. I see that you remove some weird c++ code, but why can you do this? Also, why marking some grobs as cross-staff helps with solving issue 3242,

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-19 Thread m...@mikesolomon.org
On 19 mars 2013, at 22:26, d...@gnu.org wrote: On 2013/03/19 15:22:41, MikeSol wrote: Two backslashes After some consideration, I consider the name \broken suboptimal since it implies two pieces. Two other possibilities would be \detached and \fake.

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread m...@mikesolomon.org
On 19 mars 2013, at 22:04, janek.lilyp...@gmail.com wrote: Hi Mike all, On 2013/03/19 15:21:37, MikeSol wrote: I like where you're going with this. cool! :) I would recommend creating a function algined_on_grobs that accepts a grob, an vector of grobs to align to, and an axis. Then

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-19 Thread m...@mikesolomon.org
On 19 mars 2013, at 23:37, Werner LEMBERG w...@gnu.org wrote: After some consideration, I consider the name \broken suboptimal since it implies two pieces. Two other possibilities would be \detached and \fake. I vote for detached. I vote for \broken. For me, it doesn't imply two

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-19 Thread m...@mikesolomon.org
On 20 mars 2013, at 03:24, d...@gnu.org wrote: On 2013/03/19 22:37:14, wl_gnu.org wrote: After some consideration, I consider the name \broken suboptimal since it implies two pieces. Two other possibilities would be \detached and \fake. I vote for detached. I vote for \broken.

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread m...@mikesolomon.org
On 20 mars 2013, at 00:27, Janek Warchoł janek.lilyp...@gmail.com wrote: Hi, On Tue, Mar 19, 2013 at 11:40 PM, m...@mikesolomon.org m...@mikesolomon.org wrote: The main reason that I suggest this is that exceptions in the code base lead to harder maintenance. I am guilty of adding some

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-19 Thread m...@mikesolomon.org
On 20 mars 2013, at 06:07, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: Trying to put myself in the shoes of the average user, \fake would not mean a function that uses a fake post event, but rather a function that produces a \fake something. I would

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 10:19, d...@gnu.org wrote: You don't fix your own work after it has been committed, This is patently false. Please do not write e-mails like this to a public list that can be read by future employers of mine that want to evaluate my integrity. so why would you fix

Re: alignment of unattached lyrics - opinions needed

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 11:05, Janek Warchoł janek.lilyp...@gmail.com wrote: Hi, On Sat, Mar 16, 2013 at 12:20 PM, David Kastrup d...@gnu.org wrote: Do we really need a particular associated voice instead of being able to do this with general music column alignment? I'll write a full answer

Re: alignment of unattached lyrics - opinions needed

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 12:29, Neil Puttock n.putt...@gmail.com wrote: On Mar 17, 2013 11:10 AM, m...@mikesolomon.org m...@mikesolomon.org wrote: In the stop_translation_timestep method of the lyric engraver, lyrics are given note heads as parents. Could you send a minimal where the lyrics

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 13:36, thomasmorle...@googlemail.com wrote: On 2013/03/17 07:27:37, MikeSol wrote: On 2013/03/13 21:38:59, thomasmorley65 wrote: https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm File scm/output-lib.scm (right):

Re: Documents make-partial-ellipse-stencil (issue 7497046)

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 17:22, m...@hohlart.de wrote: Just one nitpick. https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/7497046/diff/1/scm/stencil.scm#newcode251 scm/stencil.scm:251: Makes a list of angle/radius

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 17:25, joseph.wakel...@gmail.com wrote: Final remark: while it's nice to see Ferneyhough getting namechecked might it be worth naming this alteration as flared-hairpin rather than ferneyhough-hairpin? My suggestion was flairpin, which is infinitely cheesier and thus

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-17 Thread m...@mikesolomon.org
On 17 mars 2013, at 17:46, joseph.wakel...@gmail.com wrote: On a related issue: one thing that's probably clear looking at Ferneyhough scores is the way in which the vertical placement of hairpin endpoints is strongly coupled with the vertical placement of dynamic marks. I don't think

Re: Creates more possibilities for vertical and horizontal skyline functions. (issue 7516048)

2013-03-16 Thread m...@mikesolomon.org
On 16 mars 2013, at 04:26, k-ohara5...@oco.net wrote: good enough https://codereview.appspot.com/7516048/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): https://codereview.appspot.com/7516048/diff/1/scm/define-grobs.scm#newcode312 scm/define-grobs.scm:312:

Re: big-picture question regarding Lilypond's capabilities (current and potential)

2013-03-16 Thread m...@mikesolomon.org
On 16 mars 2013, at 17:17, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: Hello all, My two-act musical, Robin Hood: The Legendary Musical Comedy, had a three-week run at Toronto's Hart House Theatre in January. It was quite successful, to the point that several parties have

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2013-03-14 Thread m...@mikesolomon.org
On 14 mars 2013, at 06:44, m...@mikesolomon.org wrote: On 14 mars 2013, at 06:42, k-ohara5...@oco.net wrote: issue 3242 https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/6827072

Re: Gives invisible stems point extents. (issue 7762049)

2013-03-14 Thread m...@mikesolomon.org
On 14 mars 2013, at 08:05, k-ohara5...@oco.net wrote: So then the convention for an extent is '(+inf.0 . -inf.0) is empty, but for skylines in the cross direction it is an infinite wall; '(0 . 0) is a point, but ignored for skylines; '(-inf.0 . +inf.0) is an infinite wall all the time.

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-13 Thread m...@mikesolomon.org
On 13 mars 2013, at 00:02, janek.lilyp...@gmail.com wrote: Nice hairpins! Janek https://codereview.appspot.com/7615043/diff/23001/input/regression/ferneyhough-hairpins.ly File input/regression/ferneyhough-hairpins.ly (right):

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-03-13 Thread m...@mikesolomon.org
On 12 mars 2013, at 23:44, janek.lilyp...@gmail.com wrote: Hi Mike, i've read changes in code and i don't quite get what this change is for. What makes it possible that we can now accept boxes that are narrower than epsilon? What can we achieve with that and why? I'm sorry for asking

convert-ly rule

2013-03-13 Thread m...@mikesolomon.org
Hey all, I'm not too good at writing convert-ly rules. Is there a model I can use for replacing a property with another? Specifically, I'd like to write a patch changing: TupletBracket.staff-padding to: TupletBracket.bracket-staff-padding as one cannot currently use the side position

Re: convert-ly rule

2013-03-13 Thread m...@mikesolomon.org
On 13 mars 2013, at 10:51, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: Hey all, I'm not too good at writing convert-ly rules. Is there a model I can use for replacing a property with another? Specifically, I'd like to write a patch changing

Re: convert-ly rule

2013-03-13 Thread m...@mikesolomon.org
On 13 mars 2013, at 11:00, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: Hey all, I'm not too good at writing convert-ly rules. Is there a model I can use for replacing a property with another? Specifically, I'd like to write a patch changing

Re: convert-ly rule

2013-03-13 Thread m...@mikesolomon.org
On 13 mars 2013, at 11:56, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 13 mars 2013, at 11:00, David Kastrup d...@gnu.org wrote: It might also be possible to let a callback check for the existing grob interfaces in possible cases of contention

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2013-03-13 Thread m...@mikesolomon.org
On 14 mars 2013, at 06:42, k-ohara5...@oco.net wrote: issue 3242 https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc#newcode902

Re: Freezing for 2.18

2013-03-11 Thread m...@mikesolomon.org
On 10 mars 2013, at 22:30, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: So, to resume, I agree that a freeze is important. When the freeze kicks in, I'd rather that we say something like no new big projects starting on date X will be part of 2.18 so that developers

Re: Freezing for 2.18

2013-03-11 Thread m...@mikesolomon.org
On 11 mars 2013, at 16:32, Trevor Daniels t.dani...@treda.co.uk wrote: David Kastrup wrote Sunday, March 10, 2013 5:32 PM 2.16 is growing old. So I want to see 2.18 soon. That means we need to stabilize work that has already been done and cut down on experiments in the master branch.

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-11 Thread m...@mikesolomon.org
On 12 mars 2013, at 00:38, thomasmorle...@googlemail.com wrote: Hi Mike, sorry to have some more nit-picks. https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm File scm/output-lib.scm (right):

Re: Freezing for 2.18

2013-03-10 Thread m...@mikesolomon.org
On 10 mars 2013, at 18:32, David Kastrup d...@gnu.org wrote: Ok folks, it is this time of the year again: I am trying to make myself unpopular. There's a time of the year for that? It also means that commits of the this really does nothing, but it prepares the ground for $xxx, and I don't

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-03-09 Thread m...@mikesolomon.org
On 9 mars 2013, at 09:51, d...@gnu.org wrote: On 2013/03/09 07:18:50, mike7 wrote: On 8 mars 2013, at 14:10, mailto:d...@gnu.org wrote: https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly File input/regression/minimum-length-end-line.ly (right):

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-09 Thread m...@mikesolomon.org
On 10 mars 2013, at 01:47, thomasmorle...@googlemail.com wrote: Hi Mike, decrescendo doesn't work!! Yikes! Will fix. Thanks for spotting this. My idea about drag-hairpin seems not too hard to implement, ofcourse there would be need to do a clean definition of the property, currently

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-08 Thread m...@mikesolomon.org
On 9 mars 2013, at 00:15, thomasmorle...@googlemail.com wrote: Hi Mike, one thought. The image Trevor Bača posted http://lists.gnu.org/archive/html/lilypond-user/2013-03/pngIGBdggySyh.png shows that the left ends of a decrecsendo-hairpin are vertical aligned even if the hairpin isn't

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-03-08 Thread m...@mikesolomon.org
On 8 mars 2013, at 14:10, d...@gnu.org wrote: https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly File input/regression/minimum-length-end-line.ly (right):

Re: Change name of Patch Handler to Patch Meister in CG (issue 7498045)

2013-03-06 Thread m...@mikesolomon.org
On 6 mars 2013, at 10:13, d...@gnu.org wrote: It's a mystery to me how anybody could interpret this text in any other manner, but there is no point in being less clear than possible, so LGTM. https://codereview.appspot.com/7498045/ A handler handles things, i.e. is the person who

Re: Alternative pixel-based regtest checker

2013-03-02 Thread m...@mikesolomon.org
On 1 mars 2013, at 22:33, David Kastrup d...@gnu.org wrote: Phil Holmes em...@philholmes.net writes: There's lots of improvements that could be made: parallelism, using something other than diff, but it basically works. Thoughts? CMP(1) User Commands

Re: Cannot Merge Staging this mornining

2013-03-02 Thread m...@mikesolomon.org
On 2 mars 2013, at 10:16, David Kastrup d...@gnu.org wrote: James pkx1...@gmail.com writes: From: James pkx1...@gmail.com Subject: Cannot Merge Staging this mornining Newsgroups: gmane.comp.gnu.lilypond.devel To: Devel lilypond-devel@gnu.org Date: Sat, 2 Mar 2013 09:02:37 + (4

Re: Cannot Merge Staging this mornining

2013-03-02 Thread m...@mikesolomon.org
On 2 mars 2013, at 10:28, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 2 mars 2013, at 10:16, David Kastrup d...@gnu.org wrote: James pkx1...@gmail.com writes: From: James pkx1...@gmail.com Subject: Cannot Merge Staging this mornining

Re: Allows inheritence for slur engravers (issue 7437048)

2013-03-01 Thread m...@mikesolomon.org
Thanks for the review! Cheers, MS Thanks for the rebase! https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc File lily/slur-engraver.cc (right): https://codereview.appspot.com/7437048/diff/1/lily/slur-engraver.cc#newcode51 lily/slur-engraver.cc:51: event_name_ =

Re: Allows inheritence for slur engravers (issue 7437048)

2013-03-01 Thread m...@mikesolomon.org
On 1 mars 2013, at 17:30, d...@gnu.org wrote: On 2013/03/01 14:45:27, mike7 wrote: doubleSlurs is not generic but rather specific. I'd use something like if (double_property_name_ to_boolean (get_property (double_property_name_))) instead, then we can, if desired, have a separate

Re: Alternative pixel-based regtest checker

2013-03-01 Thread m...@mikesolomon.org
On 1 mars 2013, at 20:15, Phil Holmes em...@philholmes.net wrote: 4 files attached. To try this out: create a new directory and place NoTagline.ly in it. Create a subdirectory called input and put some regtest files in there. Run MakeOldPix.sh. Make a change to lilypond. Run

Re: Uses only unpure-pure containers to articulate unpure-pure relationships. (issue 7377046)

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 06:48, d...@gnu.org wrote: On 2013/02/27 23:00:48, mike7 wrote: On 27 févr. 2013, at 19:06, mailto:d...@gnu.org wrote: https://codereview.appspot.com/7377046/diff/17001/input/regression/scheme-text-spanner.ly File input/regression/scheme-text-spanner.ly (right):

Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 12:16, Werner LEMBERG w...@gnu.org wrote: I think that at the current point of time, we should try getting along with a flat namespace approach. That might imply renaming properties like padding to side-padding if we can't achieve reasonable results otherwise. Not

Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 12:40, Werner LEMBERG w...@gnu.org wrote: Renaming properties which do something differently is the way to go IMHO. Then the first step is finding all properties that are defined in multiple interfaces and changing their names. Maybe a naïve question: Are there

Re: Musings on interfaces and properties

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 12:47, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 28 févr. 2013, at 12:40, Werner LEMBERG w...@gnu.org wrote: Renaming properties which do something differently is the way to go IMHO. Then the first step is finding all

Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 21:30, n.putt...@gmail.com wrote: https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly File input/regression/repeat-slur.ly (right): https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly#newcode14

Re: Allows slurs to break at barlines. (issue 7424049)

2013-02-28 Thread m...@mikesolomon.org
On 28 févr. 2013, at 22:29, Neil Puttock n.putt...@gmail.com wrote: On Feb 28, 2013 8:37 PM, m...@mikesolomon.org m...@mikesolomon.org wrote: You're right, but I've opted for the breaking behavior in the most recent patch-set (\breakSlurHere). Otherwise, slurs wouldn't be able to span

Musings on interfaces and properties

2013-02-27 Thread m...@mikesolomon.org
Hey all, Working on eliminating the translate_axis call from axis-group-interface, I've found a less-than-ideal situation in the naming/using of interfaces and properties that I'd like to clean up, but it'd be a major, major change and would take time to implement. So, before starting it as a

Re: Uses only unpure-pure containers to articulate unpure-pure relationships. (issue 7377046)

2013-02-27 Thread m...@mikesolomon.org
On 27 févr. 2013, at 07:22, k-ohara5...@oco.net wrote: The cardinal cantle seems meldable, but first the cruft needs to be strained. https://codereview.appspot.com/7377046/diff/11001/scm/define-grobs.scm File scm/define-grobs.scm (right):

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-02-27 Thread m...@mikesolomon.org
On 27 févr. 2013, at 07:03, k-ohara5...@oco.net wrote: Just needs cleanup of some leftover unneeded complications. https://codereview.appspot.com/7310075/diff/38001/lily/skyline.cc File lily/skyline.cc (right):

Re: Includes empty skylines in minimum translation calculations (issue 7304068)

2013-02-27 Thread m...@mikesolomon.org
On 27 févr. 2013, at 07:06, k-ohara5...@oco.net wrote: Also needs some decruftification. https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc File lily/align-interface.cc (right): https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc#newcode299

Re: Uses only unpure-pure containers to articulate unpure-pure relationships. (issue 7377046)

2013-02-27 Thread m...@mikesolomon.org
On 27 févr. 2013, at 19:06, d...@gnu.org wrote: https://codereview.appspot.com/7377046/diff/17001/input/regression/scheme-text-spanner.ly File input/regression/scheme-text-spanner.ly (right):

Re: Regtest 2.17.13

2013-02-25 Thread m...@mikesolomon.org
On 25 févr. 2013, at 15:10, David Kastrup d...@gnu.org wrote: James pkx1...@gmail.com writes: On 25 February 2013 12:00, David Kastrup d...@gnu.org wrote: Phil Holmes em...@philholmes.net writes: I've run my pixel comparator on 2.17.13 versus 2.17.12 (note - the output shows this as

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

2013-02-25 Thread m...@mikesolomon.org
On 25 févr. 2013, at 16:29, d...@gnu.org wrote: On 2013/02/24 16:20:53, mike7 wrote: On 24 févr. 2013, at 17:18, David Kastrup mailto:d...@gnu.org wrote: m...@mikesolomon.org mailto:m...@mikesolomon.org writes: On 24 févr. 2013, at 16:37, mailto:d...@gnu.org wrote: On 2013/02/24 13

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

2013-02-25 Thread m...@mikesolomon.org
On 25 févr. 2013, at 23:34, m...@mikesolomon.org wrote: On 25 févr. 2013, at 16:29, d...@gnu.org wrote: On 2013/02/24 16:20:53, mike7 wrote: On 24 févr. 2013, at 17:18, David Kastrup mailto:d...@gnu.org wrote: m...@mikesolomon.org mailto:m...@mikesolomon.org writes: On 24 févr. 2013

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

2013-02-24 Thread m...@mikesolomon.org
On 24 févr. 2013, at 12:40, d...@gnu.org wrote: Stupid question: could you not just check whether outside-staff-priority has been set, and if it has, pass the buck to the right kind of callback automatically? That way, the user does not need to meddle with callbacks himself.

  1   2   3   4   >