On 2015/07/04 14:21:58, Trevor Daniels wrote:
On balance the indentation is improved, but there are a few cases
which are
worse, IMHO. With a follow-up hand-indentation to uncorrect the
worst cases
this would be worth doing, if just to remove the tabs.
If removing the tabs were an issue,
David Kastrup wrote Thursday, June 11, 2015 7:19 AM
URL:http://lilypond.org/doc/v2.10/input/regression/collated-files.html#page-spacing.ly
looks mostly as one would think it should.
There are some effects to be seen in
URL:http://lilypond.org/doc/v2.12/input/regression/collated-files.html
URL:http://lilypond.org/doc/v2.10/input/regression/collated-files.html#page-spacing.ly
looks mostly as one would think it should.
There are some effects to be seen in
URL:http://lilypond.org/doc/v2.12/input/regression/collated-files.html#page-spacing.ly.
Most of them have disappeared
Reviewers: ,
Message:
Please review.
Description:
No procedure-with-setter is provided for ly:spanner-set-bound! in
scm/music-functions.scm. This patch removes the faulty usage in
input/regression/scheme-text-spanner.ly.
Please review this at https://codereview.appspot.com/157100043
regression are some documentation items to
catch up, but those are in progress.
Sounds good.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: Keith OHara k-ohara5...@oco.net
To: lilypond-devel@gnu.org
Sent: Monday, September 09, 2013 5:59 AM
Subject: 2.17.26 regression tests
I re-pushed the fix for issue 2910, which fixes the implementation of
outside-staff-padding, so many many regtests change
Phil Holmes m...@philholmes.net writes:
- Original Message -
From: Phil Holmes m...@philholmes.net
To: lilypond-devel@gnu.org; Keith OHara k-ohara5...@oco.net
Sent: Monday, September 09, 2013 9:18 AM
Subject: Re: 2.17.26 regression tests
I'd seen the same long list of regressions
entry, but people seem
satisfied with the output, so I am as well.
Keith OHara k-ohara5a5a at oco.net writes:
We have a release with no known regressions.
I did forget the \hspace thing from issue 3504.
The other tracked items marked regression are some documentation items to
catch up
.
The test 'parenthesize.ly' now fails to meet its self-description, but that was due a
change to the test input by David, so it seems to be one of his
not-yet-regression tests that will pass after the patch for issue 1523 goes
in.
We have a release with no known regressions
Keith OHara k-ohara5...@oco.net writes:
The test 'parenthesize.ly' now fails to meet its self-description, but
that was due a change to the test input by David, so it seems to be
one of his not-yet-regression tests that will pass after the patch
for issue 1523 goes in.
Yes, sorry. I thought
When I run the regression tests on master, 3257 run nicely.
Some fail (more than 100, difficult to count on the html page) like
input/regression/context-mod-context.log which produces the output
found below.
Is it an issue on my platform (Fedora 19, g++ 4.8.1, Guile 1.8.8) or
are those normal
Frederic,
Upload the patch as normal and I can test this.
James
On 23 August 2013 14:47, Frédéric Bron frederic.b...@m4x.org wrote:
When I run the regression tests on master, 3257 run nicely.
Some fail (more than 100, difficult to count on the html page) like
input/regression/context-mod
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode117
input/regression/scheme-text-spanner.ly:117: (event-drul
Instead, complete-grob-entry (or whatever it was
called)
needs to be changed in order to work non-destructively. It does not
make sense to do this separately from the original code.
OK, I won't bother yet with add-grob-definition here, but I wonder: if I
use copy-tree on a literal
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
input/regression/scheme-text-spanner.ly: fix problem with constants
The file `input/regression/scheme-text-spanner.ly' assigns a constant
pair to the variable `event-drul' and subsequently attempts to modify
the pair. This can
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
input/regression/scheme-text-spanner.ly:28: (set! meta
/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode157
input/regression/scheme-text-spanner.ly:157: (set! event-drul (cons
'() '())
On 2013/07/23 12:31:25, dak wrote:
You could do (set-car! event-drul '())
(set-cdr! event-drul '())
instead in order to not create a new
Thank you, David.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
input/regression/scheme-text
.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode157
input/regression/scheme-text-spanner.ly:157: (set! event-drul (cons
'()
'())
On 2013/07/23 12:31:25, dak wrote:
You could do (set-car! event-drul '())
(set-cdr! event-drul
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
all-grob-descriptions, would the following
On 2013/07/23 15:06:51, dak wrote:
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
On 2013/07/23 20:05:40, david.nalesnik wrote:
Hmmm, so if I understand correctly:
The problem in the regtest is that add-grob-definition should not be
applied to
the quasiquoted list. In doing so, however, nothing is being done that
doesn't
have precedent in define-grobs.scm.
Pretty
On 2013/07/23 20:16:24, dak wrote:
On 2013/07/23 20:05:40, david.nalesnik wrote:
I hesitate to do something like the following!
#(add-grob-definition
'SchemeTextSpanner
(list
(cons
'bound-details
(list
[...]
No, that's nonsensical. Instead, complete-grob-entry
Janek Warchoł janek.lilypond at gmail.com writes:
Janek Warchoł janek.lilypond at gmail.com writes:
i've decided that instead of complaining about slowed development
process, i can do some bug-fixing instead.
2013/7/2 Keith OHara k-ohara5a5a at oco.net:
The problem seems to need text
Keith OHara k-ohara5...@oco.net writes:
The problem appeared when placing text in relation to other things, so try
\new Lyrics \lyricmode { a }
\new Lyrics \lyricmode { u }
LilyPond on Windows runs forever on that, depending on the text.
Two lines of Lyrics do not use the code that
Keith OHara k-ohara5...@oco.net writes:
Two lines of Lyrics do not use the code that does outside-staff placement,
so it was not my change that caused the problem. It must be the changes
to the implementation of Skylines for issue 3344.
Issue 3383 it was. Issue 3344 is a convert-ly rule
- Original Message -
From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Wednesday, July 10, 2013 5:47 PM
Subject: Re: whack-a-regression
Keith OHara k-ohara5...@oco.net writes:
Two lines of Lyrics do not use the code that does outside-staff
placement,
so
2013/7/2 Keith OHara k-ohara5...@oco.net:
Janek Warchoł janek.lilypond at gmail.com writes:
i've decided that instead of complaining about slowed development
process, i can do some bug-fixing instead.
You could experiment to understand better the situations that lead to the
out-of-memory
, and that we'll have real-time chat to answer each
other's questions. I'm _not_ going to do regression fixing alone,
because i consider this a waste of time due to my insufficient
programming skills.
cheers,
Janek
___
lilypond-devel mailing list
lilypond
Janek Warchoł janek.lilypond at gmail.com writes:
i've decided that instead of complaining about slowed development
process, i can do some bug-fixing instead.
You could experiment to understand better the situations that lead to the
out-of-memory crash under Windows --- issue 3432 and other
Keith OHara k-ohara5a5a at oco.net writes:
You could experiment to understand better the situations that lead to the
out-of-memory crash under Windows --- issue 3432 and other reports on bug-
lilypond yesterday. This makes version 2.17.21 useless on Windows.
Looking at the commits since
Keith OHara k-ohara5...@oco.net writes:
Keith OHara k-ohara5a5a at oco.net writes:
You could experiment to understand better the situations that lead to the
out-of-memory crash under Windows --- issue 3432 and other reports on bug-
lilypond yesterday. This makes version 2.17.21 useless on
In the NR, 5.1.7 Context layout order, LilyPond up to 2.17.9 used to produce
the correct output. After 2.17.11 it failed, and output the following error
messages:
Preprocessing graphical objects...
programming error: vertical alignment called before line breaking
continuing, cross fingers
Phil Holmes em...@philholmes.net writes:
In the NR, 5.1.7 Context layout order, LilyPond up to 2.17.9 used to
produce the correct output. After 2.17.11 it failed, and output the
following error messages:
Preprocessing graphical objects...
programming error: vertical alignment called before
Phil Holmes email at philholmes.net writes:
In the NR, 5.1.7 Context layout order, LilyPond up to 2.17.9 used to produce
the correct output. After 2.17.11 it failed, and output the following error
messages:
We get the old behavior if we ask ChordNames to stop trying to be a separate
LGTM
https://codereview.appspot.com/9709043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/9116043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Folks,
should all regressions be of type `critical' to make them more
pronounced in the tracker? Of course, I can always enter
label:Regression
in the search field...
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
- Original Message -
From: Werner LEMBERG w...@gnu.org
To: lilypond-devel@gnu.org
Sent: Tuesday, May 07, 2013 10:25 AM
Subject: regression tagging in tracker
Folks,
should all regressions be of type `critical' to make them more
pronounced in the tracker? Of course, I can always
I spotted this howler just below your change. (Plural noun as subject,
with is altered as the verb.)
Any chance of fixing this too? (If you don't like my wording, at least
change the is to are).
Cheers,
Ian
https://codereview.appspot.com/9116043/diff/1/input/regression/stencil-hacking.ly
Am 02.10.2012 23:24, schrieb Janek Warchoł:
Hi Marc,
On Sun, Sep 30, 2012 at 9:14 PM, Marc Hohl m...@hohlart.de wrote:
I got strange results with the regression tests, and studying the
CG more carefully, I spotted some differences:
http://lilypond.org/doc/v2.17/Documentation/contributor
Hi Marc,
On Sun, Sep 30, 2012 at 9:14 PM, Marc Hohl m...@hohlart.de wrote:
I got strange results with the regression tests, and studying the
CG more carefully, I spotted some differences:
http://lilypond.org/doc/v2.17/Documentation/contributor/regtest-comparison
says that you should do
Hello list,
I got strange results with the regression tests, and studying the
CG more carefully, I spotted some differences:
http://lilypond.org/doc/v2.17/Documentation/contributor/regtest-comparison
says that you should do
make test-baseline make check
[changed the code; if needed 'make
On 28/07/2012 07:32, David Kastrup wrote:
Reinhold Kainhofer reinh...@kainhofer.com writes:
The text spanner implemented in scheme (which is also used as a basis
for David's measure counter engraver) seems to work fine in the regtest,
but apparently it is not quote-proof.
In particular, if
Reinhold Kainhofer reinh...@kainhofer.com writes:
On 28/07/2012 07:32, David Kastrup wrote:
Reinhold Kainhofer reinh...@kainhofer.com writes:
The text spanner implemented in scheme (which is also used as a basis
for David's measure counter engraver) seems to work fine in the regtest,
but
Reinhold Kainhofer reinh...@kainhofer.com writes:
The text spanner implemented in scheme (which is also used as a basis
for David's measure counter engraver) seems to work fine in the regtest,
but apparently it is not quote-proof.
In particular, if you try call \addQuote on some music that
The text spanner implemented in scheme (which is also used as a basis
for David's measure counter engraver) seems to work fine in the regtest,
but apparently it is not quote-proof.
In particular, if you try call \addQuote on some music that contains
\schemeTextSpannerStart or
Also if you want to give more details about your database, e.g., which SQL
implementation, how the tables are organised, and the code you tried, maybe
someone here can improve it.
On Jul 10, 2012 4:54 PM, Trevor Daniels t.dani...@treda.co.uk wrote:
Phil Holmes wrote Tuesday, July 10, 2012 12:03
Message -
From: Ramana Kumar
To: Trevor Daniels
Cc: Janek Warchol ; Devel ; Phil Holmes ; LilyPond User Group
Sent: Tuesday, July 10, 2012 6:36 PM
Subject: Re: Regression test rater
Also if you want to give more details about your database, e.g., which SQL
implementation, how
On Wed, Jul 11, 2012 at 6:57 PM, Phil Holmes m...@philholmes.net wrote:
This prompted me to check my indexing and it was mostly OK, but I found that
adding an index on RateUsername improves the speed of this query by a factor
of about 4. I think we're back to pretty much OK now.
Yeah,
- Original Message -
From: Phil Holmes m...@philholmes.net
To: Janek Warchol janek.lilyp...@gmail.com
Cc: Devel lilypond-devel@gnu.org; LilyPond User Group
lilypond-u...@gnu.org
Sent: Monday, July 09, 2012 5:45 PM
Subject: Re: Regression test rater
- Original Message -
From
Phil Holmes wrote Tuesday, July 10, 2012 12:03 PM
Kind-of fixed. The way the files are presented is aimed at ensuring no-one
rates a regtest more than once, and that they get the least-rated files
presented to them in a random order. The only way I seem to be able to get
this to work is
On Sat, Jun 30, 2012 at 3:33 PM, Phil Holmes em...@philholmes.net wrote:
First of all, thanks to those who have spent time and energy rating the
regression test at http://www.philholmes.net/lilypond/regtests/ - we're very
close to having a rating for all the tests.
[...]
LilyPond Regression
- Original Message -
From: Janek Warchol janek.lilyp...@gmail.com
To: Phil Holmes em...@philholmes.net
Cc: LilyPond User Group lilypond-u...@gnu.org; Devel
lilypond-devel@gnu.org
Sent: Monday, July 09, 2012 5:09 PM
Subject: Re: Regression test rater
On Sat, Jun 30, 2012 at 3:33 PM
First of all, thanks to those who have spent time and energy rating the
regression test at http://www.philholmes.net/lilypond/regtests/ - we're very
close to having a rating for all the tests. I'd like to let you know that
I've updated the way it works to how it really should have been
On 3/20/12 9:08 PM, lilyp...@googlecode.com lilyp...@googlecode.com
wrote:
Updates:
Labels: -Patch-countdown Patch-push
Comment #11 on issue 2389 by ColinPKCampbell: Patch: Fix make error in
regression tests coming from midi2ly
http://code.google.com/p/lilypond/issues/detail?id=2389
Has anybody else seen a huge slow-down in building fonts? They
used to whiz by on my screen in a minute or so, but now it takes
about 10 minutes, and more to the point, it involves a massive
amount of disk activity. My core2quad desktop couldn't play an
mp3 file while building fonts with -j3 !
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: lilypond-devel@gnu.org
Sent: Wednesday, March 14, 2012 7:59 PM
Subject: font regression build regression
Has anybody else seen a huge slow-down in building fonts? They
used to whiz by on my screen in a minute
Hello,
On 14 March 2012 20:00, Phil Holmes m...@philholmes.net wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: lilypond-devel@gnu.org
Sent: Wednesday, March 14, 2012 7:59 PM
Subject: font regression build regression
Has anybody else seen a huge slow
On Wed, Mar 14, 2012 at 08:00:44PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: lilypond-devel@gnu.org
Sent: Wednesday, March 14, 2012 7:59 PM
Subject: font regression build regression
Has anybody else seen a huge slow-down
On Wed, Mar 14, 2012 at 9:28 PM, Graham Percival
gra...@percival-music.ca wrote:
On Wed, Mar 14, 2012 at 08:00:44PM -, Phil Holmes wrote:
Is this with a straight make ? I ran it yesterday and didn't see
a slowdown, and I always check the time it takes.
Yes, a straight make, after
http://codereview.appspot.com/5777053/diff/1/make/midi-rules.make
File make/midi-rules.make (right):
http://codereview.appspot.com/5777053/diff/1/make/midi-rules.make#newcode12
make/midi-rules.make:12: (echo '\header {'; for f in $(HEADER_FIELDS);
do echo $$f'='; cat $(outdir)/$*.$$f; echo '';
Description:
Fix make error in regression tests coming from midi2ly
I have been unable to complete make test-baseline because of errors in
the
files coming from midi2ly.py. I tracked the error to
make/midi-rules.make.
The change in this patch allows me to successfully complete make
test-baseline
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile
File input/regression/lilypond-book/GNUmakefile (right):
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode19
input/regression/lilypond-book/GNUmakefile:19
On 2012/02/07 20:05:49, Graham Percival wrote:
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile
File input/regression/lilypond-book/GNUmakefile (right):
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile
2012/1/26 Janek Warchoł janek.lilyp...@gmail.com
Hi,
i think the output of beam-shortened-lengths.ly doesn't look good, see
in current regtests
http://www.lilypond.org/doc/v2.15/input/regression/collated-files.html
. Am i missing something?
cheers,
Janek
Thanks, Janek.
I agree
, see
in current regtests
http://www.lilypond.org/doc/v2.15/input/regression/collated-files.html
. Am i missing something?
cheers,
Janek
AFAICS looks the same in 2.12, so not a regression. Which version is
better? What exactly is the problem?
I think this has been added as
http
Hi,
i think the output of beam-shortened-lengths.ly doesn't look good, see
in current regtests
http://www.lilypond.org/doc/v2.15/input/regression/collated-files.html
. Am i missing something?
cheers,
Janek
___
lilypond-devel mailing list
lilypond
Janek Warchol janek.lilyp...@gmail.com wrote in message
news:CANYDDppbpzXAeepYCZ24rpu+RVQm21gO9beMCw357jxj_w=g...@mail.gmail.com...
Hi,
i think the output of beam-shortened-lengths.ly doesn't look good, see
in current regtests
http://www.lilypond.org/doc/v2.15/input/regression/collated
Phil Holmes mail at philholmes.net writes:
i think the output of beam-shortened-lengths.ly doesn't look good
What exactly is the problem?
The self-description says the up-pointing stems should be shortened,
but they are not. We didn't see it in real music because the bug
depends on the
LGTM
http://codereview.appspot.com/5569045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Please review.
Description:
Run regression tests for lilypond-book (issue 2223).
Re-enable running the regtests in input/regression/lilypond-book.
Fix various typos, clarify what each input file tests for and
how the output should look, and fix the following problems
LGTM, please push directly to staging.
As a general rule, any spelling fixes like this can be pushed directly
(as long as they don't involve translations).
http://codereview.appspot.com/5561053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
spelling in input/regression/*.ly
accomodate - accommodate
adn - and
eigth - eighth
excercise - exercise
inbetween - between
occurence - occurrence
refered - referred
supressed - suppressed
Signed-off-by: Stefan Weil s...@weilnetz.de
Please review this at http://codereview.appspot.com/5561053
accomodate - accommodate
adn - and
eigth - eighth
excercise - exercise
inbetween - between
occurence - occurrence
refered - referred
supressed - suppressed
Signed-off-by: Stefan Weil s...@weilnetz.de
---
input/regression/backend-excercise.ly |2 +-
input/regression/markup-scheme.ly
- Original Message -
From: Aleksandr Andreev aleksandr.andr...@gmail.com
To: Carl Sorensen c_soren...@byu.edu
Cc: lilypond-devel@gnu.org
Sent: Wednesday, December 28, 2011 5:06 PM
Subject: Re: Regression tests don't run
Here's the contents of the relevant log file:
GNU LilyPond
To: Phil Holmes m...@philholmes.net
Cc: Carl Sorensen c_soren...@byu.edu; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 5:41 PM
Subject: Re: Regression tests don't run
Phil,
I ran it again this morning on the latest source from git pull, and I
get the same message
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Aleksandr Andreev aleksandr.andr...@gmail.com
Cc: Phil Holmes m...@philholmes.net; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 6:12 PM
Subject: Re: Regression tests don't run
On Thu, Dec 29, 2011
- Original Message -
From: Aleksandr Andreev aleksandr.andr...@gmail.com
To: Phil Holmes m...@philholmes.net
Cc: Carl Sorensen c_soren...@byu.edu; lilypond-devel@gnu.org
Sent: Thursday, December 29, 2011 5:41 PM
Subject: Re: Regression tests don't run
Phil,
I ran it again
On Thu, Dec 29, 2011 at 11:03:43AM -0700, Aleksandr Andreev wrote:
Aha. Some Googling reveals that:
Exit code 137: The job was killed because it exceeded the time limit.
Don't top-post.
Any ideas how to up the time limit?
Unless you have an incredibly under-powered computer (say, 10
years
Phil,
I ran it again this morning on the latest source from git pull, and I
get the same message. There is no notice in the relevant log file of
any failed files, so it doesn't appear to be a syntax error.
In fact, it looks like the relevant command runs, but for some reason
make test still
Graham Percival gra...@percival-music.ca writes:
On Thu, Dec 29, 2011 at 11:03:43AM -0700, Aleksandr Andreev wrote:
Aha. Some Googling reveals that:
Exit code 137: The job was killed because it exceeded the time limit.
Don't top-post.
Any ideas how to up the time limit?
Unless you have
Here's the contents of the relevant log file:
GNU LilyPond 2.15.24
Killed
ing ./snippet-map--1615808177
Processing 94/lily-32d78681
Processing 8d/lily-d2e2b327
Processing 29/lily-e0ac5d9b
Processing 89/lily-1efebec4
Processing 56/lily-44b4b5eb
Processing de/lily-7583ff9a
Processing
the
documentation) from scratch.
Now I'm trying to compile the source (just the source that came from
git pull, without any modifications). Configure and make work fine,
but make doc fails. Running make test reveals that the regression
tests fail.
Here's the results of make test:
Processing
/home/sasha/lilypond
project,
and to do that I wanted to build everything (including the
documentation) from scratch.
Now I'm trying to compile the source (just the source that came from
git pull, without any modifications). Configure and make work fine,
but make doc fails. Running make test reveals that the regression
On Sun, Dec 18, 2011 at 02:28:34PM -0500, Julien Rioux wrote:
On Sun, Dec 18, 2011 at 2:08 PM, gra...@percival-music.ca wrote:
LGTM, please send final patch for pushing directly to staging.
http://codereview.appspot.com/5490064/
Here here,
Thanks, finally pushed.
Cheers,
- Graham
LGTM, please send final patch for pushing directly to staging.
http://codereview.appspot.com/5490064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sun, Dec 18, 2011 at 2:08 PM, gra...@percival-music.ca wrote:
LGTM, please send final patch for pushing directly to staging.
http://codereview.appspot.com/5490064/
Here here,
Thanks,
Julien
0001-CG-Typos-in-Regression-tests-section.patch
Description: Binary data
0002-CG-Typos
Pushed to staging as 1294535b
http://codereview.appspot.com/5342042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Nov 17, 2011, at 5:46 AM, David Kastrup wrote:
Keith OHara k-ohara5...@oco.net writes:
Keith OHara k-ohara5a5a at oco.net writes:
Several of Mike's new regression tests suffer from issue 1723
http://code.google.com/p/lilypond/issues/detail?id=1723
We can apply the workaround
In make check the following difference popped up here:
inline: beam-quanting-overhang.png
This can't be related to the tested change (exclusively concerned with
music function arguments, something not relevant at all to the test as
far as I can see).
Anybody else seen this?
--
David Kastrup
David Kastrup d...@gnu.org writes:
In make check the following difference popped up here:
inline: beam-quanting-overhang.png
This can't be related to the tested change (exclusively concerned with
music function arguments, something not relevant at all to the test as
far as I can see).
David Kastrup dak at gnu.org writes:
In make check the following difference popped up here:
Anybody else seen this?
Several of Mike's new regression tests suffer from issue 1723
http://code.google.com/p/lilypond/issues/detail?id=1723
We can apply the workaround for issue 1723
Keith OHara k-ohara5a5a at oco.net writes:
Several of Mike's new regression tests suffer from issue 1723
http://code.google.com/p/lilypond/issues/detail?id=1723
We can apply the workaround for issue 1723 to these regression tests.
Added stemlets to work around the intermittency, and pushed
Keith OHara k-ohara5...@oco.net writes:
Keith OHara k-ohara5a5a at oco.net writes:
Several of Mike's new regression tests suffer from issue 1723
http://code.google.com/p/lilypond/issues/detail?id=1723
We can apply the workaround for issue 1723 to these regression tests.
Added stemlets
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304
scripts/build/output-distance.py:1304: if len (args) % 2 == 1:
why is there a
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304
scripts/build/output-distance.py:1304: if len (args) % 2 == 1:
On 2011/11/07
On 2011/11/07 09:15:04, dak wrote:
Uh, yes? See line 1313: the argument list consists of an arbitrary
number of _pairs_.
Right - it's comparing (baseline, check) pairs. I didn't introduce the
modulo, I just made it explicit which is more legible than relying on
Python's interpretation of 0
Only stylistic comments:
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8
scripts/build/output-distance.py:8: from cgi import
passes make and no reg test diffs.
james
http://codereview.appspot.com/5342042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
101 - 200 of 440 matches
Mail list logo
