Hi Malte,
thanks for review.
Currently I follow a different route: create a Slash-grob.
Once it is mature I'll publish a concurrent patch-set in a different
issue.
For now I'll set this one back to 'needs-work'.
However you spotted some valid points, which I'll likely have to take
into account
Here’s some test music:
\version "2.21.0"
\language "deutsch"
\relative {
%%% looks better than 1/1 IMHO:
\override Beam.details.slash-gradient = 3/4
%%% default = 1 good for most, but not for some short stems (m. 3, m.
6)
%\override Beam.details.slash-stem-part = 0.6
%%% has
another small remark
https://codereview.appspot.com/562550043/diff/564540043/scm/define-grobs.scm
File scm/define-grobs.scm (right):
https://codereview.appspot.com/562550043/diff/564540043/scm/define-grobs.scm#newcode409
scm/define-grobs.scm:409: (slash-gradient . (1 . 2))
On 2019/03/16
On 2019/03/16 20:42:12, Malte Meyn wrote:
It’s not that easy in some cases, see example code below.
That should be “example code above”.
https://codereview.appspot.com/562550043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
LGTM
https://codereview.appspot.com/562550043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2019/03/10 17:08:33, Valentin Villenave wrote:
On 2019/03/10 13:37:42, thomasmorley651 wrote:
> Oversights
Greetings Harm,
looks good; much better than the hack I had previously suggested about
#1333.
However, you’re using a somewhat similar approach (although much more
fine-tuned) by
On 2019/03/10 13:37:42, thomasmorley651 wrote:
Oversights
Greetings Harm,
looks good; much better than the hack I had previously suggested about
#1333. However, you’re using a somewhat similar approach (although much
more fine-tuned) by overriding the stencil rather than creating an
Reviewers: ,
Message:
Please review
Description:
Add a procedure to add slashes to Beams and straight Flags
Adds procedure slash-stencil to stencil.scm
Replaces add-stroke-straight from flag-styles.scm with slash-stencil.
Amends defs in grace-init.ly with slashedBeam.
Amends Beam.details.
