Hi all,
On Wed, Apr 3, 2013 at 12:57 AM, d...@gnu.org wrote:
On 2013/04/02 22:34:53, janek wrote:
This should not be an excuse for broken code, but i think that we
can accept patches that are iterations towards Ultimate Solution.
This one is an iteration away from a proper solution since it
Janek Warchoł janek.lilyp...@gmail.com writes:
Hmm. What about doing something constructive, then?
There is one big let's do things right patch that needs review.
Despite a lot of effort spent by its author on writing a detailed
description to attract reviewers, only one person cared to
David,
On Wed, Apr 3, 2013 at 12:15 PM, David Kastrup d...@gnu.org wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
Hmm. What about doing something constructive, then?
There is one big let's do things right patch that needs review.
Despite a lot of effort spent by its author on
Janek Warchoł janek.lilyp...@gmail.com writes:
I also believe that you deserved your vacation, and i'm sorry that you
didn't have more vacations during this year.
Actually, I also visited the lady in Zürich last year (don't know how
long she'll be around) for whose father my accordion had been
On Wed, Apr 3, 2013 at 7:23 PM, David Kastrup d...@gnu.org wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
I also believe that you deserved your vacation, and i'm sorry that you
didn't have more vacations during this year.
Actually, I also visited the lady in Zürich last year (don't
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix a
broken design than to patch it with red tape. However, if we only
accepted code changes that were implementing the Ultimate Solution, i'm
afraid that the development process would grind to
On 2013/04/02 22:34:53, janek wrote:
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix
a broken
design than to patch it with red tape.
It isn't patched. minimum-length is used in multiple
contexts/interfaces, and Mike's patch muddies
On 3 avr. 2013, at 01:57, d...@gnu.org wrote:
On 2013/04/02 22:34:53, janek wrote:
I'll risk joining the discussion.
I see valid points from both of you. I agree that it's better to fix
a broken
design than to patch it with red tape.
It isn't patched. minimum-length is used in
Reviewers: lemzwerg, dak, mike7,
Message:
On 2013/03/11 10:18:59, dak wrote:
On 2013/03/10 00:32:43, mike7 wrote:
Why is this override needed for the regtest? The other
overrides
are
obvious user-accessible overrides for triggering the tested
functionality.
But should
On 2013/03/17 07:10:23, MikeSol wrote:
On 2013/03/11 10:18:59, dak wrote:
There is no point in hiding the symptoms of a problem away. That
only
makes things even harder in future.
I don't think this is a problem blocking the current patch.
It is a problem making the current patch
On 17 mars 2013, at 10:19, d...@gnu.org wrote:
You don't fix your own work after it has been committed,
This is patently false. Please do not write e-mails like this to a public list
that can be read by future employers of mine that want to evaluate my integrity.
so why would
you fix
On 2013/03/10 00:32:43, mike7 wrote:
Why is this override needed for the regtest? The other overrides
are
obvious user-accessible overrides for triggering the tested
functionality.
But should _this_ override not be the default?
https://codereview.appspot.com/7453046/
Perhaps
On 2013/03/09 07:18:50, mike7 wrote:
On 8 mars 2013, at 14:10, mailto:d...@gnu.org wrote:
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly
File input/regression/minimum-length-end-line.ly (right):
On 9 mars 2013, at 09:51, d...@gnu.org wrote:
On 2013/03/09 07:18:50, mike7 wrote:
On 8 mars 2013, at 14:10, mailto:d...@gnu.org wrote:
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly
File input/regression/minimum-length-end-line.ly (right):
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly
File input/regression/minimum-length-end-line.ly (right):
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly#newcode10
input/regression/minimum-length-end-line.ly:10:
On 8 mars 2013, at 14:10, d...@gnu.org wrote:
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly
File input/regression/minimum-length-end-line.ly (right):
LGTM. Thanks for the good comment :-)
https://codereview.appspot.com/7453046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
17 matches
Mail list logo
