On 4/8/19, 1:59 PM, "thomasmorle...@gmail.com"
wrote:
On 2019/04/08 18:47:13, lilypond-pkx wrote:
> Are we sure all the reg tests are OK (see tracker for download link)?
> For example
> regression/chord-name-major7.ly
> This looks completely broken with
On 2019/04/08 18:47:13, lilypond-pkx wrote:
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
I had a look at the regtest-results, too. Though, I didn't check for
changed code
On 2019/04/08 18:47:13, lilypond-pkx wrote:
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
I had a look at the regtest-results, too. Though, I didn't check for
changed code
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
https://codereview.appspot.com/568650043/
___
lilypond-devel mailing list
On 2019/04/06 22:06:22, Carl wrote:
However, this will require more refactoring. I don't believe we
should hold off
on this patch until we can get that part of it done better. This
patch has
lanquished long enough. IMO we should just push it as-is and get it
in the code
base.
Agreed.
Thanks for the feedback! New patch set uploaded.
https://codereview.appspot.com/568650043/diff/572560043/Documentation/notation/chords.itely
File Documentation/notation/chords.itely (right):
https://codereview.appspot.com/568650043/diff/572560043/Documentation/notation/chords.itely#newcode472
On 4/2/19, 3:20 PM, "v.villen...@gmail.com" wrote:
Hi Carl,
I appreciate you taking the time to rework this patch, does it mean
you’re intending to shepherd Charles’ work until it gets merged?
Yes.
In addition to Paul’s comments which you’ve nicely addressed, I had a
few
Hi Carl,
I appreciate you taking the time to rework this patch, does it mean
you’re intending to shepherd Charles’ work until it gets merged?
In addition to Paul’s comments which you’ve nicely addressed, I had a
few additional ones below, on other aspects of Charles’ approach (and
taking into
