Re: Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

2012-08-29 Thread dak
http://codereview.appspot.com/6472056/diff/1/lily/fingering-column.cc File lily/fingering-column.cc (right): http://codereview.appspot.com/6472056/diff/1/lily/fingering-column.cc#newcode38 lily/fingering-column.cc:38: mapGrob *, bool shifted; It seems quite pointless to use a map here instead

Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

2012-08-27 Thread graham
http://codereview.appspot.com/6472056/diff/1/lily/fingering-column-engraver.cc File lily/fingering-column-engraver.cc (right): http://codereview.appspot.com/6472056/diff/1/lily/fingering-column-engraver.cc#newcode56 lily/fingering-column-engraver.cc:56: { I don't think that we shouldn't have a

Re: Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

2012-08-27 Thread graham
No, I'm wrong about that. astyle doesn't mind about the { as the only changes are removing trailing whitespace (could you fix emacs so it stops adding it?) and one line-break just before the }; on line 59 of lily/fingering-column.cc. http://codereview.appspot.com/6472056/