Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Phil Holmes
- Original Message - From: gra...@percival-music.ca To: philehol...@googlemail.com; julien.ri...@gmail.com; m...@philholmes.net Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Tuesday, December 20, 2011 7:19 PM Subject: Re: Directs output of texi2html to log files

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Graham Percival
On Wed, Dec 21, 2011 at 09:29:31AM -, Phil Holmes wrote: I'll hold on this one and look again once Julien's patch is pushed. As I said, it's almost inconceivable that there would be an error from texi2pdf causing the build to fail. I've seen half a dozen in the past month. (my fault, it

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Phil Holmes
output of texi2html to log files (GOP 9) (issue 5495092) On Wed, Dec 21, 2011 at 09:29:31AM -, Phil Holmes wrote: I'll hold on this one and look again once Julien's patch is pushed. As I said, it's almost inconceivable that there would be an error from texi2pdf causing the build to fail

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread graham
On 2011/12/19 20:53:49, Julien Rioux wrote: Oh, I don't mean to suggest to pull your patch. I don't know if mine survives a review, for example. At the moment, I can see that they conflict. But the changes you suggest in this patch are useful. If they would be applied to

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread julien . rioux
On 2011/12/20 19:19:51, Graham Percival wrote: Does stepmake/stepmake/texinfo-rules.make apply to translations? I thought translations only used make/doc-whatever-i18n. Since very recently, yes. I added texinfo in 9ac7a5aaff66f2bd19184c9a23bccd195323e193. Anyway, I'm slightly hesitant to

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread Graham Percival
On Tue, Dec 20, 2011 at 07:33:15PM +, julien.ri...@gmail.com wrote: On 2011/12/20 19:19:51, Graham Percival wrote: Does stepmake/stepmake/texinfo-rules.make apply to translations? I thought translations only used make/doc-whatever-i18n. Since very recently, yes. I added texinfo in

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread Julien Rioux
On Tue, Dec 20, 2011 at 8:39 PM, Graham Percival gra...@percival-music.ca wrote: oh, *that's* what the STEPMAKE_TEMPLATES line does! Cheers, - Graham Yes, and things started to make a lot more sense once I made that connection. At some point in the new year I'll try to document what I learned

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread Graham Percival
On Tue, Dec 20, 2011 at 08:41:10PM +0100, Julien Rioux wrote: Yes, and things started to make a lot more sense once I made that connection. At some point in the new year I'll try to document what I learned about stepmake. I trust that you've seen Documentation/contributor/build-notes.itexi ?

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-20 Thread Julien Rioux
On Tue, Dec 20, 2011 at 8:46 PM, Graham Percival gra...@percival-music.ca wrote: On Tue, Dec 20, 2011 at 08:41:10PM +0100, Julien Rioux wrote: Yes, and things started to make a lot more sense once I made that connection. At some point in the new year I'll try to document what I learned about

Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-19 Thread PhilEHolmes
Reviewers: Graham Percival, Message: Please review Description: Directs output of texi2html to log files (GOP 9) for translated docs. There is a slight gotcha with this change, that if there is an error in running texi2html, then the dev has to know to look at the relevant log file. However,

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-19 Thread julien . rioux
On 2011/12/19 16:37:10, PhilEHolmes wrote: Please review Hi Phil, I was just looking at the translated manuals recently, please see http://code.google.com/p/lilypond/issues/detail?id=2125 Among the suggested changes in issue 2125 is to remove all the TEXI2HTML calls in

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-19 Thread julien . rioux
Subject: Re: Directs output of texi2html to log files (GOP 9) (issue 5495092) On 2011/12/19 16:37:10, PhilEHolmes wrote: Please review Hi Phil, I was just looking at the translated manuals recently, please see http://code.google.com/p/lilypond/issues/detail?id=2125 Among the suggested

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-19 Thread Phil Holmes
- Original Message - From: julien.ri...@gmail.com To: philehol...@googlemail.com; gra...@percival-music.ca Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Monday, December 19, 2011 8:23 PM Subject: Re: Directs output of texi2html to log files (GOP 9) (issue 5495092