Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugi...@runbox.com)

2019-03-12 Thread john . mandereau
This looks good to me, except a phrasing nitpick. https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right):

Re: Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugi...@runbox.com)

2019-03-11 Thread fedelogy
I guess that most GNOME users nowadays use version 3, so we should use the gsettings command instead of GConf. https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right):

Doc: CG - Minor updates to 3.4.9 - Commit access (issue 566540043 by pkxgnugi...@runbox.com)

2019-03-09 Thread thomasmorley65
It's too long I had to follow those lines, thus I can't say anything to your changes. One nit: https://codereview.appspot.com/566540043/diff/566530044/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right):