On 2012/10/09 05:44:52, J_lowe wrote:
Are there too many 'subs' here?
No. This is the standard level 5 heading. See
http://www.lilypond.org/doc/v2.17/Documentation/contributor/sectioning-commands
I only mention it because the headings are bold
_italic_ which really jars on the eye when
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode3961
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode4087
On 2012/10/08 07:46:09, Keith wrote:
Documentation/notation/changing-defaults.itely:4087: -\tweak
#'control-points
#'((-2 . 3) (-1 . 3.1) (0 . 3.2) (1 . 2.4)) ( )
g2( ) f is the same as g2( f)
so any implication that the does something different might mislead.
They are, of course,
LGTM
https://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode3901
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode3961
On 2012/10/08 20:04:21, Graham Percival wrote:
LGTM
Thanks!
Documentation/notation/changing-defaults.itely:3901: @itemize
technically this would be better as an @enumerate a, but this isn't a
big deal.
Ah yes, I'd forgotten that. I'll change it in the next patch set,
since I have to
http://codereview.appspot.com/6561064/diff/17001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6561064/diff/17001/Documentation/notation/changing-defaults.itely#newcode3916
On 2012/10/07 03:14:31, david.nalesnik wrote:
This looks great to me. I like the reordering, and
I think the explanations are very clear.
I've tweaked the curves a little in the examples (do
what you like with my suggestions!),
Thanks. I've adopted them, but with just a little further
LGTM.
And thanks again for doing this!
-David
https://codereview.appspot.com/6561064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode3961
Trevor--
This looks great to me. I like the reordering, and I think the
explanations are very clear.
I've tweaked the curves a little in the examples (do what you like with
my suggestions!), but otherwise:
LGTM.
Maybe just dump the waste of time that was
\override 'control-points
http://codereview.appspot.com/6561064/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
Trevor--
Thank you so much for taking this on! I've been pecking at documenting
this for awhile, but got hung up on finding the perfect examples... What
you have is clearer than what I cam up with.
https://codereview.appspot.com/6561064/diff/1/Documentation/notation/changing-defaults.itely
14 matches
Mail list logo
