On 2012/11/24 06:22:43, dak wrote:
On 2012/11/23 23:51:13, Trevor Daniels wrote:
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
LGTM, can go on countdown or whatever.
https://codereview.appspot.com/6852052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely#newcode1918
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely#newcode1918
On 2012/11/23 23:51:13, Trevor Daniels wrote:
https://codereview.appspot.com/6852052/diff/14001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
On 2012/11/21 00:33:23, dak wrote:
LilyPond's primary expressions are musical items like notes,
...
Thanks David. Much better, although I have simplified it
further in my next upload. I'm happy with this now.
Trevor
http://codereview.appspot.com/6852052/
http://codereview.appspot.com/6852052/diff/7/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6852052/diff/7/Documentation/learning/tweaks.itely#newcode226
Documentation/learning/tweaks.itely:226: include it. For more details,
On 2012/11/20 19:08:46, dak wrote:
This may be a bit of bikeshedding here,
Yes.
but I'd suggest reversing the narrative
of the first paragraphs, like
I still think this amount of detail is not quite in
keeping with the tenor of the Learning Manual. At
this stage of learning there is a
On 2012/11/20 21:39:54, Trevor Daniels wrote:
On 2012/11/20 19:08:46, dak wrote:
but I'd suggest reversing the narrative
of the first paragraphs, like
I still think this amount of detail is not quite in
keeping with the tenor of the Learning Manual.
I am bad at keeping with the tenor
On 2012/11/20 23:57:36, dak wrote:
If you feel you can boil this down into something that is better
suited for putting the reader on the right track without exhausting
him, feel free to improve this, if necessary skimming over information
that is likely to cause more harm than good at this
Thanks for the review David. I'll post a modified patch shortly.
Trevor
http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6852052/diff/1006/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/6852052/diff/1006/Documentation/notation/input.itely#newcode2645
Documentation/notation/input.itely:2645: @cindex MIDI, instrument
lgtm
http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely#newcode221
Documentation/learning/tweaks.itely:221: @var{value}. This must
http://codereview.appspot.com/6852052/diff/1006/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6852052/diff/1006/Documentation/learning/tweaks.itely#newcode223
Documentation/learning/tweaks.itely:223: include it.
Keith
http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6852052/diff/1/Documentation/learning/tweaks.itely#newcode221
Documentation/learning/tweaks.itely:221: @var{value}. This must always
On 2012/11/14 23:16:17, dak wrote:
Ugh. I think it is hard enough to explain _why_ this works here that
we should
not even try.
Agreed. We should not include how or why things work in
a Reference Manual for _using_ LilyPond. It's sufficiently
long and complicated enough without ;)
Reviewers: ,
Message:
@James
I'm afraid this patch-set will give you conflicts
in changing-defaults with your patch-set 6742057,
but as you _expect_ to have lots of edits and go
through a few iterations of this I guess rebasing
it and resolving them (assuming this gets pushed
soonish) will not
Trevor,
On 14 November 2012 16:44, tdanielsmu...@googlemail.com wrote:
Reviewers: ,
Message:
@James
I'm afraid this patch-set will give you conflicts
in changing-defaults with your patch-set 6742057,
but as you _expect_ to have lots of edits and go
through a few iterations of this I
LGTM
http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (left):
http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely#oldcode170
Documentation/notation/vocal.itely:170:
I'm sort of sorry to see this
http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (left):
http://codereview.appspot.com/6852052/diff/1/Documentation/notation/vocal.itely#oldcode170
Documentation/notation/vocal.itely:170:
On 2012/11/14 21:53:23, benko.pal
20 matches
Mail list logo
