On 2011/01/25 00:20:29, Carl wrote:
On 2011/01/24 16:33:22, Graham Percival wrote:
Almost there.
Done, and new patch set uploaded.
Compiles fine; please push.
Cheers,
- Graham
http://codereview.appspot.com/4061043/
___
lilypond-devel mailing
On 2011/01/25 13:57:32, Graham Percival wrote:
Pushed.
cb03a19174fd9245008176716742e1a2eb3a0b93
Thanks,
Carl
http://codereview.appspot.com/4061043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Carl, having struggled myself trying to smooth the transition to the new
spacing with a snippet(s), I appreciate the simplicity of this solution.
It looks good to me.
Having text in CHANGES seems important.
A little sugar would help the medicine go down; if spin is not your
style, one of the
On 1/24/11 9:33 AM, percival.music...@gmail.com
percival.music...@gmail.com wrote:
Almost there.
http://codereview.appspot.com/4061043/diff/19001/Documentation/snippets/new/ly
rics-old-spacing-settings.ly
File Documentation/snippets/new/lyrics-old-spacing-settings.ly (right):
On 2011/01/24 16:33:22, Graham Percival wrote:
Almost there.
Could you run makelsr and then don't forget to do
git add Documentation/snippets/*.ly
Done, and new patch set uploaded.
Thanks,
Carl
http://codereview.appspot.com/4061043/
___
LGTM
I think the templates would be improved with
system-system-spacing #'basic-distance = #20
added to \paper. Otherwise the bass lyrics will be too
close to the soprano lyrics on the following system.
Trevor
http://codereview.appspot.com/4061043/
I think we have a convert-ly problem.
http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/lyrics-old-spacing-settings.ly
File Documentation/snippets/new/lyrics-old-spacing-settings.ly (right):
http://codereview.appspot.com/4061043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/4061043/diff/1/Documentation/changes.tely#newcode70
Documentation/changes.tely:70: Lyrics above a staff must have their
@code{staff-affinity} set to
I
On 2011/01/23 09:09:09, Trevor Daniels wrote:
I think the templates would be improved with
system-system-spacing #'basic-distance = #20
added to \paper. Otherwise the bass lyrics will be too
close to the soprano lyrics on the following system.
Done. I also added top-system-spacing and
I've responded to the comments in detail below.
Graham, relative to your comments on issues 1483 and 1486, both are
addressed in this patch.
The templates now have the lyrics attached properly to the staves, as do
the examples in the NR. This takes care of 1483.
The templates also have
Reviewers: ,
Message:
Here is a potential patch for fixing the lyric spacing regressions.
It updates the documentation to clarify what is needed to make lyrics
behave as desired.
It also adds a snippet that demonstrates how to achieve the old spacing
behavior.
Please respond with any
11 matches
Mail list logo
