https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode29
scm/output-lib.scm:29: (define-public (grob::rhythmic-location grob)
The function is misnamed since
https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode29
scm/output-lib.scm:29: (define-public (grob::rhythmic-location grob)
On 2015/02/22 07:59:40, dak wrote:
The
LGTM, except for a couple minor things. Thanks for working on these
scheme functions.
https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode30
scm/output-lib.scm:30:
On 2015/02/18 20:43:51, david.nalesnik wrote:
it seems that a
drawback of using Scheme is losing the nice error messages that result
from
doing LY_ASSERT_SMOB.
False alarm.
https://codereview.appspot.com/197690044/
___
lilypond-devel mailing
On 2015/02/18 17:53:44, david.nalesnik wrote:
Please review. Thanks!
Can't this be done just as easily in Scheme?
https://codereview.appspot.com/197690044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2015/02/18 18:08:32, david.nalesnik wrote:
Putting it into Scheme will need to wait for Issue 4289 to make it to
master, since I'll be able to use ly:item-get-column here.
https://codereview.appspot.com/197690044/
___
lilypond-devel mailing list
On 2015/02/18 18:02:38, dak wrote:
On 2015/02/18 17:53:44, david.nalesnik wrote:
Please review. Thanks!
Can't this be done just as easily in Scheme?
Sure--that crossed my mind. The reason I went with C++ is so that it
would be documented prominently, but I could change it if that's not a
On 2015/02/18 18:07:19, dak wrote:
On 2015/02/18 18:05:17, david.nalesnik wrote:
On 2015/02/18 18:02:38, dak wrote:
On 2015/02/18 17:53:44, david.nalesnik wrote:
Please review. Thanks!
Can't this be done just as easily in Scheme?
Sure--that crossed my mind. The reason I went with
Reviewers: ,
Message:
Please review. Thanks!
Description:
Function to display the rhythmic location of a grob
A convenient way to return the musical position of a grob within
a score will be very helpful in debugging, among other uses.
This patch creates a function ly:grob-rhythmic-location
On 2015/02/18 18:05:17, david.nalesnik wrote:
On 2015/02/18 18:02:38, dak wrote:
On 2015/02/18 17:53:44, david.nalesnik wrote:
Please review. Thanks!
Can't this be done just as easily in Scheme?
Sure--that crossed my mind. The reason I went with C++ is so that it
would be
documented
On 2015/02/18 18:12:58, david.nalesnik wrote:
On 2015/02/18 18:08:32, david.nalesnik wrote:
Putting it into Scheme will need to wait for Issue 4289 to make it to
master,
since I'll be able to use ly:item-get-column here.
However, we lose the nice error reporting which happens when you do
On 2015/02/18 20:39:19, david.nalesnik wrote:
On 2015/02/18 18:12:58, david.nalesnik wrote:
On 2015/02/18 18:08:32, david.nalesnik wrote:
Putting it into Scheme will need to wait for Issue 4289 to make it
to master,
since I'll be able to use ly:item-get-column here.
However, we lose the
12 matches
Mail list logo
