Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread Marc Hohl
Am 27.02.2012 10:01, schrieb d...@gnu.org: On 2012/02/27 00:17:05, Carl wrote: Looks like a good solution. I think I would prefer the name excludeOpenStrings to ignoreOpenStrings. I think exclude is a better word for what is happening than ignore I am actually not all too happy with

Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread dak
On 2012/02/27 10:51:25, marc wrote: I hope I corrected everything accordingly, because I screwed up my local branch ... :-( That's quite improbable to do thoroughly with git. Try git reflog and see whether a useful copy is sitting among the given references.

Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread dak
Instead of dontTreatOpenStringsSpecially, something like omitOpenStrings or skipOpenStrings looks less like an active special action for open strings, and maybe normalOpenStrings or fingerOpenStrings or fretOpenStrings suggests that the point is to include them in the normal calculations instead

Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread Marc Hohl
Am 27.02.2012 12:09, schrieb d...@gnu.org: On 2012/02/27 10:51:25, marc wrote: I hope I corrected everything accordingly, because I screwed up my local branch ... :-( That's quite improbable to do thoroughly with git. Well, I did it. I don't know what happened, but most probably a git

Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread Marc Hohl
Am 27.02.2012 12:19, schrieb d...@gnu.org: Instead of dontTreatOpenStringsSpecially, something like omitOpenStrings Well, omitOpenStrings sounds quite good IMHO. Before I do another patch, any suggestions/corrections from other string-addicted people ;-) ? Regards, Marc or skipOpenStrings

Re: Handling of open strings in tablature (issue 5695058)

2012-02-27 Thread David Kastrup
Marc Hohl m...@hohlart.de writes: Am 27.02.2012 12:09, schrieb d...@gnu.org: On 2012/02/27 10:51:25, marc wrote: I hope I corrected everything accordingly, because I screwed up my local branch ... :-( That's quite improbable to do thoroughly with git. Well, I did it. I don't know what

Re: Handling of open strings in tablature (issue 5695058)

2012-02-26 Thread Carl . D . Sorensen
Looks like a good solution. I think I would prefer the name excludeOpenStrings to ignoreOpenStrings. I think exclude is a better word for what is happening than ignore Thanks, Carl http://codereview.appspot.com/5695058/ ___ lilypond-devel mailing

Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread julien . rioux
1 line adds whitespace errors. That's all. Regards, Julien http://codereview.appspot.com/5695058/diff/6001/input/regression/tablature-open-string-handling.ly File input/regression/tablature-open-string-handling.ly (right):

Re: Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread David Kastrup
julien.ri...@gmail.com writes: 1 line adds whitespace errors. That's all. Regards, Julien The scripts lilypond-extra/patches/accept-patch.py and lilypond-extra/patches/reject-patch.py are known to you? They take an issue number and a text as argument. -- David Kastrup

Re: Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread Marc Hohl
Am 26.02.2012 07:07, schrieb julien.ri...@gmail.com: 1 line adds whitespace errors. That's all. Regards, Julien http://codereview.appspot.com/5695058/diff/6001/input/regression/tablature-open-string-handling.ly File input/regression/tablature-open-string-handling.ly (right):