Re: Improve HTML output of regression tests (issue 5342042)

2011-11-28 Thread adam . spiers
Pushed to staging as 1294535b http://codereview.appspot.com/5342042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-07 Thread graham
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304 scripts/build/output-distance.py:1304: if len (args) % 2 == 1: why is there a

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-07 Thread dak
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304 scripts/build/output-distance.py:1304: if len (args) % 2 == 1: On 2011/11/07

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-07 Thread adam . spiers
On 2011/11/07 09:15:04, dak wrote: Uh, yes? See line 1313: the argument list consists of an arbitrary number of _pairs_. Right - it's comparing (baseline, check) pairs. I didn't introduce the modulo, I just made it explicit which is more legible than relying on Python's interpretation of 0

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-07 Thread julien . rioux
Only stylistic comments: http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8 scripts/build/output-distance.py:8: from cgi import

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-07 Thread pkx166h
passes make and no reg test diffs. james http://codereview.appspot.com/5342042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve HTML output of regression tests (issue 5342042)

2011-11-04 Thread pkx166h
passes make and no reg test diffs. James http://codereview.appspot.com/5342042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel