https://codereview.appspot.com/557500043/ este numero de telefono y el
5574447028 me robaron todas mis cuentas
.cbraun811...@gmail.com,ashkar26@gmail,ashka...@gmail.com,supermanromero1...@gmail.com,
https://codereview.appspot.com/557500043/
https://codereview.appspot.com/557500043/
On 2020/02/26 21:56:46, dak wrote:
> On 2020/02/26 21:50:05, lemzwerg wrote:
> > > How about
> > > * beamed-stem-french-adjustment
> > > * french-beaming-stem-adjustment
> > > …?
> >
> > I like the second one.
>
> I'd be fine with it.
+1
https://codereview.appspot.com/557500043/
On 2020/02/26 21:50:05, lemzwerg wrote:
> > How about
> > * beamed-stem-french-adjustment
> > * french-beaming-stem-adjustment
> > …?
>
> I like the second one.
I'd be fine with it.
https://codereview.appspot.com/557500043/
> How about
> * beamed-stem-french-adjustment
> * french-beaming-stem-adjustment
> …?
I like the second one.
https://codereview.appspot.com/557500043/
> I'll really make myself unpopular here, […]
No, that's what discussions are for.
I probably shouldn't have uploaded a second patch set before the
property
name had finally been decided upon, but I was kind of urged by the
countdown
starting and didn't have the time for working on it earlier.
https://codereview.appspot.com/557500043/diff/563610046/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
https://codereview.appspot.com/557500043/diff/563610046/scm/define-grob-properties.scm#newcode1374
scm/define-grob-properties.scm:1374: amount of space in case of
On 2020/02/26 21:14:54, Be-3 wrote:
> On 2020/02/26 21:04:59, Be-3 wrote:
> > Changes applied following the reviewers' comments
>
> All of the recommendations applied:
>
> Rename stru Beam_stem_length -> Beam_stem_end (Han-Wen)
> Rename property french-correction -> stem-end-shorten
On 2020/02/26 21:04:59, Be-3 wrote:
> Changes applied following the reviewers' comments
All of the recommendations applied:
Rename stru Beam_stem_length -> Beam_stem_end (Han-Wen)
Rename property french-correction -> stem-end-shorten (Han-Wen)
Make property stem-end-shorten
> It sounds like actual manipulation of that property
> by the user would interfere with the implementation
> of french-beaming. So maybe just mark/sort it as an
> internal property and only regtest french-beaming as
> such?
If this is the intention, yes.
On 2020/02/25 13:33:13, lemzwerg wrote:
> > > Please add one or more test cases for your 'french-correction'
property.
> >
> > What specific French beaming examples are you missing?
>
> I was probably unclear. What I want is an example that shows how the
> 'french-correction' *property* changes
On 2020/02/25 13:33:13, lemzwerg wrote:
> If you really wanted 'i.e.' without a trailing comma, it would be
necessary to
> write 'i.e.@:'. Otherwise makeinfo inserts two spaces in the '.info'
file
> because we don't use '@frenchspacing' in the English docs.
Thanks for the valuable explanation.
> > s/i.e./i.e.,/
>
> Ah, then I suppose the changes.tely language is American English...
Yes, for the whole documentation we use (more or less) American spelling
rules. If you really wanted 'i.e.' without a trailing comma, it would
be necessary to write 'i.e.@:'. Otherwise makeinfo inserts
On 2020/02/25 13:06:31, Be-3 wrote:
> On 2020/02/24 06:44:39, hanwenn wrote:
> > One thing to consider: since the mechanics are now very predictable,
maybe we
> > can name the property in after its mechanics? ie. french-correction
->
> > stem-end-shorten or something?
>
> After having thought
Proposed changes applied to my local branch (most of them), see
comments.
Ta,
Torsten
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely
File Documentation/changes.tely (right):
On 2020/02/24 06:44:39, hanwenn wrote:
> One thing to consider: since the mechanics are now very predictable,
maybe we
> can name the property in after its mechanics? ie. french-correction ->
> stem-end-shorten or something?
After having thought about it for quite a while I'm not too happy with
LGTM
special thanks for your well reasoned and extensive commit message.
One thing to consider: since the mechanics are now very predictable,
maybe we can name the property in after its mechanics? ie.
french-correction -> stem-end-shorten or something?
LGTM. Very nice, thanks! Some minor nits only.
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/557500043/diff/551490044/Documentation/changes.tely#newcode67
Reviewers: ,
Message:
Deep breath---please review.
Ta, Torsten
Description:
Issue 5788: New French Beamimg Approach
Completely new approach to French beaming.
This will automatically tackle all kinds of not-yet resolved positioning
problems caused by the current French beaming implementation.
19 matches
Mail list logo
