I like it.
http://codereview.appspot.com/6635050/diff/15002/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6635050/diff/15002/Documentation/notation/changing-defaults.itely#newcode4202
On 2012/10/09 21:08:47, janek wrote:
I'm just skimming the discussion (the patch is big and non-trivial, so
i will have problems reviewing it), but i spotted one interesting
sentence...
On Tue, Oct 9, 2012 at 10:38 AM, mailto:d...@gnu.org wrote:
We can get rid of a _lot_ of #' style
Reviewers: lemzwerg,
Message:
On 2012/10/09 05:04:50, lemzwerg wrote:
LGTM, without testing, and without really understanding the change.
However,
simplifications and generalizations are always a good thing.
d...@gnu.org: Tuesday, October 09, 2012 8:36 AM
On 2012/10/09 05:04:50, lemzwerg wrote:
http://codereview.appspot.com/6635050/diff/1/Documentation/de/notation/pitches.itely#newcode1529
Documentation/de/notation/pitches.itely:1529: \accidentalStyle
StaffGroup.voice
This looks strange. I
On 2012/10/09 08:14:55, t.daniels_treda.co.uk wrote:
d...@gnu.org: Tuesday, October 09, 2012 8:36 AM
so I'd crank open another convert-ly rule to turn those into
\accidentalStyle piano-cautionary
as well. Which makes for worse backward-compatibility of scores.
What do people prefer to
d...@gnu.org: Tuesday, October 09, 2012 9:38 AM
Here is the rub: what we are currently talking about is a choice between
several convert-ly rules that all lead to valid programs after this
change.
Whether you write
\override TextSpanner #'(bound-details left stencil-align-dir-y) = #-2
On 2012/10/09 10:03:59, t.daniels_treda.co.uk wrote:
d...@gnu.org: Tuesday, October 09, 2012 9:38 AM
I think I'll prepare a radical convert-ly-only patch on top of this
patch series that demonstrates what now valid syntax we _could_ be
using/advertising as input if we wanted to.
It's
\accidentalStyle StaffGroup.voice
This is my preferred form. However, some time ago we decided (more or
less) to say e.g.
\clef bass
In the light of your syntax improvements/simplifications, shouldn't we
start to use
\clef bass
instead, making data in double quotes really user strings
Werner LEMBERG w...@gnu.org writes:
\accidentalStyle StaffGroup.voice
This is my preferred form. However, some time ago we decided (more or
less) to say e.g.
\clef bass
In the light of your syntax improvements/simplifications, shouldn't we
start to use
\clef bass
instead, making
LGTM.
http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly#newcode105
ly/music-functions-init.ly:105: (ly:input-warning location (_ not a
spanner name,
http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly#newcode105
ly/music-functions-init.ly:105: (ly:input-warning location (_ not a
spanner name, `~a') name)
I'm just skimming the discussion (the patch is big and non-trivial, so
i will have problems reviewing it), but i spotted one interesting
sentence...
On Tue, Oct 9, 2012 at 10:38 AM, d...@gnu.org wrote:
We can get rid of a _lot_ of #' style thingies with this patch series.
A!!! So this is
Werner LEMBERG wrote
\accidentalStyle StaffGroup.voice
This is my preferred form. However, some time ago we decided (more or
less) to say e.g.
\clef bass
In the light of your syntax improvements/simplifications, shouldn't we
start to use
\clef bass
instead, making data in
LGTM, without testing, and without really understanding the change.
However, simplifications and generalizations are always a good thing.
http://codereview.appspot.com/6635050/diff/1/Documentation/de/notation/pitches.itely
File Documentation/de/notation/pitches.itely (right):
14 matches
Mail list logo