Re: Cleaned up style (issue 4951062)

2011-09-10 Thread lemzwerg
Simply have a look how other note heads are implemented, and watch how the shape changes for different design sizes. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Cleaned up style (issue 4951062)

2011-09-10 Thread lemzwerg
http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaned up style (issue 4951062)

2011-09-10 Thread reinhold . kainhofer
Can we please have a more meaningful issue title than Cleaned up style, which does not tell me at all what this review is about when I get all those notifications mails. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list

Re: Cleaned up style (issue 4951062)

2011-09-10 Thread pkx166h
I created https://code.google.com/p/lilypond/issues/detail?id=1873 and called it 'Added glyphs for Kievan Notation' so when this issue is changed can we use the same title? http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list

Re: Cleaned up style (issue 4951062)

2011-09-09 Thread lemzwerg
http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf File mf/feta-kievan.mf (right): http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode78 mf/feta-kievan.mf:78: fill z1{dir -6.9} .. z2 .. z3 z3 .. z4 .. z5 z5 -- z6 z6 .. z7 .. z8 z8{left} .. z9 z9 .. z10 ...

Re: Cleaned up style (issue 4951062)

2011-09-09 Thread aleksandr . andreev
Changed code style and glyph names based on the comments of Carl and lemzwerg. Carl, is it OK that the group name is kievan, so now we have glyphs like kievan.s1kievan? Is this how it should be? Re: you can see that all coordinates rely on meta-parameters which control the appearance I'm new

Re: Cleaned up style (issue 4951062)

2011-09-08 Thread pkx166h
Added to Tracker: https://code.google.com/p/lilypond/issues/detail?id=1873 http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaned up style (issue 4951062)

2011-09-08 Thread Carl . D . Sorensen
Looks very promising. A couple of style comments. I think the naming should be revised to include Kievan as part of the name, at least for the notes like s1. Thanks, Carl http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf File mf/feta-kievan.mf (right):

Re: Cleaned up style (issue 4951062)

2011-09-07 Thread aleksandr . andreev
Cleaned up code style based on comments from janek. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel