, August 18, 2012 10:03 PM
Subject: Re: Removes popen3 deprecated warning (issue 6471043)
Graham Percival wrote Saturday, August 18, 2012 7:34 PM
On Sat, Aug 18, 2012 at 05:23:17PM +0100, Phil Holmes wrote:
Between 2.15.18 and 2.15.21
Given that 2.15.21 was released on 2011 Dec 6, why were we
Phil Holmes
See my other note - if you have stashes of your installs, have a look at
C:\Program Files (x86)\LilyPond\usr\lib\python2.4\config\config.c
You'll see that at 15.18 there's no mention of msvcrt but in 15.21 it's
there. So something (but I don't know what) caused us to start
Reviewers: Graham Percival, John Mandereau,
Message:
Please review
Description:
I tested this on windows by adding a call to Popen (just opening
notepad) at the start of lilypond-book. This is why we need the
conditional test for fds-close - windows does not allow this to be True
when used
IIRC, the problem was not the Popen wouldn't be working on Windows.
Rather, our GUB installer somehow does not include the msvcrt python
module in its python build, which is needed on Windows to provide the
Popen call. So, running lilypond-book fromself-compiled binaries has
always been working,
Hmm. I'm not really qualified to comment on python+windows+GUB stuff,
but are you certain that this won't re-open
http://code.google.com/p/lilypond/issues/detail?id=1933
?
http://codereview.appspot.com/6471043/
___
lilypond-devel mailing list
- Original Message -
From: reinhold.kainho...@gmail.com
To: philehol...@googlemail.com; gra...@percival-music.ca;
john.mander...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Saturday, August 18, 2012 3:12 PM
Subject: Re: Removes popen3 deprecated
- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; john.mander...@gmail.com;
reinhold.kainho...@gmail.com
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Saturday, August 18, 2012 3:23 PM
Subject: Re: Removes popen3 deprecated
On Sat, Aug 18, 2012 at 03:31:06PM +0100, Phil Holmes wrote:
My understanding of this problem was that it appeared that Popen (at
some point in the past) would not work with our delivered Python (as
created by Gub). I also believed that the fix to 1933 also probably
removed this limitation.
:39 PM
Subject: Re: Removes popen3 deprecated warning (issue 6471043)
On Sat, Aug 18, 2012 at 03:31:06PM +0100, Phil Holmes wrote:
My understanding of this problem was that it appeared that Popen (at
some point in the past) would not work with our delivered Python (as
created by Gub). I also
:13 PM
Subject: Re: Removes popen3 deprecated warning (issue 6471043)
So we have fixed it. You want I should find out when?
Between 2.15.18 and 2.15.21
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org
Sent: Saturday, August 18, 2012 5:23 PM
Subject: Re: Removes popen3 deprecated warning (issue 6471043)
- Original Message -
From: Phil Holmes m...@philholmes.net
To: Graham Percival gra...@percival-music.ca
Cc: philehol...@googlemail.com; john.mander...@gmail.com;
reinhold.kainho
On Sat, Aug 18, 2012 at 05:23:17PM +0100, Phil Holmes wrote:
- Original Message - From: Phil Holmes
m...@philholmes.net
To: Graham Percival gra...@percival-music.ca
Cc: philehol...@googlemail.com; john.mander...@gmail.com;
So we have fixed it. You want I should find out when?
Graham Percival wrote Saturday, August 18, 2012 7:34 PM
On Sat, Aug 18, 2012 at 05:23:17PM +0100, Phil Holmes wrote:
Between 2.15.18 and 2.15.21
Given that 2.15.21 was released on 2011 Dec 6, why were we working
on issue 1933 on 2012 Jan 12 ? was it just a misunderstanding
about which
Trevor Daniels wrote Saturday, August 18, 2012 10:03 PM
I don't know what Phil thinks was fixed between 2.15.18 and 2.15.21,
but I do suspect the symptoms of the problem or problems changed
from release to release, and may even depend on the Windows setup.
I've just turned up an email from
14 matches
Mail list logo
