of not remaking html files (issue 5498093)
Checking the file timestamps will be a good thing. It might be better to
just replace the whole www_post script by make rules, but in the current
implementation this is a good improvement.
Just a style thing, in general I notice that you use function(arg)
while
Sent: Tuesday, January 10, 2012 1:34 PM
Subject: Re: Sketch of not remaking html files (issue 5498093)
Checking the file timestamps will be a good thing. It might be better to
just replace the whole www_post script by make rules, but in the current
implementation this is a good improvement
Checking the file timestamps will be a good thing. It might be better to
just replace the whole www_post script by make rules, but in the current
implementation this is a good improvement.
Just a style thing, in general I notice that you use function(arg)
while the rest of python source code in
03, 2012 10:39 AM
Subject: Re: Sketch of not remaking html files (issue 5498093)
New patch uploaded. Commented-out lines deleted. Testing if directory
exists before mkdir rather than try: block - it's simpler and should be no
problem on a single-user system. Other comments taken into account
LGTM
http://codereview.appspot.com/5498093/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; perciv...@gmail.com
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Monday, January 02, 2012 9:41 PM
Subject: Re: Sketch of not remaking html files (issue 5498093)
a few minor
- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; perciv...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Monday, January 02, 2012 9:41 PM
Subject: Re: Sketch of not remaking html files (issue 5498093)
a few minor
a few minor quibbles; I'm on a ferry right now so I can't test a full
doc build.
http://codereview.appspot.com/5498093/diff/1/GNUmakefile.in
File GNUmakefile.in (right):
http://codereview.appspot.com/5498093/diff/1/GNUmakefile.in#newcode125
GNUmakefile.in:125: # find $(outdir) -name '*-root' |
Reviewers: percivall,
Message:
Please review
Description:
Should probably have associated this with
http://code.google.com/p/lilypond/issues/detail?id=2028. It's an
attempt to stop make doc recreating the whole of
build/out-www/offline-root/ every time it's run, whether any of the
files there
