On 2012/12/22 16:11:10, mike7 wrote:
On 22 déc. 2012, at 07:43, mailto:k-ohara5...@oco.net wrote:
https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc#newcode62
lily/axis-group-interface.cc:62: return SCM_BOOL_T;
Now the whole note-column is marked cross-staff if
I'm away for a few days.
https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc
File lily/pointer-group-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc#newcode74
lily/pointer-group-interface.cc:74: //
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc#newcode194
lily/side-position-interface.cc:194: common[ax] =
common_refpoint_of_array
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc#newcode151
lily/side-position-interface.cc:151: // Commented out because of cross
On 14 mars 2013, at 06:44, m...@mikesolomon.org wrote:
On 14 mars 2013, at 06:42, k-ohara5...@oco.net wrote:
issue 3242
https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
issue 3242
https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc#newcode902
lily/axis-group-interface.cc:902: Skyline_pair skylines
On 14 mars 2013, at 06:42, k-ohara5...@oco.net wrote:
issue 3242
https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/axis-group-interface.cc#newcode902
https://codereview.appspot.com/6827072/diff/38003/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/multi-measure-rest.cc#newcode123
lily/multi-measure-rest.cc:123: Spanner *sp = dynamic_castSpanner *
(me);
The compiler
On 19 févr. 2013, at 20:44, d...@gnu.org wrote:
https://codereview.appspot.com/6827072/diff/38003/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/multi-measure-rest.cc#newcode123
lily/multi-measure-rest.cc:123:
https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/6827072/diff/38003/scm/output-lib.scm#newcode54
scm/output-lib.scm:54: (define-public (non-event-cause grob)
Mike, this function is total crap. What is it
The changes to side-position-interface.cc are more extensive than I am
willing to figure out. Good luck.
https://codereview.appspot.com/6827072/diff/38003/lily/box-quarantine.cc
File lily/box-quarantine.cc (right):
On 22 déc. 2012, at 07:43, k-ohara5...@oco.net wrote:
https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc#newcode62
On 2012/12/17 10:44:23, mike7 wrote:
Fixed in the most recent patch-set. It is because
Axis_group_interface::generic_bound_extent did not recurse into the
elements
list of cross-staff grobs implementing axis-group-interface.
I haven't tried this yet, but I notice a lot of other places
On 22 déc. 2012, at 07:43, k-ohara5...@oco.net wrote:
https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc#newcode845
lily/axis-group-interface.cc:845: // really depend on position of the
cross-staff grobs that lie between them.
An old comment, but is it
On 2012/12/22 06:50:46, mike7 wrote:
It is cyclical for cross staff grobs in general. As staves spread
apart
vertically, cross-staff grobs' shapes change, which changes potential
positioning of grobs above/below them, which changes staff spacing,
which
changes the shape of cross staff
On 22 déc. 2012, at 08:40, k-ohara5...@oco.net wrote:
On 2012/12/22 06:50:46, mike7 wrote:
It is cyclical for cross staff grobs in general. As staves spread
apart
vertically, cross-staff grobs' shapes change, which changes potential
positioning of grobs above/below them, which changes
On 17 déc. 2012, at 05:02, k-ohara5...@oco.net wrote:
It doesn't like it when I end hairpins on note columns with stems
attached to cross-staff beams. I do not know why.
Fixed in the most recent patch-set. It is because
Axis_group_interface::generic_bound_extent did not recurse into the
It doesn't like it when I end hairpins on note columns with stems
attached to cross-staff beams. I do not know why.
\new PianoStaff
\new Staff = up
{\voiceOne e''8. fis''16 g''2 fis''4 }
{s8\ s s s\! s\ s s s\!}
\new Staff = down {
\clef bass \voiceTwo
\change Staff = up
On 30 nov. 2012, at 22:14, k-ohara5...@oco.net wrote:
Ugh...this is a really nasty cyclic dependency.
Then you could use as a test-case
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1778
which has no fingerings, no cyclic dependencies, but still shows the
problem of confused
On 5 déc. 2012, at 07:16, k-ohara5...@oco.net wrote:
https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc#newcode259
https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc#newcode259
lily/side-position-interface.cc:259: : vertical-skylines,
Now I see why
On 30 nov. 2012, at 07:25, k-ohara5...@oco.net wrote:
'finger-chords.ly' is still in disagreement with its texidoc (therefore
failing). You could adjust that regtest in light of the new defaults,
of course.
Better might be to make Fingering.add-stem-support = #only-if-beamed
the new
On Fri, 30 Nov 2012 01:37:48 -0800, m...@mikesolomon.org wrote:
Ugh...this is a really nasty cyclic dependency.
There is sometimes a cyclic dependency message, but that is not the problem.
I'm pretty sure I used \stemUp to determine the stem directions and break this
dependency chain.
1)
On 30 nov. 2012, at 20:42, Keith OHara k-ohara5...@oco.net wrote:
On Fri, 30 Nov 2012 01:37:48 -0800, m...@mikesolomon.org wrote:
Ugh...this is a really nasty cyclic dependency.
There is sometimes a cyclic dependency message, but that is not the problem.
I'm pretty sure I used \stemUp
Ugh...this is a really nasty cyclic dependency.
Then you could use as a test-case
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1778
which has no fingerings, no cyclic dependencies, but still shows the
problem of confused beams.
https://codereview.appspot.com/6827072/
On 30 nov. 2012, at 22:14, k-ohara5...@oco.net wrote:
Ugh...this is a really nasty cyclic dependency.
Then you could use as a test-case
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1778
which has no fingerings, no cyclic dependencies, but still shows the
problem of confused
On 29 nov. 2012, at 03:23, k-ohara5...@oco.net wrote:
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc
File lily/box-quarantine.cc (right):
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69
lily/box-quarantine.cc:69: int mid =
On 2012/11/29 08:28:31, mike7 wrote:
On 29 nov. 2012, at 03:23, mailto:k-ohara5...@oco.net wrote:
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69
lily/box-quarantine.cc:69: int mid = ii0.mid_;
assert ((double)(ii0.index - mid) = 0.0)
it is possible,
It was Box_quarantine that seemed a confusing name. (Why 'quarantine'?
Is there something special about 40 boxes?) I take back my suggestion.
http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc
File lily/box-quarantine.cc (right):
On 29 nov. 2012, at 10:24, k-ohara5...@oco.net wrote:
It was Box_quarantine that seemed a confusing name. (Why 'quarantine'?
Is there something special about 40 boxes?) I take back my suggestion.
http://codereview.appspot.com/6827072/diff/7041/lily/box-quarantine.cc
File
On 29 nov. 2012, at 10:13, k-ohara5...@oco.net wrote:
On 2012/11/29 08:28:31, mike7 wrote:
On 29 nov. 2012, at 03:23, mailto:k-ohara5...@oco.net wrote:
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69
lily/box-quarantine.cc:69: int mid = ii0.mid_;
'finger-chords.ly' is still in disagreement with its texidoc (therefore
failing). You could adjust that regtest in light of the new defaults,
of course.
Better might be to make Fingering.add-stem-support = #only-if-beamed
the new default. That is in better agreement with common practice.
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc
File lily/box-quarantine.cc (right):
http://codereview.appspot.com/6827072/diff/18003/lily/box-quarantine.cc#newcode69
lily/box-quarantine.cc:69: int mid = ii0.mid_;
assert ((double)(ii0.index - mid) = 0.0)
assert
On 19 nov. 2012, at 03:46, Keith OHara k-ohara5...@oco.net wrote:
On Sun, 18 Nov 2012 12:21:51 -0800, m...@mikesolomon.org
m...@mikesolomon.org wrote:
if (to_boolean (me-get_property (add-stem-support))
Stem::has_interface (e))
skyline.set_min_height (e-extent (common_y,
On 19 nov. 2012, at 03:46, Keith OHara k-ohara5...@oco.net wrote:
On Sun, 18 Nov 2012 12:21:51 -0800, m...@mikesolomon.org
m...@mikesolomon.org wrote:
if (to_boolean (me-get_property (add-stem-support))
Stem::has_interface (e))
skyline.set_min_height (e-extent (common_y,
On 18 nov. 2012, at 00:19, k-ohara5...@oco.net wrote:
On 2012/11/14 07:12:46, mike7 wrote:
lily/axis-group-interface.cc:403: Axis_group_interface::cross_staff
(SCM
smob)
For what situation? Which object that supports
axis-group-interface
(PianoPedalSpanner, DynamicLineSpanner)
On 18 nov. 2012, at 00:55, k-ohara5...@oco.net wrote:
I haven't gotten so far to see the main point, yet.
The main point is:
1) Unify all side spacing into one algorithm (this patch). In addition to
fixing several fingering bugs, this helps...
2) Eventually eliminate the translate axis
On Sun, 18 Nov 2012 08:10:49 -0800, m...@mikesolomon.org m...@mikesolomon.org
wrote:
On 18 nov. 2012, at 00:55, k-ohara5...@oco.net wrote:
http://codereview.appspot.com/6827072/diff/11002/lily/box-quarantine.cc#newcode70
lily/box-quarantine.cc:70: return fabs (ii0.index_ - mid) fabs
On 18 nov. 2012, at 21:06, Keith OHara k-ohara5...@oco.net wrote:
Try running beam-cross-staff-script.ly with my patch and setting
NoteColumn.cross-staff to ##f. You'll see that it triggers beam slope
calculations before vertical spacing is done on the staves because
NoteColumn,
On Sun, 18 Nov 2012 12:21:51 -0800, m...@mikesolomon.org m...@mikesolomon.org
wrote:
if (to_boolean (me-get_property (add-stem-support))
Stem::has_interface (e))
skyline.set_min_height (e-extent (common_y, _Y_AXIS)[dir]);
That's pseudo-code, but do you get the idea? Does that seem
On 2012/11/14 07:12:46, mike7 wrote:
lily/axis-group-interface.cc:403: Axis_group_interface::cross_staff
(SCM
smob)
For what situation? Which object that supports
axis-group-interface
(PianoPedalSpanner, DynamicLineSpanner) should be potentially
considered
a cross-staff object?
I haven't gotten so far to see the main point, yet.
http://codereview.appspot.com/6827072/diff/11002/lily/box-quarantine.cc
File lily/box-quarantine.cc (right):
http://codereview.appspot.com/6827072/diff/11002/lily/box-quarantine.cc#newcode24
lily/box-quarantine.cc:24:
On 2012/11/16 23:19:16, mike7 wrote:
On this subject, can someone explain to me how the bounding boxes for
the
regtest images are calculated? It seems like they have something to
with the
extents of non-cross-staff grobs. This makes certain regtests unduly
croppeed.
This is issue
On 14 nov. 2012, at 07:33, m...@mikesolomon.org wrote:
http://codereview.appspot.com/6827072/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
http://codereview.appspot.com/6827072/diff/1/lily/axis-group-interface.cc#newcode403
On 16 nov. 2012, at 21:32, m...@mikesolomon.org wrote:
On 14 nov. 2012, at 07:33, m...@mikesolomon.org wrote:
http://codereview.appspot.com/6827072/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
Re: Uses single algorithm for side-position spacing. (issue 6827072)
{\clef bass
g^3 a^52..-
r16 \\ r \\ r \\ r \\ eeses'16
\set fingeringOrientations = #'(right)
c e8-1-4 c^1 e^4 g,-3 b,-4 r
r2 }
Beautiful ugly test case. Even with current master it is atrocious. I've fixed
{\clef bass
g^3 a^52..-
r16 \\ r \\ r \\ r \\ eeses'16
\set fingeringOrientations = #'(right)
c e8-1-4 c^1 e^4 g,-3 b,-4 r
r2 }
http://codereview.appspot.com/6827072/diff/1/input/regression/dynamics-avoid-cross-staff-stem.ly
File input/regression/dynamics-avoid-cross-staff-stem.ly
http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc#newcode85
lily/side-position-interface.cc:85: Position next to support, taking
into account my
On 11 nov. 2012, at 14:50, d...@gnu.org wrote:
http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
http://codereview.appspot.com/6827072/diff/1/lily/side-position-interface.cc#newcode85
On 2012/11/11 15:26:48, mike7 wrote:
To be clear, I have no problem implementing a LilyPond documentation
and
commenting policy to move towards the establishment of an API. This
sounds like
a worthwhile yet difficult task. I would start talking about this
separately
from any one patch.
To make it short: a function needs documentation that tells its purpose
in the overall scheme of things (for what purpose is it used), its
outline (what does it do), its input and output.
A policy may describe how they are formatted and whether or not they
are used as Scheme documentation
On 11 nov. 2012, at 20:57, d...@gnu.org wrote:
To make it short: a function needs documentation that tells its purpose
in the overall scheme of things (for what purpose is it used), its
outline (what does it do), its input and output.
This sounds great.
A policy may describe how they are
52 matches
Mail list logo
