The function being patched is the pure-alternative to a
chained-offset-callback to the original Y-position
callback for rests (Rest::y_offset_callback).
I cannot follow the data between C and Scheme well enough to understand
what this function should return if it needs to bail out early.
The
http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc#newcode1328
lily/beam.cc:1328: return scm_from_double (0.0);
On 2012/04/25 06:21:29, Keith wrote:
It would seem we do not want an early return
On Tue, 24 Apr 2012 23:29:02 -0700, m...@mikesolomon.org wrote:
http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc#newcode1328
lily/beam.cc:1328: return scm_from_double (0.0);
On 2012/04/25
On 2012/04/15 20:06:55, Keith wrote:
On 2012/04/15 16:45:54, Keith wrote:
An improvement would be to round-to-larger
Done, along with other cleanup following the similar function
rest_collision_callback()
The cleanup would seem to break layout totally.
On 2012/04/21 16:10:09, dak wrote:
The cleanup would seem to break layout totally.
URL:http://permalink.gmane.org/gmane.comp.gnu.lilypond.general/71476
That's disappointing. The property 'previous_offset' sometimes has
values comparable to the page height. On the early returns I'll
wow, looks very nice and simple. I vote for pushing immediately, but
please wait for at least one other such vote (or a countdown).
http://codereview.appspot.com/6035053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2012/04/15 15:20:13, Graham Percival wrote:
wow, looks very nice and simple. I vote for pushing immediately, but
please
wait for at least one other such vote (or a countdown).
if max/min trigger, rint is applied to some rest_max_pos. It would
appear that it should rather apply only to
Reviewers: Graham Percival, dak,
Message:
On 2012/04/15 15:32:10, dak wrote:
if max/min trigger, rint is applied to some rest_max_pos. It would
appear that it should rather apply only to the calculated mean.
I want the final output to be an integral number of staff spaces, and
rest_max_pos
On 2012/04/15 16:45:54, Keith wrote:
An improvement would be to round-to-larger
Done, along with other cleanup following the similar function
rest_collision_callback()
http://codereview.appspot.com/6035053/
___
lilypond-devel mailing list
