Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-26 Thread pkx166h
Pavel, I pushed for you. author Pavel Roskin pro...@gnu.org Thu, 26 Jan 2012 21:17:13 + (21:17 +) committer James Lowe pkx1...@gmail.com Thu, 26 Jan 2012 21:19:06 + (21:19 +) commit 224246365f67fb44799fee4eb00e5debea5a35ec Can you close this issue here? James

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-18 Thread n . puttock
http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely#newcode67 Documentation/changes.tely:67: \override Flag #'color = #red g8 Please put the note on a new

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-18 Thread plroskin
On 2012/01/18 15:13:47, Neil Puttock wrote: http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely Done http://codereview.appspot.com/5540058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-17 Thread plroskin
Reviewers: , Message: The changelog doesn't mention the issue I have to deal with all the time, namely splitting Flag from Stem. If not that change, I would be able to use Lilypond 2.14.2 and the development version without convert-ly on the same sources. It should definitely be mentioned. An

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-17 Thread janek . lilypond
lgtm http://codereview.appspot.com/5540058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-16 Thread pkx166h
Well I'd say at the top. Many of the changes I have added in the last year have not necessarily gone in the correct 'order'; when someone mentioned that something needed to be added, it went in on the top of the pile. People do follow the changes, so the assumption is that it is current, if we

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-16 Thread plroskin
OK, my mistake, I didn't read the comments on top of changes.tely. The fixed patch is attached as patch set 2. http://codereview.appspot.com/5540058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-15 Thread Carl . D . Sorensen
Looks good to me, but I wonder about the location. Thanks, Carl http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely#newcode210 Documentation/changes.tely:210:

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

2012-01-15 Thread Carl . D . Sorensen
Looks good to me, but I wonder about the location. Thanks, Carl http://codereview.appspot.com/5540058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel