The changelog says
Don't update \version when no rule is applied.
That's what the existing -d --diff-version-update command does. If this
is intended to be the default behaviour now, then the command-line
option should be removed. I would rather keep convert-ly as-is (in
terms of this
On Mon, Oct 8, 2012 at 4:08 PM, gra...@percival-music.ca wrote:
The changelog says
Don't update \version when no rule is applied.
That's what the existing -d --diff-version-update command does. If this
is intended to be the default behaviour now, then the command-line
option should be
On 2012/10/08 20:08:20, Graham Percival wrote:
The changelog says
Don't update \version when no rule is applied.
That's what the existing -d --diff-version-update command does.
No, that's what the existing -d --diff-version-update is supposed to do.
The problem was that if the last
http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py
File scripts/convert-ly.py (right):
http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py#newcode231
scripts/convert-ly.py:231: ly.progress (_ (uProcessing `%s\'... ) %
infile_name, True)
is 'u' (here and in
On 2012/10/08 04:58:06, janek wrote:
http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py
File scripts/convert-ly.py (right):
http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py#newcode231
scripts/convert-ly.py:231: ly.progress (_ (uProcessing `%s\'... ) %
On Mon, Oct 8, 2012 at 7:05 AM, d...@gnu.org wrote:
I don't think we should be documenting the Python language, others do a
better job at that. Check out
URL:http://docs.python.org/reference/lexical_analysis.html#strings
ah, ok. thanks!
___
On Sat, Oct 6, 2012 at 1:06 AM, lemzw...@googlemail.com wrote:
Are you going to report the number of errors using the `errors'
variable? In case this is true, I would consider this a bad idea, since
you abuse the functionality of the exit status.
How large can `errors' become? The value
LGTM now.
http://codereview.appspot.com/6610058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
For review:
Description:
convert-ly:
- Exit with error status when errors occur.
- Use unicode strings for file names printing.
- Don't update \version when no rule is applied.
This fixes issue 2670.
Please review this at http://codereview.appspot.com/6610058/
http://codereview.appspot.com/6610058/diff/2001/scripts/convert-ly.py
File scripts/convert-ly.py (right):
http://codereview.appspot.com/6610058/diff/2001/scripts/convert-ly.py#newcode357
scripts/convert-ly.py:357: sys.exit(errors)
Are you going to report the number of errors using the `errors'
10 matches
Mail list logo
