Re: harmonics and slides (issue3590041)

2011-02-14 Thread percival . music . ca
This issue should be closed; a new patch is at: http://codereview.appspot.com/4186049/ http://codereview.appspot.com/3590041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: harmonics and slides (issue3590041)

2011-01-29 Thread Patrick Schmidt
Hi Graham, I haven't forgotten this patch but unfortunately I don't seem to find time to fix it at the moment. It seems as if two patches got mixed up at least. So I'm probably not responsible for the good stuff! ;-( I can't promise but I'll try to take care of it next weekend. Thanks,

Re: harmonics and slides (issue3590041)

2011-01-22 Thread percival . music . ca
It looks like there's lots of good work in this patch, but the latest version seems to have some mixed patches. Could you try updating your git tree, then try uploading a new patch? If you need help with git (or with lily-git.tcl), then please don't hesitate to ask.

Re: harmonics and slides (issue3590041)

2011-01-22 Thread Patrick Schmidt
Sounds like there is something wrong with this patch. I will have a look at it, tomorrow. patrick Am 22.01.2011 um 21:08 schrieb percival.music...@gmail.com: It looks like there's lots of good work in this patch, but the latest version seems to have some mixed patches. Could you try

harmonics and slides (issue3590041)

2010-12-11 Thread percival . music . ca
Looks basically good. http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely#newcode383

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Carl . D . Sorensen
Looks pretty good to me. Looks *excellent* for a first patch. Thanks, Carl http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right):

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Patrick Schmidt
Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com: Looks pretty good to me. Looks *excellent* for a first patch. Thanks, Carl http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ fretted-strings.itely File Documentation/notation/fretted-strings.itely (right):

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Carl Sorensen
On 12/11/10 9:54 AM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com: Do we want to have\hideNotes apply to TabVoice? If so, we could change the definition of \hideNotes. That would probably be better than a known issue. IMHO I

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Patrick Schmidt
Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, Patrick Schmidt p.l.schm...@gmx.de wrote: IMHO I think we want to have \hideNotes apply to TabVoice. I tried to achieve glissandi with an indefinite beginning/ending (but in vain): You can test this really easily. Simply

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Carl Sorensen
On 12/11/10 12:44 PM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, Patrick Schmidt p.l.schm...@gmx.de wrote: IMHO I think we want to have \hideNotes apply to TabVoice. I tried to achieve glissandi with an indefinite

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Carl Sorensen
On 12/11/10 12:55 PM, Carl Sorensen c_soren...@byu.edu wrote: On 12/11/10 12:44 PM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, Patrick Schmidt p.l.schm...@gmx.de wrote: IMHO I think we want to have \hideNotes

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Patrick Schmidt
Am 11.12.2010 um 21:16 schrieb Carl Sorensen: On 12/11/10 12:55 PM, Carl Sorensen c_soren...@byu.edu wrote: On 12/11/10 12:44 PM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 18:03 schrieb Carl Sorensen: On 12/11/10 9:54 AM, Patrick Schmidt p.l.schm...@gmx.de wrote:

Re: harmonics and slides (issue3590041)

2010-12-11 Thread Carl Sorensen
On 12/11/10 1:35 PM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 21:16 schrieb Carl Sorensen: On 12/11/10 12:55 PM, Carl Sorensen c_soren...@byu.edu wrote: On 12/11/10 12:44 PM, Patrick Schmidt p.l.schm...@gmx.de wrote: Am 11.12.2010 um 18:03 schrieb Carl