http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode649
scm/fret-diagrams.scm:649: (ordered-cons (car corner1) (car corner2))
I was wondering whether it would not
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode642
scm/fret-diagrams.scm:642: (corner1
from the context, I gather than corner1 is not guaranteed to be
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode642
scm/fret-diagrams.scm:642: (corner1
On 2012/09/18 04:52:05, Graham Percival wrote:
Could we get a comment
Reviewers: joeneeman, Graham Percival,
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc
File lily/lookup.cc (right):
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc#newcode172
lily/lookup.cc:172: if (b.x ().length () blotdiameter)
It is arguably valid to request
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc
File lily/lookup.cc (right):
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc#newcode172
lily/lookup.cc:172: if (b.x ().length () blotdiameter)
On 2012/09/03 07:25:53, Keith wrote:
It is arguably valid to request a
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc
File lily/lookup.cc (right):
http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc#newcode172
lily/lookup.cc:172: if (b.x ().length () blotdiameter)
On 2012/09/03 08:16:27, dak wrote:
Well, arguably valid does not mean
On 2012/09/03 22:54:24, joeneeman wrote:
On 2012/09/03 07:25:53, Keith wrote:
It is arguably valid to request a box running from right to left,
for which length() returns zero.
I argue that it is invalid. If you interpret a right-to-left box
as being non-empty, then the implementation of
lgtm
http://codereview.appspot.com/6450113/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
http://codereview.appspot.com/6450113/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel