Re: ly_scm_write_string: call scm_write directly (issue 545450043 by hanw...@gmail.com)

2020-01-24 Thread hanwenn
Reviewers: dak, thomasmorley651, https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc File lily/lily-guile.cc (right): https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc#newcode55 lily/lily-guile.cc:55: scm_write(s, port); On 2020/01/18 23:29:30,

Re: ly_scm_write_string: call scm_write directly (issue 545450043 by hanw...@gmail.com)

2020-01-18 Thread thomasmorley65
Here https://lists.gnu.org/archive/html/lilypond-devel/2019-10/msg00236.html I reported some problems, likely caused by ly_scm_write_string. Once I'll be back from Salzburg I'll try to compile LilyPond against guile-3.0 with the patches linked above and the changes mentioned here:

ly_scm_write_string: call scm_write directly (issue 545450043 by hanw...@gmail.com)

2020-01-18 Thread dak
LGTM https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc File lily/lily-guile.cc (right): https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc#newcode55 lily/lily-guile.cc:55: scm_write(s, port); Well, I was "what the Dickens?" reading this. I