Re: stencil-integrate.cc: root out slopes (issue 246590043 by d...@gnu.org)

On 2015/06/30 05:55:51, lemzwerg wrote: Oh, I haven't meant that you should reformat everything but just the code you are actually modifying! But thanks anyway. For long names I suggest a formatting like this Grob::maybe_pure_internal_simple_skylines_from_extents( foo arg1,

Re: stencil-integrate.cc: root out slopes (issue 246590043 by d...@gnu.org)

https://codereview.appspot.com/246590043/diff/20001/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/246590043/diff/20001/lily/stencil-integral.cc#newcode62 lily/stencil-integral.cc:62: void create_path_cap (vectorBox boxes, vectorDrul_arrayOffset

Re: stencil-integrate.cc: root out slopes (issue 246590043 by d...@gnu.org)

Oh, I haven't meant that you should reformat everything but just the code you are actually modifying! But thanks anyway. For long names I suggest a formatting like this Grob::maybe_pure_internal_simple_skylines_from_extents( foo arg1, bar arg2, ...) to avoid exactly the problem

Re: stencil-integrate.cc: root out slopes (issue 246590043 by d...@gnu.org)

LGTM https://codereview.appspot.com/246590043/diff/20001/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/246590043/diff/20001/lily/stencil-integral.cc#newcode62 lily/stencil-integral.cc:62: void create_path_cap (vectorBox boxes,