Hello list,
while analyzing and rewriting Bar_line::compound_barline in scheme
I stumbled across an inconsistency:
In Bar_line::print, the function compound_barline is called only if
the length of bar-extent is 0.
In Bar_line::compound_barline, there is
h = extent.length ();
and later
if
Clean.
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
In Notation/wind.itely, please could the following be changed:
Die Liste aller möglichen Löcher und Einstellungen eines bestimmten
Instruments kann auf der Kommandozeile oder in einer Log-Datei
angezeigt werden, auch wenn man sie nicht in der Notenausgabe anzeigen
lassen kann:
Reviewers: dak, Graham Percival, Julien Rioux,
Message:
Please review
Description:
This is effectively a proof-of-concept patch to send the output from the
above snippet to stderr rather than stdout as at present. As ever, it's
to reduce make doc clutter. This patch should apply and work. A
http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly
File Documentation/snippets/displaying-grob-ancestry.ly (right):
http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly#newcode198
- Original Message -
From: d...@gnu.org
To: philehol...@googlemail.com; gra...@percival-music.ca;
julien.ri...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Sunday, March 25, 2012 3:01 PM
Subject: Re: Directs displaying-grob-ancestry.ly to stderr (issue
Marc Hohl marc at hohlart.de writes:
if (str == |. || ( h == 0 str == :|))
IIUC, h == 0 could never be true, isn't it?
The current users of the function never ask it to print a zero-height
bar line. It is still a good thing that the function handles the case
with zero-height correctly
LGTM
Just for clarity for patch-tracking, the 'silly' comment refers to the
existing code, not the change from patch.
On 2012/03/25 14:01:37, dak wrote:
That's silly.
http://codereview.appspot.com/5905052/
___
lilypond-devel mailing list
On 2012/03/25 18:36:26, Keith wrote:
LGTM
Just for clarity for patch-tracking, the 'silly' comment refers to the
existing
code, not the change from patch.
On 2012/03/25 14:01:37, dak wrote:
That's silly.
While the existing code calls format a whole lot, it does not call it
within
On 25/03/12 14:59, philehol...@googlemail.com wrote:
Reviewers: dak, Graham Percival, Julien Rioux,
Message: Please review
Description: This is effectively a proof-of-concept patch to send
the output from the above snippet to stderr rather than stdout as
at present. As ever, it's to
For 20:00 MDT Tuesday March 27
Defect:
Issue 744
http://code.google.com/p/lilypond/issues/detail?id=744: Cross-staff
beams do not work well when including rests - R5908043
http://codereview.appspot.com/5908043/
Documentation:
Issue 2216
11 matches
Mail list logo