Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-06-14 Thread David Kastrup
markpole...@gmail.com writes: On 2014/06/06 09:29:03, Mark Polesky wrote: Please review this new patch. I'm not entirely sure this is the right approach, so I may need some advice here. This patch has gone through the review/countdown process without a single comment or review, but I'm not

Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043 by markpole...@gmail.com)

2014-06-14 Thread pkx166h
I am not sure this is the best/correct method for the snippets. Shouldn't you be editing those in ../snippets/new/.. and then using makelsr.py to 'update' the snippets in the usual way? Else if someone comes and edits a snippet in new *after* this patch, all your work is undone as the 'new'

PATCHES: Countdown - June 17th - 06:00 GMT

2014-06-14 Thread James
Hello, 3948 http://code.google.com/p/lilypond/issues/detail?id=3948q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified

Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043 bymarkpole...@gmail.com)

2014-06-14 Thread Phil Holmes
- Original Message - From: pkx1...@gmail.com To: markpole...@gmail.com; lemzw...@googlemail.com Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Saturday, June 14, 2014 10:43 AM Subject: Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043

Re: Issue 3951: Fix broken LSR links in docs. (issue 102410043 by markpole...@gmail.com)

2014-06-14 Thread markpolesky
On 2014/06/14 10:03:46, mail_philholmes.net wrote: I would suggest correcting the links in the Documentation, but not the snippets themselves. The links in the snippets are not really visible (commented out) and, as James says, are over-written with an LSR import. Fair enough. I

Color and/or parenthesize single dots in fret-diagrams (issue 102450043 by thomasmorle...@gmail.com)

2014-06-14 Thread thomasmorley65
Reviewers: , Message: Please review Description: Color and/or parenthesize single dots in fret-diagrams Issue 2752 Makes it possible to color and/or parenthesize single dots in fret-diagram-verbose Introducing two properties for use in fret-diagram-details - fret-label-horizontal-offset

Re: Color and/or parenthesize single dots in fret-diagrams (issue 102450043 by thomasmorle...@gmail.com)

2014-06-14 Thread pkx166h
https://codereview.appspot.com/102450043/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): https://codereview.appspot.com/102450043/diff/1/Documentation/notation/fretted-strings.itely#newcode1002

Re: Make \upbow an empty command + Segmentation fault

2014-06-14 Thread James
ccing Dev list as I think this might be more pertinent there. James On 12/04/14 14:22, Felix Janda wrote: Hi, say I have a violin part with bowing instructions in a variable. Now I want to use the same variable in the full orchestral score but the bowing marks should be suppressed.

Re: Make \upbow an empty command + Segmentation fault

2014-06-14 Thread Dan Eble
On 12/04/14 14:22, Felix Janda wrote: Hi, say I have a violin part with bowing instructions in a variable. Now I want to use the same variable in the full orchestral score but the bowing marks should be suppressed. \upbow is treated by lilypond as an articulation, but the other

Re: Make \upbow an empty command + Segmentation fault

2014-06-14 Thread David Kastrup
James pkx1...@gmail.com writes: On 12/04/14 14:22, Felix Janda wrote: Hi, say I have a violin part with bowing instructions in a variable. Now I want to use the same variable in the full orchestral score but the bowing marks should be suppressed. \upbow is treated by lilypond as an

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-14 Thread markpolesky
On 2014/06/14 06:58:52, dak wrote: On 2014/06/06 09:29:03, Mark Polesky wrote: ... Ideally, if the user has already modified some of those values, I'd like to base the new scaled values on the user's choices, and not base them on the LilyPond default values. If that's possible at all, I don't

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-14 Thread David Kastrup
markpole...@gmail.com writes: On 2014/06/14 06:58:52, dak wrote: On 2014/06/06 09:29:03, Mark Polesky wrote: ... Ideally, if the user has already modified some of those values, I'd like to base the new scaled values on the user's choices, and not base them on the LilyPond default values.

Re: Make \upbow an empty command + Segmentation fault

2014-06-14 Thread Felix Janda
David Kastrup wrote: James pkx1...@gmail.com writes: On 12/04/14 14:22, Felix Janda wrote: Hi, say I have a violin part with bowing instructions in a variable. Now I want to use the same variable in the full orchestral score but the bowing marks should be suppressed. \upbow is