Re: [frogs] Re: New frog in an empty pond?

2012-02-25 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: On Thu, Feb 23, 2012 at 1:18 PM, Graham Percival gra...@percival-music.ca wrote: On Wed, Feb 22, 2012 at 04:52:00PM -0800, Janek Warchol wrote: It would be good indeed if you have a mentor; unfortunately, i don't think you'll find one here, on

Re: [frogs] Re: New frog in an empty pond?

2012-02-25 Thread Janek Warchoł
On Sat, Feb 25, 2012 at 10:09 AM, David Kastrup d...@gnu.org wrote: Janek Warchoł janek.lilyp...@gmail.com writes: i wrote: try looking at grid lines code.  That's definitely not enough for efficient mentoring :( Try asking on the developer list.  Find an angle that makes this problem

Re: [frogs] Re: New frog in an empty pond?

2012-02-25 Thread Phil Holmes
- Original Message - From: Janek Warchoł janek.lilyp...@gmail.com Fortunately it's mostly me whom i'm doing this for :) (is the above proper English, anyway?) cheers, Janek Fortunately, I'm mostly doing this for me. would be fair idiomatic English. Some people would say myself

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread julien . rioux
This adds a dependency on the python module fontforge. I think it should be checked during ./configure but I'm not sure where to point you for accomplishing that. Regards, Julien http://codereview.appspot.com/5695061/diff/1/python/mf_table.py File python/mf_table.py (right):

Re: CG: Use latest convert-ly for LSR updates (fix 2346) (issue 5696069)

2012-02-25 Thread julien . rioux
One suggestion. Regards, Julien http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi File Documentation/contributor/lsr-work.itexi (right): http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi#newcode302

Re: Cross-staff stem engraver (was: New frog in an empty pond?)

2012-02-25 Thread Joe Neeman
On Fri, Feb 24, 2012 at 3:04 PM, Pavel Roskin pro...@gnu.org wrote: Hello! I'm moving the thread to lilypond-devel and changing the subject. I hope it's OK. On Thu, 23 Feb 2012 15:37:02 + Neil Puttock n.putt...@gmail.com wrote: On 23 February 2012 15:18, Pavel Roskin pro...@gnu.org

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread hanwenn
haven't looked in detail, but nice, and simpler than I thought :) now, if you want a real challenge: you could redo mf2pt1 in Fontforge python too! :) http://codereview.appspot.com/5695061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Cross-staff stem engraver (was: New frog in an empty pond?)

2012-02-25 Thread Pavel Roskin
Quoting Joe Neeman joenee...@gmail.com: On Fri, Feb 24, 2012 at 3:04 PM, Pavel Roskin pro...@gnu.org wrote: I tried writing an engraver that could be added to the StaffGroup context. Collecting stems is not a problem. The problem is that even the finalize handler is called to early. I'm

Removes mutopia-index.py processing (issue 5696073)

2012-02-25 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, Message: Please review. Description: I checked on -devel and no-one argued for keeping this. The patch stops make doc running mutopia-index.py. I believe the script is an old hangover, and trying to run on files which no longer exist. Please review

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread julien . rioux
This is good, I now get the error message right away when running configure. No problem with the patch after installing the required package. Do lilydev and gub already include the fontforge python package? Regards, Julien http://codereview.appspot.com/5695061/diff/3003/configure.in File

Quietens extract-texi-filenames in make doc (issue 5698066)

2012-02-25 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, Message: Simple change. Please review. Description: Adds the -q flag to the call to extract-texi-filenames.py during make doc. Gets rid of unnecessary progress messages. Please review this at http://codereview.appspot.com/5698066/ Affected files: M

Re: Quietens extract-texi-filenames in make doc (issue 5698066)

2012-02-25 Thread graham
LGTM, please push directly to staging. http://codereview.appspot.com/5698066/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread Graham Percival
On Sat, Feb 25, 2012 at 03:57:55PM +, julien.ri...@gmail.com wrote: This is good, I now get the error message right away when running configure. No problem with the patch after installing the required package. Do lilydev and gub already include the fontforge python package? No, and adding

Re: Removes mutopia-index.py processing (issue 5696073)

2012-02-25 Thread Phil Holmes
- Original Message - From: julien.ri...@gmail.com To: philehol...@googlemail.com; gra...@percival-music.ca Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Saturday, February 25, 2012 3:50 PM Subject: Re: Removes mutopia-index.py processing (issue 5696073) Looks

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread Carl Sorensen
On 2/25/12 9:23 AM, Graham Percival gra...@percival-music.ca wrote: On Sat, Feb 25, 2012 at 03:57:55PM +, julien.ri...@gmail.com wrote: This is good, I now get the error message right away when running configure. No problem with the patch after installing the required package. Do lilydev

More reductions in make doc (issue 5694079)

2012-02-25 Thread PhilEHolmes
Reviewers: Graham Percival, Julien Rioux, Message: Further update for review Description: More reductions in make doc Pushes the output from making midi .ly files and ly-examples to logfiles - slightly more controversial - uses the run-and-check shell script to do this. However, I think we

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread Graham Percival
On Sat, Feb 25, 2012 at 04:50:21PM +, Carl Sorensen wrote: On 2/25/12 9:23 AM, Graham Percival gra...@percival-music.ca wrote: No, and adding this to GUB will be particularly challenging. I'm afraid that this will probably postpone the patch indefinitely. :( Can't we add that package

Re: More reductions in make doc (issue 5694079)

2012-02-25 Thread Graham Percival
On Sat, Feb 25, 2012 at 04:58:59PM +, philehol...@googlemail.com wrote: Pushes the output from making midi .ly files and ly-examples to logfiles - slightly more controversial - uses the run-and-check shell script to do this. What's supposed to be controversial here? Seems like an

Output from midi2ly

2012-02-25 Thread Phil Holmes
Midi2ly, as used in the make doc build system, puts 2 types of message on the terminal: LY output to (filename) and Warning, more than 5 voices found. Expect bad output. Seems to me we could: 1) Get rid of the first message completely by deleting the print line. We then have the problem of

Re: CG: add information about Regtest Checking Project (issue 5669047)

2012-02-25 Thread janek . lilypond
New patch set uploaded, it should make doc now. Thanks for the tips, Carl and Graham! You saved me some time. I decided not to use @rglos and @rinternals (because from what i understand it would print the name of the section i'm referring to) but use @rglosnamed and @rinternalsnamed instead.

Re: CG: add information about Regtest Checking Project (issue 5669047)

2012-02-25 Thread Graham Percival
On Sat, Feb 25, 2012 at 09:51:31PM +, janek.lilyp...@gmail.com wrote: I decided not to use @rglos and @rinternals (because from what i understand it would print the name of the section i'm referring to) but use @rglosnamed and @rinternalsnamed instead. I discourage (but not forbid) the use

Re: Cross-staff stem engraver (was: New frog in an empty pond?)

2012-02-25 Thread Joe Neeman
On Sat, Feb 25, 2012 at 5:49 AM, Pavel Roskin pro...@gnu.org wrote: Quoting Joe Neeman joenee...@gmail.com: On Fri, Feb 24, 2012 at 3:04 PM, Pavel Roskin pro...@gnu.org wrote: I tried writing an engraver that could be added to the StaffGroup context. Collecting stems is not a problem.

Re: CG: add information about Regtest Checking Project (issue 5669047)

2012-02-25 Thread Janek Warchoł
On Sat, Feb 25, 2012 at 10:55 PM, Graham Percival gra...@percival-music.ca wrote: Up to you.  The fancier you make the formatting, the harder it is to maintain.  You should also check how it looks in info.  If you want to play games with that, go ahead -- as I said, we don't forbid @...named.  

GUB build problems

2012-02-25 Thread Carl Sorensen
OK, so I decided to try to start from scratch in building GUB. I created a new virtual machine. Loaded it with lily-dev 1.1, from http://www.et.byu.edu/~sorensen/ubuntu-lilydev-remix-1.1.iso Installed guest additions Installed libmpfr-dev, with sudo apt-get libmpfr-dev Got GUB with git

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread Joe Neeman
On Sat, Feb 25, 2012 at 8:23 AM, Graham Percival gra...@percival-music.cawrote: On Sat, Feb 25, 2012 at 03:57:55PM +, julien.ri...@gmail.com wrote: This is good, I now get the error message right away when running configure. No problem with the patch after installing the required

Re: Simplify font building. (issue 5695061)

2012-02-25 Thread Graham Percival
On Sat, Feb 25, 2012 at 02:06:46PM -0800, Joe Neeman wrote: On Sat, Feb 25, 2012 at 8:23 AM, Graham Percival [1]gra...@percival-music.ca wrote: No, and adding this to GUB will be particularly challenging. I'm afraid that this will probably postpone the patch indefinitely.

Re: [frogs] Re: New frog in an empty pond?

2012-02-25 Thread Colin Campbell
On 12-02-25 03:32 AM, Phil Holmes wrote: - Original Message - From: Janek Warchoł janek.lilyp...@gmail.com Fortunately it's mostly me whom i'm doing this for :) (is the above proper English, anyway?) cheers, Janek Fortunately, I'm mostly doing this for me. would be fair idiomatic

Re: Cross-staff stem engraver (was: New frog in an empty pond?)

2012-02-25 Thread Pavel Roskin
Quoting Joe Neeman joenee...@gmail.com: The problem is where you ask for the stem Y-extent relative to yref (the VerticalAlignment): in order to calculate the vertical distance between the various staves and the VerticalAlignment, line breaking needs to be done first. (And line breaking doesn't

Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread julien . rioux
1 line adds whitespace errors. That's all. Regards, Julien http://codereview.appspot.com/5695058/diff/6001/input/regression/tablature-open-string-handling.ly File input/regression/tablature-open-string-handling.ly (right):

Re: Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread David Kastrup
julien.ri...@gmail.com writes: 1 line adds whitespace errors. That's all. Regards, Julien The scripts lilypond-extra/patches/accept-patch.py and lilypond-extra/patches/reject-patch.py are known to you? They take an issue number and a text as argument. -- David Kastrup

Re: Handling of open strings in tablature (issue 5695058)

2012-02-25 Thread Marc Hohl
Am 26.02.2012 07:07, schrieb julien.ri...@gmail.com: 1 line adds whitespace errors. That's all. Regards, Julien http://codereview.appspot.com/5695058/diff/6001/input/regression/tablature-open-string-handling.ly File input/regression/tablature-open-string-handling.ly (right):