reformatted GNUmakefile pushed to staging

2012-10-23 Thread Werner LEMBERG
Folks, as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

svg output

2012-10-23 Thread Joram Berger
Hi, could the lilypond options to specify the output file format be unified? Currently, depending on the format, there are different options: --pdf or --formats=pdf (and ps and png) -dbackend=svg (eps, scm, …) Even though things are perhaps a little bit different, I would suggest to include svg

Re: svg output

2012-10-23 Thread Federico Bruni
2012/10/23 Joram Berger joram.no...@gmx.de: Even though things are perhaps a little bit different, I would suggest to include svg (or the whole backend-options) into formats, if possible. Because thats essentially what the user wants: get the output in the format svg. there's an old issue

Re: svg output

2012-10-23 Thread Joram Berger
Am 23.10.2012 09:08, Federico Bruni: 2012/10/23 Joram Berger joram.no...@gmx.de: Even though things are perhaps a little bit different, I would suggest to include svg (or the whole backend-options) into formats, if possible. Because thats essentially what the user wants: get the output in the

Re: Doc: NR 5.3 Add \single command (issue 6742057)

2012-10-23 Thread marc
On 2012/10/20 17:52:29, J_lowe wrote: Here is the first draft of reworking NR 5.3 while adding the \single command. James, I like the changes very much – the restructuring makes the doc more readable and understandable IMHO. I _expect_ to have lots of edits and go through a few iterations

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: Folks, as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Is there anything wrong with our review system? If you feel there is, how about at least posting the patch for review on the

Re: [PossibleSpam] Re: [PossibleSpam] Re: 2.16.1

2012-10-23 Thread Francisco Vila
2012/10/23 David Kastrup d...@gnu.org: Well, LilyPond could see a problem in connection with issue 2883. Not because of a Spanish version of changes.tely but because of outdated syntax in the Spanish version, syntax that just was not present in the English version, and that did not get

Re: [PossibleSpam] Re: [PossibleSpam] Re: 2.16.1

2012-10-23 Thread David Kastrup
Francisco Vila francisco.v...@hispalinux.es writes: 2012/10/23 David Kastrup d...@gnu.org: Well, LilyPond could see a problem in connection with issue 2883. Not because of a Spanish version of changes.tely but because of outdated syntax in the Spanish version, syntax that just was not

Re: svg output

2012-10-23 Thread Federico Bruni
2012/10/23 Joram Berger joram.no...@gmx.de: Ok, I've overlooked that. Btw: SVG output is really nice! I agree. Personally, I'd love to see it used in the documentation. I wonder if it's possible to build the documentation using SVGs instead of PNGs.. The documentation would be lighter, faster

Re: svg output

2012-10-23 Thread David Kastrup
Federico Bruni fedel...@gmail.com writes: 2012/10/23 Joram Berger joram.no...@gmx.de: Ok, I've overlooked that. Btw: SVG output is really nice! I agree. Personally, I'd love to see it used in the documentation. I wonder if it's possible to build the documentation using SVGs instead of

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread pkx166h
Mark, Nearly there. Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the CG policy (even if it does go against every grain in my typographically-based

Re: svg output

2012-10-23 Thread Federico Bruni
2012/10/23 David Kastrup d...@gnu.org: Texinfo does not support SVG as far as I know. And neither do typical info readers like Emacs if I remember correctly. This page seems to confirm your statement: http://www.gnu.org/software/texinfo/manual/texinfo/html_node/Image-Syntax.html#Image-Syntax

Re: svg output

2012-10-23 Thread James
Hello, On 23 October 2012 10:05, Federico Bruni fedel...@gmail.com wrote: 2012/10/23 David Kastrup d...@gnu.org: Texinfo does not support SVG as far as I know. And neither do typical info readers like Emacs if I remember correctly. This page seems to confirm your statement:

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread James
Hello, On 23 October 2012 08:26, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: Folks, as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Is there anything wrong with our review system? If you

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread David Kastrup
James pkx1...@gmail.com writes: Hello, On 23 October 2012 08:26, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: Folks, as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Is there anything

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread Werner LEMBERG
as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Is there anything wrong with our review system? If you feel there is, how about at least posting the patch for review on the list before pushing? It *has* been posted

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread Werner LEMBERG
I have run my own copy of patchy-merge, and it failed because of typos in the Makefile, Details, please. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: svg output

2012-10-23 Thread Federico Bruni
2012/10/23 James pkx1...@gmail.com: Do all browsers accept output in SVG what about PDF readers? I think that it should be limited to html. The main problem is IE, because the basic support was added only in version 9:

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread David Kastrup
David Kastrup d...@gnu.org writes: Werner LEMBERG w...@gnu.org writes: Folks, as discussed some weeks ago, I've now pushed the reformatted GNUmakefile to staging. There are only whitespace changes. Is there anything wrong with our review system? If you feel there is, how about at

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: I have run my own copy of patchy-merge, and it failed because of typos in the Makefile, Details, please. I already sent the details previous to writing the quoted mail above, but looking at the list archives it would appear that Gmane swallowed them as

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread Werner LEMBERG
out=test \ local-test /bin/sh: 1: local-test: not found make: *** [test] Error 127 Thanks, I'll upload a fixed patch with patchy. However, you are going to remove some stuff from GNUmakefile, right? Then I'll wait. I am backing this change out of staging again. Thanks

Re: reformatted GNUmakefile pushed to staging

2012-10-23 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: out=test \ local-test /bin/sh: 1: local-test: not found make: *** [test] Error 127 Thanks, I'll upload a fixed patch with patchy. However, you are going to remove some stuff from GNUmakefile, right? Then I'll wait. It would make sense

Revert Archive baselines in LILYPOND_BASELINES directory if specified (issue 6709073)

2012-10-23 Thread lemzwerg
LGTM. http://codereview.appspot.com/6709073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

2012-10-23 Thread lemzwerg
LGTM. Any convert rules necessary? http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

2012-10-23 Thread dak
Reviewers: lemzwerg, Message: On 2012/10/23 11:19:59, lemzwerg wrote: LGTM. Any convert rules necessary? Well, I abolish list-or-symbol? here on the assumption that nobody used this peculiar and mostly ill-advised predicate. That is somewhat optimistic. Converting list-or-symbol?

Re: prevent collision of ligatures and next note (issue 6740046)

2012-10-23 Thread janek . lilypond
(as you may know, i dedicate all my code reviews to Graham the Magnificent :D) Pal, could you add some comments and a more descriptive commit message? I see the code, and it seems to make sense, but i don't understand the why's. For example, why the parameters should be passed in a different

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

2012-10-23 Thread janek . lilypond
pushed as 5c4b80afe97acbe20199a3aa71a0d63172112f23 David, please close this issue. thanks! Janek http://codereview.appspot.com/6687044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

New bar line interface: adds volta bracket regtest; minor changes (issue 6737051)

2012-10-23 Thread janek . lilypond
LGTM, i think. best, Janek http://codereview.appspot.com/6737051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread marc
On 2012/10/23 09:03:32, J_lowe wrote: Mark, Nearly there. Hey, sounds prominsing ;-) Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the

Re: prevent collision of ligatures and next note (issue 6740046)

2012-10-23 Thread benko . pal
hi Janek, Pal, could you add some comments and a more descriptive commit message? I see the code, and it seems to make sense, but i don't understand the why's. For example, why the parameters should be passed in a different way? in C++ there should be a good reason to pass complex

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

2012-10-23 Thread marc
Hey, that was quick! Thanks for solving this issue - LGTM! http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

2012-10-23 Thread dak
On 2012/10/23 19:05:09, marc wrote: Hey, that was quick! Thanks for solving this issue - LGTM! Well, there is no regtest and no documentation, so it is not like there is nothing left to do. And to be honest, the usual to check this feature, you have used some code and could equally well turn

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread pkx166h
One typo so, as we need to fix this, I also included a minor grammar change. Otherwise LGTM. https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right):

Re: glossary - add 'high bass clef'

2012-10-23 Thread James
Arnold I think this might be better on dev list than bug so I am ccing dev in case you are not subscribed to that list yet. On 23 October 2012 12:54, ArnoldTheresius arnold.we...@siemens.com wrote: James wrote Hello, ... Well I have applied this patch and I am not sure it is appropriate

PATCH: Countdown to 20121025

2012-10-23 Thread Colin Campbell
For 20:00 MDT Thursday October 25 Enhancement: Issue 2920 http://code.google.com/p/lilypond/issues/detail?id=2920: Patch: Revert Archive baselines in LILYPOND_BASELINES directory if specified - R 6709073 http://codereview.appspot.com/6709073/ Issue 2917