Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread dak
On 2012/12/31 00:07:12, thomasmorley65 wrote: I thought about extending \draw-line with a 'style-property. But in extreme cases you would have to write: \markup { \override #'(style . dashed) \override #'(on . 0.5) \override #'(off . 0.2) \override #'(thickness . 2) \draw-line

Re: PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (issue 7029043)

2012-12-31 Thread benko . pal
LGTM https://codereview.appspot.com/7029043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 5.3 Add \single command (issue 6742057)

2012-12-31 Thread graham
https://codereview.appspot.com/6742057/diff/7001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6742057/diff/7001/Documentation/notation/changing-defaults.itely#newcode1626

Re: IR: Improve performer documentation (issue 6868047)

2012-12-31 Thread src
David, On 2012/12/02 11:11:54, dak wrote: https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm File scm/document-translation.scm (right): Sorry for resurrecting this a month late, I think I only quite understood yesterday what you actually meant. It is somewhat obsolete

Issue 3073: Context definitions and context mods ignore \unset (issue 7038044)

2012-12-31 Thread lemzwerg
LGTM https://codereview.appspot.com/7038044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread david . nalesnik
Harm-- This looks great! Thank you for the 'full-length option. I can't be alone in hating lines ending with incomplete dashes. All I have is a suggestion or two, and some quibbles. Besides what I've pointed out inline, I should mention that I got a number of whitespace errors when I applied

Re: Issue 3073: Context definitions and context mods ignore \unset (issue 7038044)

2012-12-31 Thread pkx166h
https://codereview.appspot.com/7038044/diff/1/input/regression/property-unset.ly File input/regression/property-unset.ly (right): https://codereview.appspot.com/7038044/diff/1/input/regression/property-unset.ly#newcode8 input/regression/property-unset.ly:8: systems here should revert to the

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread thomasmorley65
On 2012/12/31 14:59:45, david.nalesnik wrote: Harm-- This looks great! Thank you for the 'full-length option. I can't be alone in hating lines ending with incomplete dashes. Hi David, thanks for reviewing! All I have is a suggestion or two, and some quibbles. Besides what I've

invalid read in Context::properties_dict()

2012-12-31 Thread Dan Eble
I have a reproducible segfault, but not a tiny example. (If anyone wants to reproduce this, ask me to prepare a tgz for you to download from my web site.) Is there an expert here who can tell me how likely it is that the Context properties actually referred to the object released in

Re: invalid read in Context::properties_dict()

2012-12-31 Thread Dan Eble
When the segfault occurs, multiple contexts in the call stack have already had their mark_smob() method called. I guess that means they're all invalid, and their memory might have been reallocated. Is that correct? For a while, I have been using the following scheme code to define instrument