Re: smob design

2014-10-07 Thread David Kastrup
Dan Eble d...@faithful.be writes: The Smob code is sending me mixed messages. Welcome to the club. On one hand, it looks like multiple levels of derivation will not work, e.g. creating a subclass of Book, because Book::Book() would call smobify_self() before the subclass constructor runs

Re: es means ees???

2014-10-07 Thread Richard Shann
On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here, instead of ees, is written es. I read In Dutch, aes is contracted to as, but both forms are accepted

Re: es means ees???

2014-10-07 Thread David Kastrup
Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here, instead of ees, is written es. I read In Dutch, aes is

Re: es means ees???

2014-10-07 Thread Richard Shann
On Tue, 2014-10-07 at 09:50 +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here,

Re: Compact Chord Symbols Patch

2014-10-07 Thread Richard Shann
On Mon, 2014-10-06 at 20:06 +0100, James wrote: Richard, [..] Richard I have created http://code.google.com/p/lilypond/issues/detail?id=4154 I'll help shepherd this patch through via the standard review process for this. Thank you very much. I thought I would follow the

Add original-breaks.ly commands (issue 150670043 by lilyli...@googlemail.com)

2014-10-07 Thread lilyliska
Reviewers: , Description: Add original-breaks.ly commands The commands defined in this patch allow the user to insert breaks (line and page) from the original manuscript that are conditionally respected or discarded. This is very useful for entering and proof-reading music from larger scores.

Re: es means ees???

2014-10-07 Thread Richard Shann
On Tue, 2014-10-07 at 09:50 +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here,

Re: es means ees???

2014-10-07 Thread David Kastrup
Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 09:50 +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann

Re: es means ees???

2014-10-07 Thread Richard Shann
If that was the focus of LilyPond, we would talk to it in MusicXML. Hmm, I think there is a serious need to puncture the MusicXML bubble - it is an appalling hotchpotch quite unsuited to representing typeset music. From a casual look it seems to have been designed, but in fact the real

Re: es means ees???

2014-10-07 Thread David Kastrup
Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 09:50 +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann

Re: es means ees???

2014-10-07 Thread David Kastrup
Richard Shann rich...@rshann.plus.com writes: If that was the focus of LilyPond, we would talk to it in MusicXML. Hmm, I think there is a serious need to puncture the MusicXML bubble - it is an appalling hotchpotch quite unsuited to representing typeset music. From a casual look it seems

Re: Compact Chord Symbols Patch

2014-10-07 Thread James
On 07/10/14 09:08, Richard Shann wrote: On Mon, 2014-10-06 at 20:06 +0100, James wrote: Richard, [..] Richard I have created http://code.google.com/p/lilypond/issues/detail?id=4154 I'll help shepherd this patch through via the standard review process for this. Thank you very much. I

Re: es means ees???

2014-10-07 Thread Hans Aberg
On 7 Oct 2014, at 09:33, Richard Shann rich...@rshann.plus.com wrote: On Tue, 2014-10-07 at 11:04 +0900, Graham Percival wrote: On Mon, Oct 06, 2014 at 01:41:30PM +0200, David Kastrup wrote: Richard Shann rich...@rshann.plus.com writes: Here, instead of ees, is written es. I read

Re: Compact Chord Symbols Patch

2014-10-07 Thread Richard Shann
On Tue, 2014-10-07 at 12:53 +0100, James wrote: On 07/10/14 09:08, Richard Shann wrote: On Mon, 2014-10-06 at 20:06 +0100, James wrote: Richard, [..] Richard I have created http://code.google.com/p/lilypond/issues/detail?id=4154 I'll help shepherd this patch through via the

Re: Compact Chord Symbols Patch

2014-10-07 Thread Graham Percival
On Tue, Oct 07, 2014 at 12:53:53PM +0100, James wrote: I think we could improve the notes in the contributor's Guide generally. Having had to help three or four people over the last few months with a patch or two, I get how the instructions are probably rather confusing if not intimidating. I

Re: Compact Chord Symbols Patch

2014-10-07 Thread David Kastrup
Richard Shann rich...@rshann.plus.com writes: Well, I certainly tried to do this without attacking the core code itself, but I'd love it if there were some point of entry (a scheme engraver?) that would allow chord symbols to be drawn by a user generated routine (this is everything, including

Re: Add original-breaks.ly commands (issue 150670043 by lilyli...@googlemail.com)

2014-10-07 Thread nine . fierce . ballads
On 2014/10/07 08:37:06, uliska wrote: On 2014/10/07 08:37:06, uliska wrote: On 2014/10/07 08:37:06, uliska wrote: On 2014/10/07 08:37:06, uliska wrote: Important: * There should be regression tests. Musing: * Why not use tags? (Example below.) * Does this implementation make it possible to

Re: Add original-breaks.ly commands (issue 150670043 by lilyli...@googlemail.com)

2014-10-07 Thread dak
On 2014/10/07 22:30:53, Dan Eble wrote: * When using original breaks, wouldn't one also want original page size, staff size, etc.? That would not map well to tags. Not without additional facilities, I guess. Still, I think that tags at least address a large enough problem space that

Re: Let \time in mid-measure work without warning in some cases (issue 143450043 by nine.fierce.ball...@gmail.com)

2014-10-07 Thread nine . fierce . ballads
Now a warning is only issued when there is an event for the time change. This is the final draft, I hope. https://codereview.appspot.com/143450043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Issue 4156: Define Smob constructors. (issue 152370043 by nine.fierce.ball...@gmail.com)

2014-10-07 Thread nine . fierce . ballads
Reviewers: , Description: Define Smob constructors. https://code.google.com/p/lilypond/issues/detail?id=4156 Please review this at https://codereview.appspot.com/152370043/ Affected files (+53, -26 lines): M lily/book.cc M lily/context.cc M lily/context-def.cc M lily/font-metric.cc M

Re: Issue 4156: Define Smob constructors. (issue 152370043 by nine.fierce.ball...@gmail.com)

2014-10-07 Thread nine . fierce . ballads
Note that I haven't searched for kinds of derived Smob that are still getting compiler-generated constructors. My approach was to clean up SmobT and fix resulting warnings. The rest shouldn't be any worse off now than they were before. https://codereview.appspot.com/152370043/

Re: Issue 4156: Define Smob constructors. (issue 152370043 by nine.fierce.ball...@gmail.com)

2014-10-07 Thread lemzwerg
LGTM, from visual inspection only :-) https://codereview.appspot.com/152370043/diff/1/lily/include/book.hh File lily/include/book.hh (right): https://codereview.appspot.com/152370043/diff/1/lily/include/book.hh#newcode31 lily/include/book.hh:31: typedef SmobBook base_type; I would insert an

Re: Add original-breaks.ly commands (issue 150670043 by lilyli...@googlemail.com)

2014-10-07 Thread k-ohara5a5a
For this particular task, you should also show the user that he can define at the top of the input, or in a header file if he uses one, originalBreak = \break and insert before music where we are done with the original breaks, originalBreak = {} %\break That is easy enough to understand, and