Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Alexander Kobel
On 2016-12-26 01:01, Alexander Kobel wrote: On 2016-12-26 00:38, Trevor Daniels wrote: I attach a recent example - very Christmassy! Nice one, thanks. Note that, due to the fixed voice association to soprano in the SATB template, you should manually left-align the syllables where the bass has

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Alexander Kobel
On 2016-12-26 00:38, Trevor Daniels wrote: Alexander Kobel wrote Sunday, December 25, 2016 2:19 PM But: I cannot imagine a situation where I would not use automatic extenders, so I'm a really bad person to judge the need and requirements for a manual mode. One obvious and fairly common

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Trevor Daniels
Alexander Kobel wrote Sunday, December 25, 2016 2:19 PM > But: I cannot imagine a situation where I would not use automatic > extenders, so I'm a really bad person to judge the need and requirements > for a manual mode. One obvious and fairly common situation is when there are several verses

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Alexander Kobel
On 2016-12-25 23:19, Thomas Morley wrote: 2016-12-25 22:46 GMT+01:00 Alexander Kobel : Hang on - I think you'll need the output of `git format-patch` rather than `git diff -u`. Here it is... Indeed, thanks. Pushed now. Thanks. Some tasks todo: (1) please edit the

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Thomas Morley
2016-12-25 22:46 GMT+01:00 Alexander Kobel : > On 2016-12-25 22:29, Alexander Kobel wrote: >> >> On 2016-12-25 20:52, Thomas Morley wrote: >>> >>> 2016-12-25 14:22 GMT+01:00 Alexander Kobel : Hi all, On 2016-12-24 17:32, James wrote:

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread perpeduumimmobile
On 2016/12/25 15:43:05, Knut_Petersen_t-online.de wrote: Hi everybody! > I'm only 90% happy about "" and \markup\null... > For dynamic spanners and hairpins, we have \! to end them prematurely > before a "natural" end event appears. Is this similar enough to warrant > the use of the same

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Alexander Kobel
On 2016-12-25 19:48, Urs Liska wrote: Am 25.12.2016 um 14:22 schrieb Alexander Kobel: Hi all, On 2016-12-24 17:32, James wrote: Push: [...] 5010 add choral and choral-cautionary accidental style - Alexander Kobel https://sourceforge.net/p/testlilyissues/issues/5010

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Thomas Morley
2016-12-25 14:22 GMT+01:00 Alexander Kobel : > Hi all, > > On 2016-12-24 17:32, James wrote: >> >> Push: >> [...] >> 5010 add choral and choral-cautionary accidental style - Alexander Kobel >> https://sourceforge.net/p/testlilyissues/issues/5010 >>

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread nine . fierce . ballads
On 2016/12/25 14:03:09, akobel wrote: Tell parser to ignore "__" token I apologize if I am misjudging this change based on the headline alone, but if a token serves no purpose (my assumption), then rather than ignoring it, shouldn’t the parser treat it as it would any other unexpected input

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Urs Liska
Am 25.12.2016 um 14:22 schrieb Alexander Kobel: > Hi all, > > On 2016-12-24 17:32, James wrote: >> Push: >> [...] >> 5010 add choral and choral-cautionary accidental style - Alexander Kobel >> https://sourceforge.net/p/testlilyissues/issues/5010 >> http://codereview.appspot.com/311430043 > >

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread david . nalesnik
https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode61 lily/self-alignment-interface.cc:61: return scm_from_double (-

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Knut Petersen
Am 25.12.2016 um 13:14 schrieb Noeck: As extender events are generated automatically now it probably is a good idea to tell yacc / bison to recognize but ignore "__" tokens. I don't know at which level the __, \overrides and the automatic extenders interact. But would it make sense to use __

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread Knut Petersen
Hi everybody! I'm only 90% happy about "" and \markup\null... For dynamic spanners and hairpins, we have \! to end them prematurely before a "natural" end event appears. Is this similar enough to warrant the use of the same token (i.e., \! would be translated to empty lyrics with a

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread perpeduumimmobile
https://codereview.appspot.com/313240043/diff/40001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/313240043/diff/40001/Documentation/notation/vocal.itely#newcode842 Documentation/notation/vocal.itely:842: @samp{ \markup\null }

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Alexander Kobel
Hi all. On 2016-12-25 13:14, Noeck wrote: As extender events are generated automatically now it probably is a good idea to tell yacc / bison to recognize but ignore "__" tokens. I don't know at which level the __, \overrides and the automatic extenders interact. But would it make sense to use

Re: PATCHES - Countdown for December 24th

2016-12-25 Thread Alexander Kobel
Hi all, On 2016-12-24 17:32, James wrote: Push: [...] 5010 add choral and choral-cautionary accidental style - Alexander Kobel https://sourceforge.net/p/testlilyissues/issues/5010 http://codereview.appspot.com/311430043 Does this require any action from my side? I doubt that I have write

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Noeck
> As extender events are generated automatically now it probably is a > good idea to tell yacc / bison to recognize but ignore "__" tokens. I don't know at which level the __, \overrides and the automatic extenders interact. But would it make sense to use __ now, to force an extender e.g. on a

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2016-12-25 Thread tdanielsmusic
LGTM, with the trivial suggestions indicated below to the NR, but I'm not competent to check the code sections. The use of "__" has been expunged completely: should we not retain a brief mention perhaps for use when the user has turned auto extenders off? Trevor

Re: [PATCH [uploaded to Rietveld]] Automatic lyric extenders

2016-12-25 Thread Knut Petersen
Hi Alexander et al.! As extender events are generated automatically now it probably is a good idea to tell yacc / bison to recognize but ignore "__" tokens. cu, Knut >From 768bf54ad8563b0cb6c2cbce692385656db3a535 Mon Sep 17 00:00:00 2001 From: Knut Petersen Date: