Re: Doc: standardise level 5 headings (2730) (issue 6443116)

LGTM other than one slightly quibble. http://codereview.appspot.com/6443116/diff/1/Documentation/common-macros.itexi File Documentation/common-macros.itexi (right): http://codereview.appspot.com/6443116/diff/1/Documentation/common-macros.itexi#newcode81 Documentation/common-macros.itexi:81:

Fix Issue 2529 configure should error for any missing software (issue 6464045)

LGTM http://codereview.appspot.com/6464045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix Issue 2366 THANKS needs updating or deleting (issue 6454140)

LGTM http://codereview.appspot.com/6454140/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Remove music typecheck in \endSpanners (issue 6443122)

LGTM http://codereview.appspot.com/6443122/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow all papersizes to be specified with a trailing papersize or landscape string. (issue 6461071)

LGTM http://codereview.appspot.com/6461071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: standardise level 5 headings (2730) (issue 6443116)

LGTM http://codereview.appspot.com/6443116/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix 2241: Proper copyright/header/tagline handling with multiple bookparts (issue 6448142)

LGTM http://codereview.appspot.com/6448142/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Tidies binary relocation (issue 6463066)

I haven't looked at the new logic in detail, but exactly what was LILYPOND_RELOCATE_PREFIX doing, and why do we no longer need it? If that was the environment variable that allowed me to build the documentation on osx without compiling lilypond, then I would be sad to see it go.

Re: Removes popen3 deprecated warning (issue 6471043)

Hmm. I'm not really qualified to comment on python+windows+GUB stuff, but are you certain that this won't re-open http://code.google.com/p/lilypond/issues/detail?id=1933 ? http://codereview.appspot.com/6471043/ ___ lilypond-devel mailing list

Re: Use directory-local variables to establish some coding styles in Emacs (issue 6460109)

Could you add a script (either shell or python) which applies this formatting to all scheme files in the repository? I'd like to see how that changes the scheme files. http://codereview.appspot.com/6460109/diff/3001/.dir-locals.el File .dir-locals.el (right):

Doc: MG: add incomplete dominant seventh chord (2749) (issue 6448170)

LGTM http://codereview.appspot.com/6448170/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: clarify page-breaking variables (2735) (issue 6453137)

LGTM http://codereview.appspot.com/6453137/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Regtest changes phase 1 (issue 6454121)

LGTM http://codereview.appspot.com/6454121/diff/7/input/regression/relative-repeat.ly File input/regression/relative-repeat.ly (right): http://codereview.appspot.com/6454121/diff/7/input/regression/relative-repeat.ly#newcode4 input/regression/relative-repeat.ly:4: system has alll the notes

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

LGTM http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: added link to enc2ly (issue 2706) (issue 6448169)

LGTM http://codereview.appspot.com/6448169/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Bar_engraver is required for system-start clefs (2694) (issue 6446160)

LGTM http://codereview.appspot.com/6446160/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG: All engravers should have double-quotes around them (issue 6461098)

LGTM, but two questions: 1) why should engravers have double-quotes? Was it only working by accident before, or are you hoping to simplify the parser by no longer accepting the non-quoted versions? 2) the patch title says CG:, but this doesn't touch the CG.

Git tree testing in make dist: do not require bash (issue 6484047)

LGTM http://codereview.appspot.com/6484047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 1236: CG+scripts should use $LILYPOND_GIT (issue 6483057)

LGTM, thanks! http://codereview.appspot.com/6483057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 1236: CG+scripts should use $LILYPOND_GIT (issue 6483057)

second thought, there's two remaining ones that should be changed: quick-start.itexi: line 285 programming-work.itexi: line 982 http://codereview.appspot.com/6483057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Check for Fontforge with enable-double (1637) (issue 6484062)

LGTM, I get the expected error from a stock ubuntu 12.04 (which does not include --enable-double). http://codereview.appspot.com/6484062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

http://codereview.appspot.com/6472056/diff/1/lily/fingering-column-engraver.cc File lily/fingering-column-engraver.cc (right): http://codereview.appspot.com/6472056/diff/1/lily/fingering-column-engraver.cc#newcode56 lily/fingering-column-engraver.cc:56: { I don't think that we shouldn't have a

Adds octavation-eight-interface to the Beam_collision_engraver (issue 6475065)

LGTM http://codereview.appspot.com/6475065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR 3.2.1: clarify titles and \header blocks (2652) (issue 6474066)

LGTM http://codereview.appspot.com/6474066/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6474066/diff/1/Documentation/notation/input.itely#newcode368 Documentation/notation/input.itely:368: A @code{\header} block. This

web: added tunefl to easier editing (issue 6486067)

LGTM http://codereview.appspot.com/6486067/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Run fixcc + astyle2.02.1 (issue 6477062)

This shows the difference between astyle 2.02 and 2.02.1. The only change is something* foo into something *foo which looks good to me because the rest of the source code sticks the * next to the variable name, rather than the variable type. If I can get two LGTMs, I'll push this directly

Re: Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

No, I'm wrong about that. astyle doesn't mind about the { as the only changes are removing trailing whitespace (could you fix emacs so it stops adding it?) and one line-break just before the }; on line 59 of lily/fingering-column.cc. http://codereview.appspot.com/6472056/

apply scripts/auxiliar/update-with-convert-ly.sh (issue 6488047)

LGTM, and I'm quite glad that a few new regtests got bumped to 2.16.0. Please push directly to staging. http://codereview.appspot.com/6488047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add W3C properties of border-*-radius after vendor ones (issue 2784) (issue 6489047)

LGTM, can be pushed directly to staging. http://codereview.appspot.com/6489047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for Cyrillic in Texinfo/TeX (issue 6492045)

LGTM http://codereview.appspot.com/6492045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Bump Fontforge version requirement (issue 1637) (issue 6479058)

LGTM, can be pushed directly to staging. http://codereview.appspot.com/6479058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 3.2.1: clarify titles and \header blocks (2652) (issue 6474066)

http://codereview.appspot.com/6474066/diff/5001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6474066/diff/5001/Documentation/notation/input.itely#newcode368 Documentation/notation/input.itely:368: A @code{\header} block. This

Creates getter and setter functions for buildings (issue 6496067)

http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh File lily/include/skyline.hh (right): http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh#newcode42 lily/include/skyline.hh:42: inline Real start () const { return start_; }; hmm... I personally would call

Reduce output from scripts during make doc (issue 6499068)

LGTM, please push directly to staging http://codereview.appspot.com/6499068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

adds programming errors. I've set it to patch-needs_work. http://codereview.appspot.com/6493073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc#newcode205 lily/self-alignment-interface.cc:205: // if coll is cross staff but

Re: Hard-coded version numbers updated (issue 6492072)

LGTM, please push to staging http://codereview.appspot.com/6492072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Update padding in light of skyline code changes; issue 1290 (issue 6503057)

LGTM http://codereview.appspot.com/6503057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes position of mensural c clef (issue 6503091)

http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (right): http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#newcode854 mf/parmesan-clefs.mf:854: draw_triple_brevis (exact_center + (0, 1.0 staff_space#), On 2012/09/07 18:27:36, lemzwerg

Re: Doc: Typos to LM - Fundamental and tweaks.itely (issue 6497103)

LGTM http://codereview.appspot.com/6497103/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: improve footnote documentation (2547) (issue 6498109)

LGTM http://codereview.appspot.com/6498109/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Add Elysium to Easier Editing (issue 6488101)

Hmm. IMO, Elysium should be listed under the text editors section, while the top recommended section should not be alphabetized. However, I'm open to a re-think of the page, wherein we drop the recommended-ness, and/or group programs differently, and/or whatever else might be good to change. I

Implement \hidden/\hide as a shorthands for \tweak/override #'\stencil = ##f (issue 6443087)

I'm really not happy with \hide vs. \hidden depending on whether it's override or tweak. How do we expect novice users (or moderate users) to know which they need to use? http://codereview.appspot.com/6443087/ ___ lilypond-devel mailing list

Re: layout.cc: do not draw empty boxes (issue 6450113)

http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode642 scm/fret-diagrams.scm:642: (corner1 from the context, I gather than corner1 is not guaranteed to be

Doc: extend explanation of relative-includes (2558) (issue 6490120)

LGTM http://codereview.appspot.com/6490120/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Improve documentation of \glissando. (issue 6529043)

We normally do not include \override in most sections of the Notation manual. Instead, we ask users to submit LSR snippets showing the \override, then we include those snippets in the docs. This allows us to improve the documentation with minimal effort on the part of developers. If there's a

Update help2man to latest release 1.40.12 (issue 6540043)

I only get upload in process, so I've added .pl files to git-cl exceptions. That said, I think this can be pushed directly. http://codereview.appspot.com/6540043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fix numeric tempi and detached lyrics in abc2ly (issue 6526045)

LGTM http://codereview.appspot.com/6526045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: document \time command fully (2807) (issue 6532055)

LGTM http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely#newcode1067 Documentation/notation/rhythms.itely:1067: \time #'(2 2 3) 7/8

Re: Web: Add Elysium to Easier Editing section (issue 6546059)

LGTM http://codereview.appspot.com/6546059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Added \clef treble_8 for guitar harmonics (issue 6588049)

LGTM https://codereview.appspot.com/6588049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ly/music-functions-init.ly:649: no = why not use omit instead of no ? I think that omit is

Re: Doc: extend description of glissandi (2844) (issue 6567059)

LGTM https://codereview.appspot.com/6567059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: improve documentation of Bézier curves (2858) (issue 6561064)

LGTM https://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6561064/diff/10001/Documentation/notation/changing-defaults.itely#newcode3901

Re: convert-ly (issue 2670) (issue 6610058)

The changelog says Don't update \version when no rule is applied. That's what the existing -d --diff-version-update command does. If this is intended to be the default behaviour now, then the command-line option should be removed. I would rather keep convert-ly as-is (in terms of this

Doc: scm file moved bar-extent to user properties (issue 5331052)

lgtm http://codereview.appspot.com/5331052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely#newcode1032 Documentation/notation/input.itely:1032: Automatic footnotes

Re: Improve HTML output of regression tests (issue 5342042)

http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304 scripts/build/output-distance.py:1304: if len (args) % 2 == 1: why is there a

Re: Adds some info about pure properties to the CG. (issue 5364048)

sure, looks fine. It's more important to get stuff into the CG than it is to fuss about the formatting or literary references. http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right):

Fix compile on OSX by including std-vector.hh instead of vector (issue 5437052)

this is the kind of patch that can in theory be pushed directly to staging, although in this case I'm glad there was a review first. http://codereview.appspot.com/5437052/diff/1/lily/include/lily-guile.hh File lily/include/lily-guile.hh (right):

Re: Doc: NR Added new node for Custom Footnotes (issue 5433064)

LGTM http://codereview.appspot.com/5433064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Update LSR and fix Issue 1971 (issue 5436073)

LGTM, please push to staging. http://codereview.appspot.com/5436073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Work around compiler bug, Issue 1997: segfault in tablature-negative-fret.ly (issue 5431088)

LGTM http://codereview.appspot.com/5431088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: CG: add instructions for staging branch (issue 5440080)

first pass at updated instructions for staging. It relies on the developer running git format-patch to create patches they want to apply to staging, since I don't know how to do it the proper way. Reviews giving better command lines are appreciated. http://codereview.appspot.com/5440080/

Re: Doc: CG: add instructions for staging branch (issue 5440080)

be to modify it. Cheers, - Graham http://codereview.appspot.com/5440080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Initial reduction of make doc op - Issue 2075 (issue 5453046)

Great start! There's a problem but I think I found out why. 1) (not the problem) could you print a blank line before+after the Please see block? That would help it to stand out more. 2) (problem) I added a mistake to something in tutorial.itely, and then got this: Child returned 1 Error

Re: Doc: NR 1.2.1 Ties - added @knownissue (issue 5453066)

Looks basically good, but could use a few alterations. http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5453066/diff/3001/Documentation/notation/rhythms.itely#newcode528

Doc: Glossary Added x-references for grace notes (issue 5452059)

LGTM http://codereview.appspot.com/5452059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Glossary Added x-references for grace notes (issue 5452059)

LGTM http://codereview.appspot.com/5452059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR improve 1.6.3 examples (issue 5448129)

LGTM http://codereview.appspot.com/5448129/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: CG: add instructions for staging branch (issue 5467051)

Reviewers: , Message: this is the second draft of the patch that was formerly here: http://codereview.appspot.com/5440080 Description: Doc: CG: add instructions for staging branch Please review this at http://codereview.appspot.com/5467051/ Affected files: M

Re: Doc: CG: add instructions for staging branch (issue 5467051)

I should clarify: I'm going to move pretty quickly on this one. As long as these instructions aren't completely garbage, I'll push them to staging in 24 hours. The rationale dates back to the original concept of the CG of being basically like a wiki -- we don't want to lose info by getting

Re: Initial reduction of make doc op - Issue 2075 (issue 5453046)

LGTM, fantastic work. This alone will save people *hours* of frustration. http://codereview.appspot.com/5453046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Now use astyle 2.02.1 (issue 5478072)

Reviewers: , Message: lilydev 2.0 currently contains astyle 2.02.1 Unfortunately, 2.02.1 produces slightly different formatting than 2.02. I would be fine with the 2.02.1 output, but I'm not certain it will meet with approval. Anybody object to this, and/or patch fixcc.py to produce the old

CG: explanation of branches for the impatient (issue 5484043)

Reviewers: , Message: CG now has N+1 different introductory explanations of git, where N is at least 3. But given the lack of familiarity with branches that I see in our development community, and the new staging stuff, I think this one is good. Once it's been accepted (in whatever form), I'll

Re: CG: explanation of branches for the impatient (issue 5484043)

thanks, Keith! I've made all the changes other than the two noted below. http://codereview.appspot.com/5484043/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right):

Re: CG: explanation of branches for the impatient (issue 5484043)

Second draft uploaded; more robust with rebases instead of merge. Question: the old docs want translators to avoid rebasing for some reason. Is that reason still valid? Because it would be very nice if we didn't have to have a separate section of git for translators.

Build fixes for translated manuals: dependencies and a typo (issue 5477088)

LGTM. Could you send me the final patch so I can push to staging immediately? http://codereview.appspot.com/5477088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Don't blindly issue the warning (issue 5477087)

LGTM, but I'm not confident enough about this patch to circumvent our review process, so please wait for it to go through a normal countdown. If a tex guru (like David, Werner, or Reinhold) says it's good, I'm willing to push it to staging directly. http://codereview.appspot.com/5477087/

Doc: NR Added glissando grob skip snippet to 1.3.3 (issue 5482050)

LGTM http://codereview.appspot.com/5482050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Updated entry for LANG in Usage (issue 5490060)

http://codereview.appspot.com/5490060/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): http://codereview.appspot.com/5490060/diff/1/Documentation/usage/running.itely#newcode486 Documentation/usage/running.itely:486: installation, possible entries are used

CG: Typos in Programming work and Regression tests sections. (issue 5490064)

LGTM, please send final patch for pushing directly to staging. http://codereview.appspot.com/5490064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Usage added note for Windows Users (issue 5489072)

LGTM http://codereview.appspot.com/5489072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

wow, I'd love to enable -Werror! You'll probably find a ton of more errors when running 'make check' -- apparently that compiles some stuff in flower/ that isn't compiled during a normal make. http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc File lily/beaming-pattern.cc

Re: Build: Dependencies for make website (issue 2027). (issue 5493074)

LGTM http://codereview.appspot.com/5493074/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/5493074/diff/1/make/website.make#newcode189 make/website.make:189: website-xrefs: website-version website-bibs $(OUT) $(xref-files) Do the xrefs really depend on

Doc: Two doc improvements for LP CLI in Usage (issue 5496063)

LGTM http://codereview.appspot.com/5496063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Build: Version dependency for python modules (issue 1726). (issue 5490067)

LGTM. Sorry for the delay; please push directly to staging. http://codereview.appspot.com/5490067/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR Added @knownissue for clashing note column (issue 5500043)

LGTM, please push directly to staging after fixing the typo. http://codereview.appspot.com/5500043/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right):

Re: Doc: Two doc improvements for LP CLI in Usage (issue 5496063)

please push directly to staging http://codereview.appspot.com/5496063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

On 2011/12/19 20:53:49, Julien Rioux wrote: Oh, I don't mean to suggest to pull your patch. I don't know if mine survives a review, for example. At the moment, I can see that they conflict. But the changes you suggest in this patch are useful. If they would be applied to

Emacs mode lines for parser.yy and lexer.ll (issue 5505059)

LGTM, please push directly to staging http://codereview.appspot.com/5505059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Hiding old website /web/install page (issue 5500069)

Sometimes I hate being right. I really wish that somebody had offered to mentor you -- the whole point of a mentor (i.e. somebody familiar with our development process) is to protect you against this kind of situation. 1) your solution will not work because the website is not built in the

Re: Hiding old website /web/install page (issue 5500069)

http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi File Documentation/contributor/website-work.itexi (right): http://codereview.appspot.com/5500069/diff/1/Documentation/contributor/website-work.itexi#newcode128

Re: Hiding old website /web/install page (issue 5500069)

On 2011/12/22 16:16:44, Graham Percival wrote: However, using website.make from git is certainly a security risk, which I will fix immediately on the server. Thanks for catching this! ick, this is what happens when jobs are left half-done. The server uses make-website.sh, which is defined

Re: Hiding old website /web/install page (issue 5500069)

On 2011/12/22 16:26:57, ambs wrote: Will poke you when needing some more info (sorry, you ended up being the mentor :)) ok. I'm not certain if this made its way into any documentation; I think it may only be present in emails to -devel. lilypond-extra repository:

Doc: NR @knownissues for #'ignore-collision (issue 5489119)

LGTM, please push to staging. http://codereview.appspot.com/5489119/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR improve 'visibility' of 'q' operation (issue 5489118)

typo http://codereview.appspot.com/5489118/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): http://codereview.appspot.com/5489118/diff/1/Documentation/notation/repeats.itely#newcode548 Documentation/notation/repeats.itely:548: @seealso there

Doc: Usage --include option layout consistency (issue 5504084)

LGTM http://codereview.appspot.com/5504084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes width of NR A.11 - List of special character (issue 5504091)

LGTM, please push to staging directly http://codereview.appspot.com/5504091/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Update lilygit.tcl (Issue 2092) (issue 5504092)

Thanks for working on this! Unfortunately I'm between cities at the moment; I'll try to comment more tomorrow evening. First thought: I'm a bit leery of adding a push to staging, since: 1. that clutters up the interface. Sure, it's just one more button, but OTOH that's 25% more buttons. :) 2.

<    1   2   3   4   5   6   7   8   9   10   >