LGTM, and some minor nits.
https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4#newcode625
aclocal.m4:625: AC_ARG_VAR(GUILE_FLAVOR, AS_HELP_STRING([],
What about breaking the line here to
>From visual checking I'm not sure whether your changes work as
expected...
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile
File lily/GNUmakefile (right):
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15
lily/GNUmakefile:15: LOADLIBES =
LGTM, thanks! I have some nits here and there, though.
https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely#newcode66
LGTM
https://codereview.appspot.com/577700043/
LGTM
https://codereview.appspot.com/563780044/
LGTM
https://codereview.appspot.com/575870044/
LGTM, with nits.
https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile
File flower/GNUmakefile (right):
https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17
flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS)
I suggest
LGTM
https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in
File GNUmakefile.in (right):
https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in#newcode26
GNUmakefile.in:26: RELEASE_FILES = RELEASE-COMMIT
Many GNU packages auto-generate a ChangeLog file from the
Too lazy to check every file, but according to the few samples I looked
at: LGTM, thanks!
https://codereview.appspot.com/573610048/
https://codereview.appspot.com/553700043/diff/555460043/mf/invoke-mf2pt.sh
File mf/invoke-mf2pt.sh (right):
https://codereview.appspot.com/553700043/diff/555460043/mf/invoke-mf2pt.sh#newcode18
mf/invoke-mf2pt.sh:18: # which no longer dump a .mem file
> > We could probably get rid of the .mem
LGTM
https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly
File input/regression/beaming-more-than-4-beams-normal-size.ly (right):
LGTM
https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly
File input/regression/cross-staff-stem-offset.ly (right):
https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly#newcode5
LGTM
https://codereview.appspot.com/559960060/
701 - 713 of 713 matches
Mail list logo