Re: aclocal.m4: Support GUILE_CONFIG, document GUILE_FLAVOR (issue 575860044 by d...@gnu.org)

2020-03-20 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, and some minor nits. https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4#newcode625 aclocal.m4:625: AC_ARG_VAR(GUILE_FLAVOR, AS_HELP_STRING([], What about breaking the line here to

Inline executable-* stepmake templates in lily/GNUmakefile (issue 577690043 by hanw...@gmail.com)

2020-03-20 Thread lemzwerg--- via Discussions on LilyPond development
>From visual checking I'm not sure whether your changes work as expected... https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile File lily/GNUmakefile (right): https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15 lily/GNUmakefile:15: LOADLIBES =

\compressFullBarRests should be renamed (issue 553750044 by v.villen...@gmail.com)

2020-03-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! I have some nits here and there, though. https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/553750044/diff/561590043/Documentation/changes.tely#newcode66

Stop installing TFM and Type1 fonts. (issue 577700043 by hanw...@gmail.com)

2020-03-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/577700043/

Inline elisp stepmake templates. (issue 563780044 by hanw...@gmail.com)

2020-03-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/563780044/

Inline scm stepmake templates (issue 575870044 by hanw...@gmail.com)

2020-03-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/575870044/

Cleanup flower/ makefile (issue 577700045 by hanw...@gmail.com)

2020-03-22 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, with nits. https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile File flower/GNUmakefile (right): https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17 flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS) I suggest

Trim unused toplevel targets. (issue 547810069 by hanw...@gmail.com)

2020-03-21 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in File GNUmakefile.in (right): https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in#newcode26 GNUmakefile.in:26: RELEASE_FILES = RELEASE-COMMIT Many GNU packages auto-generate a ChangeLog file from the

Re: Issue 5829: Re-indent all mf files (issue 573610048 by torsten.haemme...@web.de)

2020-03-08 Thread lemzwerg--- via Discussions on LilyPond development
Too lazy to check every file, but according to the few samples I looked at: LGTM, thanks! https://codereview.appspot.com/573610048/

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

2020-03-17 Thread lemzwerg--- via Discussions on LilyPond development
https://codereview.appspot.com/553700043/diff/555460043/mf/invoke-mf2pt.sh File mf/invoke-mf2pt.sh (right): https://codereview.appspot.com/553700043/diff/555460043/mf/invoke-mf2pt.sh#newcode18 mf/invoke-mf2pt.sh:18: # which no longer dump a .mem file > > We could probably get rid of the .mem

Re: Issue 5036: 128 beaming output not producing output as expected (?) (issue 559700043 by torsten.haemme...@web.de)

2020-03-24 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/559700043/diff/545760043/input/regression/beaming-more-than-4-beams-normal-size.ly File input/regression/beaming-more-than-4-beams-normal-size.ly (right):

Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by barr...@gmail.com)

2020-05-07 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly File input/regression/cross-staff-stem-offset.ly (right): https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly#newcode5

Remove ly:lexer-keywords command (issue 559960060 by d...@gnu.org)

2020-05-02 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/559960060/

<    3   4   5   6   7   8