Empty markup lines behavior change (maybe regression) in dev (2.21.7) than stable (2.20.0)

2020-10-08 Thread Jean Abou Samra
Try engrave this ly code: \version "2.20.0" > >/\header {/ >/title = \markup \column {/ >/\line { "Minuet" }/ >/\line { "" }/ >/\line { "" }/ >/}/ >/subtitle = "A study in accent and in the correct timing of half beats"/ >/}/ > {s} By lilypond v2.20.0: [image: image.png] By lilypond

Empty markup lines behavior change (maybe regression) in dev (2.21.7) than stable (2.20.0)

2020-10-07 Thread K.L.
Try engrave this ly code: \version "2.20.0" > > \header { > title = \markup \column { >\line { "Minuet" } >\line { "" } >\line { "" } > } > subtitle = "A study in accent and in the correct timing of half beats" > } > {s} By lilypond v2.20.0: [image: image.png] By lilypond

Re: input/regression/musicxml/41g-PartNoId.xml

2020-10-06 Thread Dan Eble
On Oct 5, 2020, at 19:53, Dan Eble wrote: > > I haven't worked with MusicXML, but I notice that this test apparently > contains a whole-measure rest, yet the ly generated in > input/regression/musicxml/out-test/41g-PartNoId.ly by "make check" does not. > It seems to

input/regression/musicxml/41g-PartNoId.xml

2020-10-05 Thread Dan Eble
I haven't worked with MusicXML, but I notice that this test apparently contains a whole-measure rest, yet the ly generated in input/regression/musicxml/out-test/41g-PartNoId.ly by "make check" does not. It seems to have been this way as far back as 2.12[1], but I questi

Re: regression tests for `lilypond-book`?

2020-09-04 Thread Werner LEMBERG
>> ... it doesn't do a comparison against correct input. > > The lilypond-book directory tests features of lilypond-book, but it > doesn't any real comparison. Meaningful comparison would be to compare > PDF files (after processing with LaTeX) across versions, I disagree. There are two issues

Re: regression tests for `lilypond-book`?

2020-09-03 Thread Han-Wen Nienhuys
On Wed, Sep 2, 2020 at 7:56 PM Werner LEMBERG wrote: > > So where's the problem? > > ... it doesn't do a comparison against correct input. The lilypond-book directory tests features of lilypond-book, but it doesn't any real comparison. Meaningful comparison would be to compare PDF files (after

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Werner LEMBERG
>> >> OK, but we don't have unit-testing for this directory either, >> >> right? > > And that descends into input/regression/lilypond-book: > https://gitlab.com/lilypond/lilypond/-/jobs/715114070#L88 OK, thanks, missed that, but... > So where's the prob

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Jonas Hahnfeld
Am Mittwoch, den 02.09.2020, 19:23 +0200 schrieb Werner LEMBERG: > >> OK, but we don't have unit-testing for this directory either, right? > > > > `make test` / `make check`? > > Yes. And that descends into input/regression/lilypond-book: https://gitlab.com/lilypon

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Werner LEMBERG
>> OK, but we don't have unit-testing for this directory either, right? > > `make test` / `make check`? Yes. > Why would you use `make doc` for that? I wouldn't. Werner

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Jonas Hahnfeld
Am Mittwoch, den 02.09.2020, 18:56 +0200 schrieb Werner LEMBERG: > >> It seems to me that not a single file in > >> > >> input/regression/lilypond-book > >> > >> gets processed during `make doc`. Has this ever worked? > > > > Appa

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Werner LEMBERG
>> It seems to me that not a single file in >> >> input/regression/lilypond-book >> >> gets processed during `make doc`. Has this ever worked? > > Apparently 2.14 had some content: > http://lilypond.org/doc/v2.14/input/regression/lilypond-bo

Re: regression tests for `lilypond-book`?

2020-09-02 Thread Jonas Hahnfeld
Am Mittwoch, den 02.09.2020, 18:37 +0200 schrieb Werner LEMBERG: > It seems to me that not a single file in > > input/regression/lilypond-book > > gets processed during `make doc`. Has this ever worked? Apparently 2.14 had some content: http://lilypond.org/doc/v2.14/i

regression tests for `lilypond-book`?

2020-09-02 Thread Werner LEMBERG
It seems to me that not a single file in input/regression/lilypond-book gets processed during `make doc`. Has this ever worked? Werner

Re: Remove input/regression/test-output-distance.ly (issue 575850043 by hanw...@gmail.com)

2020-04-12 Thread hanwenn
commit 8a74a0eb329d17154499441396e15811dca1e639 Author: Han-Wen Nienhuys Date: Fri Mar 20 13:28:03 2020 +0100 Remove input/regression/test-output-distance.ly The self-test for the output-distance.py script fulfills the same role in a more automated fashion. https

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-27 Thread hanwenn
superseeded by https://codereview.appspot.com/555360043/ https://codereview.appspot.com/547680043/

Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)

2020-02-24 Thread julien . rioux
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Han-Wen Nienhuys
On Sun, Feb 23, 2020 at 3:51 PM David Kastrup wrote: > We could, however, conceivably parallelize a lilypond-book job with PNG > backend and a lilypond-book job with PDF backend. I don't think that > those would share the same database (correct me if I am wrong). I have they share the same

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread David Kastrup
Dan Eble writes: > On Feb 23, 2020, at 09:11, David Kastrup wrote: >> >>> "Sharing Job Slots with GNU make" >>> https://www.gnu.org/software/make/manual/html_node/Job-Slots.html >> >> But that still doesn't solve the problem that the database approach of >> lilypond-book does not work for

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Dan Eble
On Feb 23, 2020, at 09:11, David Kastrup wrote: > >> "Sharing Job Slots with GNU make" >> https://www.gnu.org/software/make/manual/html_node/Job-Slots.html > > But that still doesn't solve the problem that the database approach of > lilypond-book does not work for running multiple

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Han-Wen Nienhuys
On Sun, Feb 23, 2020 at 3:36 PM Dan Eble wrote: > > On Feb 23, 2020, at 09:04, Han-Wen Nienhuys wrote: > > > >> What would you recommend to a developer who doesn't want to run more than > >> J = M + N - 1 concurrent jobs due to lilypond development? What values of > >> M and N would serve

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Dan Eble
On Feb 23, 2020, at 09:04, Han-Wen Nienhuys wrote: > >> What would you recommend to a developer who doesn't want to run more than J >> = M + N - 1 concurrent jobs due to lilypond development? What values of M >> and N would serve best? > > Normally M=N= #cpus should be OK. A bit of extra

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread David Kastrup
Dan Eble writes: > On Feb 23, 2020, at 06:08, Han-Wen Nienhuys wrote: >> I think we should do both: the lilypond runs in lp-book should be >> protected by some sort of lock, and we should use both CPU_COUNT=M and >> -jN. >> >> then worst case, you have M lilypond processes and N-1 other jobs.

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Han-Wen Nienhuys
On Sun, Feb 23, 2020 at 2:59 PM Dan Eble wrote: > > On Feb 23, 2020, at 06:08, Han-Wen Nienhuys wrote: > > I think we should do both: the lilypond runs in lp-book should be > > protected by some sort of lock, and we should use both CPU_COUNT=M and > > -jN. > > > > then worst case, you have M

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Dan Eble
On Feb 23, 2020, at 06:08, Han-Wen Nienhuys wrote: > I think we should do both: the lilypond runs in lp-book should be > protected by some sort of lock, and we should use both CPU_COUNT=M and > -jN. > > then worst case, you have M lilypond processes and N-1 other jobs. What would you recommend

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread David Kastrup
Han-Wen Nienhuys writes: > On Sun, Feb 23, 2020 at 12:00 PM wrote: >> > to answer your original question: I think the \sourcefileline >> statements can >> > differ between snippets written from different lp-book instances, and >> this can >> > trigger a consistency check failure. >> >> So

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread Han-Wen Nienhuys
On Sun, Feb 23, 2020 at 12:00 PM wrote: > > to answer your original question: I think the \sourcefileline > statements can > > differ between snippets written from different lp-book instances, and > this can > > trigger a consistency check failure. > > So wouldn't it appear that the way to

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread dak
On 2020/02/23 10:29:53, hanwenn wrote: > On 2020/02/23 10:04:46, hanwenn wrote: > > On 2020/02/23 09:49:24, dak wrote: > > > Stupid question: does the database design of lilypond-book even allow for > > > uncoordinated parallel runs? > > > > It's not a stupid question; it's a good question. > >

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread hanwenn
On 2020/02/23 10:04:46, hanwenn wrote: > On 2020/02/23 09:49:24, dak wrote: > > Stupid question: does the database design of lilypond-book even allow for > > uncoordinated parallel runs? > > It's not a stupid question; it's a good question. > > Writing files atomically (open temp file, write,

Re: Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread hanwenn
iption: Allow parallelism in input/regression/lilypond-book/ This is a 3x improvement, bringing down processing time at -j4 to ~20 seconds, down from 1 minute. Please review this at https://codereview.appspot.com/547680043/ Affected files (+1, -4 lines): M input/regression/lilypond-book/GNUma

Allow parallelism in input/regression/lilypond-book/ (issue 547680043 by hanw...@gmail.com)

2020-02-23 Thread dak
Stupid question: does the database design of lilypond-book even allow for uncoordinated parallel runs? https://codereview.appspot.com/547680043/

Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)

2020-02-22 Thread hanwenn
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile

Confirm grob-status in input/regression/multi-measure-rest-reminder.ly (issue 583530043 by thomasmorle...@gmail.com)

2020-02-20 Thread hanwenn
LGTM https://codereview.appspot.com/583530043/

Re: Confirm grob-status in input/regression/multi-measure-rest-reminder.ly (issue 547670044 by thomasmorle...@gmail.com)

2020-02-19 Thread hanwenn
LGTM https://codereview.appspot.com/547670044/

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-19 Thread hanwenn
commit e3be140a8141f0236cd489cd97e7fcf735653a0b Author: Han-Wen Nienhuys Date: Mon Feb 10 22:10:35 2020 +0100 input/regression/multi-measure-rest-reminder: a demo of user-defined grobs https://codereview.appspot.com/557380044/

Confirm grob-status in input/regression/multi-measure-rest-reminder.ly (issue 547670044 by thomasmorle...@gmail.com)

2020-02-17 Thread thomasmorley65
Reviewers: , Description: Confirm grob-status in input/regression/multi-measure-rest-reminder.ly Oversight Please review this at https://codereview.appspot.com/547670044/ Affected files (+2, -0 lines): M input/regression/multi-measure-rest-reminder.ly Index: input/regression/multi-measure

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-17 Thread thomasmorley65
On 2020/02/17 10:01:29, hanwenn wrote: > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly > File input/regression/multi-measure-rest-reminder.ly (right): > > https://codereview.appspot.com/557380044/diff/569320045/input/regr

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-17 Thread dak
On 2020/02/17 10:01:29, hanwenn wrote: > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly > File input/regression/multi-measure-rest-reminder.ly (right): > > https://codereview.appspot.com/557380044/diff/569320045/input/regr

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-17 Thread hanwenn
https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 input

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-16 Thread thomasmorley65
https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 input

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-16 Thread thomasmorley65
Sorry being that late to the party. Though, I'm confused. Iiuc a new grob called MultiMeasureRestReminder should be created. Alas, if I try to insert \override Voice.MultiMeasureRestReminder.after-line-breaking = #'() I get: warning: not a grob name, `MultiMeasureRestReminder' What am I missing?

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-11 Thread hanwenn
fixed nits. https://codereview.appspot.com/557380044/

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-11 Thread jonas . hahnfeld
On 2020/02/10 21:28:53, hahnjo wrote: > Thanks for providing a test. Not able to run it right now, maybe tomorrow. Looks good to me (modulo the nits), see https://sourceforge.net/p/testlilyissues/issues/5747/ for how the output looks like. https://codereview.appspot.com/557380044/

Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-11 Thread lilyfan
Are you a French forensics? (DNA is adn for us) https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi

input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-10 Thread jonas . hahnfeld
Thanks for providing a test. Not able to run it right now, maybe tomorrow. https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-07 Thread David Kastrup
hanw...@gmail.com writes: > LGTM > > nit: please use the commit SHA1 for referencing previous code. It is > self-contained, and doesn't need the internet for understanding the > context. For referencing previous issues, we have so far used the issue number, so that would be rather something to

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-07 Thread Han-Wen Nienhuys
On Fri, Feb 7, 2020 at 3:44 PM David Kastrup wrote: > > nit: please use the commit SHA1 for referencing previous code. It is > > self-contained, and doesn't need the internet for understanding the > > context. > > For referencing previous issues, we have so far used the issue number, > so that

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-07 Thread nine . fierce . ballads
On 2020/02/07 11:27:56, hanwenn wrote: > (why is this review closed?) Jonas reviewed the results and I pushed the change and closed the review. https://codereview.appspot.com/559460043/

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-07 Thread hanwenn
(why is this review closed?) https://codereview.appspot.com/559460043/

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-07 Thread hanwenn
LGTM nit: please use the commit SHA1 for referencing previous code. It is self-contained, and doesn't need the internet for understanding the context. https://codereview.appspot.com/559460043/

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-06 Thread nine . fierce . ballads
On 2020/02/06 09:59:26, hanwenn wrote: > can you add a pointer to the commit that introduces the previous code? I'm in > the middle of a laptop switch , so I can't look it up right now. I've added this link to the description of the current review.

Re: Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-06 Thread hanwenn
can you add a pointer to the commit that introduces the previous code? I'm in the middle of a laptop switch , so I can't look it up right now. https://codereview.appspot.com/559460043/

Issue 5736: Fix input/regression/context-find-parent.ly (issue 559460043 by nine.fierce.ball...@gmail.com)

2020-02-05 Thread nine . fierce . ballads
enabled by this patch. Description: https://sourceforge.net/p/testlilyissues/issues/5736/ Enable the previously reviewed block of code required to fix this regression test. Please review this at https://codereview.appspot.com/559460043/ Affected files (+1, -2 lines): M lily/context.cc Index

Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread David Kastrup
;cannot find or create context: ~a") 'Bottom) >> >> \header { >>texidoc = "A @code{\\defaultchild} cycle does not induce an endless loop. > > Got it, many thanks > >> >> So why is that patch not in your >> input/regression/context-defau

Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread Thomas Morley
. > > > > LilyPond > > Afterwards I've got a successful ´make´ with current LilyPond-master. > > ´make LANGS='' doc´ failed, though. > > > > The problem is /input/regression/context-defaultchild-cycle.ly > > I do not understand how this regtest survives any comp

Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread David Kastrup
ng configure to the correct guile > and guile-config to the correct places. This was due to my setup with > too many guile-versions around. So I did some clean up. > > LilyPond > Afterwards I've got a successful ´make´ with current LilyPond-master. > ´make LANGS='' doc´ failed, though.

Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread Thomas Morley
Am Mi., 22. Jan. 2020 um 00:41 Uhr schrieb Karlin High : > > On 1/21/2020 5:10 PM, Thomas Morley wrote: > > Afterwards I've got a successful ´make´ with current LilyPond-master. > > So it's a functional LilyPond with guile-3.0? How does it perform if fed > something big? I'm thinking of the thread

Re: guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread Karlin High
On 1/21/2020 5:10 PM, Thomas Morley wrote: Afterwards I've got a successful ´make´ with current LilyPond-master. So it's a functional LilyPond with guile-3.0? How does it perform if fed something big? I'm thinking of the thread on benchmarking that used Vaughan McAlley's MDSM.ly, the Robert

guile-3.0 and LilyPond - here: /input/regression/context-defaultchild-cycle.ly fails

2020-01-21 Thread Thomas Morley
places. This was due to my setup with too many guile-versions around. So I did some clean up. LilyPond Afterwards I've got a successful ´make´ with current LilyPond-master. ´make LANGS='' doc´ failed, though. The problem is /input/regression/context-defaultchild-cycle.ly I do not understand how

input/regression/footnote-auto-numbering-vertical-order.ly is broken

2019-12-15 Thread Thomas Morley
Hi, while working on #5640 "Fix regtests about Footnote" https://sourceforge.net/p/testlilyissues/issues/5640/ I noticed input/regression/footnote-auto-numbering-vertical-order.ly is broken. The problem is that since #1773 "Add Footnote_engraver to Score context" https

Issue 5635: show new regression-test cases (issue 577190043 by nine.fierce.ball...@gmail.com)

2019-12-12 Thread nine . fierce . ballads
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5635/ DEMO: http://faithful.be/tmp/test-results/ output-distance.py generates table rows for new test cases, i.e. cases not present in the baseline. Score images and profiling results appear in full. For logs and midi,

Re: Regression test flip feature

2019-10-18 Thread Carl Sorensen
On 10/18/19, 9:56 AM, "lilypond-devel on behalf of Dan Eble" wrote: Live demo: http://faithful.be/tmp/test-results Go to the images for rest-dot-position and press the "Flip" button under the right-hand image. The new image should change to the old image while the

Regression test flip feature

2019-10-18 Thread Dan Eble
Live demo: http://faithful.be/tmp/test-results Go to the images for rest-dot-position and press the "Flip" button under the right-hand image. The new image should change to the old image while the button is held. I've only tested it with the latest Safari for macOS, but I hope it works

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-13 Thread nine . fierce . ballads
I no longer plan to push context-global-*.ly, though I won't refresh the code review for it. By the time I'm done with some changes I'm working on, I think I'll have to overhaul those cases to take a different approach. https://codereview.appspot.com/348760043/

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-12 Thread Carl . D . Sorensen
On 2018/05/07 23:07:36, Dan Eble wrote: On 2018/05/07 22:53:29, Dan Eble wrote: > stop relying on duplicating type+ID Carl, I hope that these revisions address your concerns about the tests per se. After reviewing the revised tests, I am in favor of moving back to your original patch,

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-07 Thread nine . fierce . ballads
On 2018/05/07 22:53:29, Dan Eble wrote: stop relying on duplicating type+ID Carl, I hope that these revisions address your concerns about the tests per se. https://codereview.appspot.com/348760043/ ___ lilypond-devel mailing list

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-04 Thread nine . fierce . ballads
f an exhaustive search on performance. It might be interesting to experiment with forbidding creation of * a context with the same type+ID as any of its ancestors * siblings of the same type+ID and see what happens to the regression tests. That might be worth something, but unless the \change command

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-03 Thread Carl . D . Sorensen
icate Staff with ID of A". If we promise the behavior that your regression tests demonstrate, then we have developed an official scope for context IDs, and most LilyPond constructs do not have scope. But this is just my initial opinion, and I am certainly open to other arguments. Thanks, Ca

Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-02 Thread nine . fierce . ballads
on a better approach to testing, I'm all ears. James, please leave this in review until there is feedback. Description: Context regression tests Note that context-find-parent.ly currently fails. Please review this at https://codereview.appspot.com/348760043/ Affected files (+271, -0 lines

Issue 5283: Avoid different simultaneous marks in a regression test. (issue 341720043 by nine.fierce.ball...@gmail.com)

2018-03-04 Thread nine . fierce . ballads
lines): M input/regression/context-mod-with.ly Index: input/regression/context-mod-with.ly diff --git a/input/regression/context-mod-with.ly b/input/regression/context-mod-with.ly index 391e49da4848bc125cc22dfd46cd6ed17c18..fa5e426e84f82809fa96453e5aa70f9f332e8efa 100644 --- a/input

Re: Stagnant regression test output

2018-02-24 Thread Dan Eble
On Feb 16, 2018, at 07:49, Dan Eble wrote: > > At this point, I don’t have any reason to believe that there is a problem > affecting other people; however, I don’t have evidence to the contrary > either. It’s going to take me some time to get to the bottom of it. My >

Re: Stagnant regression test output

2018-02-24 Thread Phil Holmes
- Original Message - From: "David Kastrup" <d...@gnu.org> To: "Han-Wen Nienhuys" <hanw...@gmail.com> Cc: "LilyPond Development Team" <lilypond-devel@gnu.org> Sent: Saturday, February 24, 2018 9:31 AM Subject: Re: Stagnant regression te

Re: Stagnant regression test output

2018-02-24 Thread David Kastrup
Han-Wen Nienhuys <hanw...@gmail.com> writes: > There used to be a test that created a random layout (which should > always trigger), just to make sure that the regression test comparison > itself was working. Has this disappeared? No. --

Re: Stagnant regression test output

2018-02-24 Thread Han-Wen Nienhuys
There used to be a test that created a random layout (which should always trigger), just to make sure that the regression test comparison itself was working. Has this disappeared? On Fri, Feb 16, 2018 at 1:49 PM, Dan Eble <d...@faithful.be> wrote: > Last night, I noticed that the l

Re: Avoid duplicate rehearsal marks in regression tests (issue 334510043 by nine.fierce.ball...@gmail.com)

2018-02-20 Thread lilypond
. https://codereview.appspot.com/334510043/diff/1/input/regression/rehearsal-mark-formatters.ly File input/regression/rehearsal-mark-formatters.ly (right): https://codereview.appspot.com/334510043/diff/1/input/regression/rehearsal-mark-formatters.ly#newcode7 input/regression/rehearsal-mark

Avoid duplicate rehearsal marks in regression tests (issue 334510043 by nine.fierce.ball...@gmail.com)

2018-02-18 Thread nine . fierce . ballads
Reviewers: Malte Meyn, Message: Malte, This patch changes a regression test you committed in January. I think it still covers what you intended to cover. Description: Avoid duplicate rehearsal marks in regression tests Having multiple marks with the same sequence number is something

Stagnant regression test output

2018-02-16 Thread Dan Eble
Last night, I noticed that the log output for my local regression tests did not hold the updated output I expected after test-clean, check. It still held old output that did not match what my rebuilt lilypond binary produced in a manual run on the test input. I ended up deleting my whole

Re: Fix regression introduced with 5122 "Fix not scaling stem ..." (issue 337880043 by thomasmorle...@gmail.com)

2017-11-05 Thread rioujoel
It seems fine to me. This patch corrects the length of metronomic marks in my scores and I do not see side effects. https://codereview.appspot.com/337880043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

2017-11-05 Thread Thomas Morley
2017-06-13 11:24 GMT+02:00 David Kastrup <d...@gnu.org>: > Thomas Morley <thomasmorle...@gmail.com> writes: > >> As of >> https://sourceforge.net/p/testlilyissues/issues/5122/#99dc >> >> commit eee677c480c78d58a5215e246575aa94ba2d1897 >> >&g

Fix regression introduced with 5122 "Fix not scaling stem ..." (issue 337880043 by thomasmorle...@gmail.com)

2017-11-05 Thread thomasmorley65
Reviewers: , Message: Please review Description: Fix regression introduced with 5122 "Fix not scaling stem ..." commit eee677c480c78d58a5215e246575aa94ba2d1897 only took text-font-size from current layout into account. Now text-font-size from $defaultpaper is respected as well. A

Re: TupletNumber.avoid-slur regression?

2017-10-19 Thread David Kastrup
Jan-Peter Voigt <jp.vo...@gmx.de> writes: > Hi developers, > > I just stumbled over a regression 2.19.80. The following code works as > expected in 2.18 but kills the beam in 2.19.80: > > { > \override TupletNumber.avoid-slur = #'outside > \vo

TupletNumber.avoid-slur regression?

2017-10-19 Thread Jan-Peter Voigt
Hi developers, I just stumbled over a regression 2.19.80. The following code works as expected in 2.18 but kills the beam in 2.19.80: { \override TupletNumber.avoid-slur = #'outside \voiceOne \tuplet 3/2 { c''16[( b' a']) } } Or is there an undocumented change without a convert-ly rule

Re: regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

2017-06-13 Thread Thomas Morley
2017-06-13 11:24 GMT+02:00 David Kastrup <d...@gnu.org>: > Thomas Morley <thomasmorle...@gmail.com> writes: > >> As of >> https://sourceforge.net/p/testlilyissues/issues/5122/#99dc >> >> commit eee677c480c78d58a5215e246575aa94ba2d1897 >> >&g

Re: regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

2017-06-13 Thread David Kastrup
Thomas Morley <thomasmorle...@gmail.com> writes: > As of > https://sourceforge.net/p/testlilyissues/issues/5122/#99dc > > commit eee677c480c78d58a5215e246575aa94ba2d1897 > > introduced a regression. > > Not sure when I have the time to look deeper into it. >

regression introduced with issue 5122 "Fix not scaling stem in note-by-number-markup"

2017-06-12 Thread Thomas Morley
As of https://sourceforge.net/p/testlilyissues/issues/5122/#99dc commit eee677c480c78d58a5215e246575aa94ba2d1897 introduced a regression. Not sure when I have the time to look deeper into it. At first sight I've no good idea for a proper fix. So I suggest to revert it. At least it should

Re: 2.19.60 regression tests

2017-05-09 Thread James
Phil, On Tue, 9 May 2017 05:49:59 -0700 (MST) Phil Holmes <m...@philholmes.net> wrote: > In the regression test comparison: > > http://lilypond.org/test/v2.19.60-1/compare-v2.19.59-1/index.html > > A sign for a flat that I don't recognise has been changed to a > di

Re: 2.19.60 regression tests

2017-05-09 Thread James
On Tue, 9 May 2017 05:49:59 -0700 (MST) Phil Holmes <m...@philholmes.net> wrote: > In the regression test comparison: > > http://lilypond.org/test/v2.19.60-1/compare-v2.19.59-1/index.html > > A sign for a flat that I don't recognise has been changed to a > different on

2.19.60 regression tests

2017-05-09 Thread Phil Holmes
In the regression test comparison: http://lilypond.org/test/v2.19.60-1/compare-v2.19.59-1/index.html A sign for a flat that I don't recognise has been changed to a different one that I don't recognise. Is this expected for this release? -- View this message in context: http://lilypond

Re: What to do with input/regression/page-spacing.ly

2016-06-23 Thread tisimst
essage in context: http://lilypond.1069038.n5.nabble.com/What-to-do-with-input-regression-page-spacing-ly-tp191822p191860.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Re: What to do with input/regression/page-spacing.ly

2016-06-23 Thread Thomas Morley
2016-06-22 15:59 GMT+02:00 David Kastrup <d...@gnu.org>: > Thomas Morley <thomasmorle...@gmail.com> writes: > >> Hi, >> >> in input/regression/page-spacing.ly several commands for >> \overrideProperty >> Score.NonMusicalPaperColumn.line-bre

Re: What to do with input/regression/page-spacing.ly

2016-06-22 Thread David Kastrup
Thomas Morley <thomasmorle...@gmail.com> writes: > Hi, > > in input/regression/page-spacing.ly several commands for > \overrideProperty > Score.NonMusicalPaperColumn.line-break-system-details > ... > are applied, i.e. settings for Y-extent, refpoint-Y-e

Re: A regression

2016-06-21 Thread David Kastrup
Richard Shann writes: > (this happened after inserting a page break). It compiles ok with > 2.18.2. My question is, would it be helpful to anyone to have the file? > (Obviously cutting it down to a minimal example is not an option). \repeat unfold 2000 c'4 is a pretty

A regression

2016-06-21 Thread Richard Shann
I have a file that fails to compile with 2.19.43 with this message Starting lilypond 2.19.43 [junk.ly]... Processing `/tmp/frescobaldi-PRgtuJ/tmpBD232F/junk.ly' Parsing... Interpreting music...[8][16][24][32] Preprocessing graphical objects... Interpreting music...[8][16][24][32] Preprocessing

regression: point-and-click no longer includes absolute path

2016-05-13 Thread Mark Knoop
The commit below has broken point-and-click links for me on Linux. Embedded paths are now relative rather than absolute. It seems the assumption in the commit message that an absolute path is always returned is incorrect, as can be seen with the following example. Reverting scm/output-ps.scm

Re: Running the musicxml regression tests

2016-03-08 Thread David Kastrup
6, at 10:37 AM, John Gourlay <j...@weathervanefarm.net> >>>> wrote: >>>> I’m having trouble figuring out how to run the musicxml2ly >>>> regression tests automatically. Neither "make test” nor “make doc” >>>> nor both in succession seem to produ

Re: Running the musicxml regression tests

2016-02-24 Thread John Gourlay
@weathervanefarm.net> wrote: >>> I’m having trouble figuring out how to run the musicxml2ly regression tests >>> automatically. Neither "make test” nor “make doc” nor both in succession >>> seem to produce new ly files for the xml files in >>> i

Re: Running the musicxml regression tests

2016-02-24 Thread Federico Bruni
Il giorno mer 24 feb 2016 alle 18:03, Paul Morris <p...@paulwmorris.com> ha scritto: On Feb 24, 2016, at 10:37 AM, John Gourlay <j...@weathervanefarm.net> wrote: I’m having trouble figuring out how to run the musicxml2ly regression tests automatically. Neither "make tes

Re: Running the musicxml regression tests

2016-02-24 Thread Paul Morris
> On Feb 24, 2016, at 10:37 AM, John Gourlay <j...@weathervanefarm.net> wrote: > > I’m having trouble figuring out how to run the musicxml2ly regression tests > automatically. Neither "make test” nor “make doc” nor both in succession seem > to produce new ly files

Running the musicxml regression tests

2016-02-24 Thread John Gourlay
I’m having trouble figuring out how to run the musicxml2ly regression tests automatically. Neither "make test” nor “make doc” nor both in succession seem to produce new ly files for the xml files in input/regression/musicxml. Can anyone give me a pointer? John Go

input/regression/bookparts.ly fails at PDF conversion stage (issue 260790043 by thomasmorle...@gmail.com)

2015-08-13 Thread thomasmorley65
Reviewers: , Message: please review Description: input/regression/bookparts.ly fails at PDF conversion stage issue 4554 fixes \with-link let it look at the first page number of the entire book Please review this at https://codereview.appspot.com/260790043/ Affected files (+12, -9 lines

Python-ly to indent ../input/regression/a* (issue 249270044 by pkx1...@gmail.com)

2015-07-04 Thread tdanielsmusic
On balance the indentation is improved, but there are a few cases which are worse, IMHO. With a follow-up hand-indentation to uncorrect the worst cases this would be worth doing, if just to remove the tabs. Trevor https://codereview.appspot.com/249270044/diff/1/input/regression/alignment

  1   2   3   4   5   >