Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-07 Thread Marco Atzeri
On 05/04/2017 17:43, James wrote: On Wed, 5 Apr 2017 14:13:43 +0200 Marco Atzeri wrote: On 05/04/2017 10:27, thomasmorle...@gmail.com wrote: LGTM https://codereview.appspot.com/320830043/ Detection is fine, but another piece is missing (tested on 2.19.58) : This

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-05 Thread James
On Wed, 5 Apr 2017 14:13:43 +0200 Marco Atzeri wrote: > On 05/04/2017 10:27, thomasmorle...@gmail.com wrote: > > LGTM > > > > https://codereview.appspot.com/320830043/ > > > > Detection is fine, but another piece is missing (tested on 2.19.58) : This is not current

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-05 Thread Masamichi Hosoda
> On 05/04/2017 10:27, thomasmorle...@gmail.com wrote: >> LGTM >> >> https://codereview.appspot.com/320830043/ >> > > Detection is fine, but another piece is missing (tested on 2.19.58) : > > checking for guile... guile-1.8 > checking guile-1.8 version... 1.8.8 > checking for guile-1.8...

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-05 Thread Marco Atzeri
On 05/04/2017 10:27, thomasmorle...@gmail.com wrote: LGTM https://codereview.appspot.com/320830043/ Detection is fine, but another piece is missing (tested on 2.19.58) : checking for guile... guile-1.8 checking guile-1.8 version... 1.8.8 checking for guile-1.8... guile-1.8 checking for

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-05 Thread Carl . D . Sorensen
LGTM. And the reformatting is very nice. Thanks https://codereview.appspot.com/320830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

2017-04-05 Thread thomasmorley65
LGTM https://codereview.appspot.com/320830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel