Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2013-01-07 Thread pkx166h
author Thomas Morley thomasmorle...@googlemail.com Mon, 7 Jan 2013 15:37:33 + (15:37 +) committer James Lowe pkx1...@gmail.com Mon, 7 Jan 2013 15:39:54 + (15:39 +) commitfa9c6713e581994ed2882a0d447f40452caa713f I assumed Thomas didn't have push privileges based on last few

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread dak
On 2012/12/31 00:07:12, thomasmorley65 wrote: I thought about extending \draw-line with a 'style-property. But in extreme cases you would have to write: \markup { \override #'(style . dashed) \override #'(on . 0.5) \override #'(off . 0.2) \override #'(thickness . 2) \draw-line

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread david . nalesnik
Harm-- This looks great! Thank you for the 'full-length option. I can't be alone in hating lines ending with incomplete dashes. All I have is a suggestion or two, and some quibbles. Besides what I've pointed out inline, I should mention that I got a number of whitespace errors when I applied

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-31 Thread thomasmorley65
On 2012/12/31 14:59:45, david.nalesnik wrote: Harm-- This looks great! Thank you for the 'full-length option. I can't be alone in hating lines ending with incomplete dashes. Hi David, thanks for reviewing! All I have is a suggestion or two, and some quibbles. Besides what I've

Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-30 Thread thomasmorley65
Reviewers: , Message: Please review Description: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. Adding a reg-test for them. Please review this at https://codereview.appspot.com/7029045/ Affected files: A input/regression/markup-line-styles.ly M

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-30 Thread pkx166h
Excuse my ignorance but is the \xxx-xxx-xxx ok in terms of consistency of name of command and/or is 'draw' redundant? https://codereview.appspot.com/7029045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-30 Thread dak
On 2012/12/30 16:30:45, J_lowe wrote: Excuse my ignorance but is the \xxx-xxx-xxx ok in terms of consistency of name of command and/or is 'draw' redundant? \line arranges a text line, \draw-line draws an actual line, so the name choice seems ok. Another possibility would be to use

Re: Introducing two new markup-commands: draw-dashed-line and draw-dotted-line. (issue 7029045)

2012-12-30 Thread thomasmorley65
On 2012/12/30 16:42:56, dak wrote: On 2012/12/30 16:30:45, J_lowe wrote: Excuse my ignorance but is the \xxx-xxx-xxx ok in terms of consistency of name of command and/or is 'draw' redundant? \line arranges a text line, \draw-line draws an actual line, so the name choice seems ok.